Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-17 Thread nickclifton
Hi Colin, > Can you keep the commit message title to < 80 chars? And move the text from > the PR description into the commit message as well. Sorry about that, I will remember for next time. > Seems OK to me but: why don't the compilers do this by default? Because at the time that the notes

Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-17 Thread Mark Wielaard
Hi Nick, On Fri, 2019-06-14 at 09:29 -0700, nickclifton wrote: > This is a request to add support for compressing annobin notes found > in executable binaries built on Fedora and RHEL systems. > > The annobin project adds a note section to binary files describing > the security hardening

Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-17 Thread nickclifton
Hi Mark, > I don't think this should be part of add_minidebug (). It is something > that would need to happen even if we don't run add_minidebug (). Also > add_minidebug () runs after stripping/splitting the main ELF file into > a .debug file (which also gets a copy of all notes). > > I noticed

Re: [Rpm-maint] [rpm-software-management/rpm] %patchlist behavior is strange if put too high in a spec (#752)

2019-06-17 Thread Panu Matilainen
Closed #752. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/752#event-2419593232___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] %patchlist behavior is strange if put too high in a spec (#752)

2019-06-17 Thread Igor Gnatenko
``` […] # Upstream license specification: Apache-2.0 License:ASL 2.0 URL:https://crates.io/crates/prometheus Source: %{crates_source} %patchlist # Initial patched metadata # * Update hyper to 0.12,

[Rpm-maint] [PATCH 5/5] debugedit: Make sure .debug_line old/new idx start equal.

2019-06-17 Thread Mark Wielaard
Found by running the debugedit tests under valgrind. If the old and new .debug_line offset isn't changed then we might write out an uninitialized new_idx. --- tools/debugedit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/debugedit.c b/tools/debugedit.c index 84483ef..9f8dcd0 100644

[Rpm-maint] [PATCH 2/5] Add some debugedit tests.

2019-06-17 Thread Mark Wielaard
debugedit didn't have any direct tests, it was only tested indirectly through some other debuginfo testcases. So add some testcases that just test debugedit functionality directly. The tests create different kinds of ELF files (object files, partially linked files and executables) and run

[Rpm-maint] [PATCH 3/5] debugedit: Refactor reading/writing of relocated values.

2019-06-17 Thread Mark Wielaard
This refactors the reading and writing of relocated values into seperate helper functions (setup_relbuf and update_rela_data). It will be easier to reuse this code in case we want to read/write relocated values in other sections than DEBUG_INFO. The only functional change is that we explicitly

[Rpm-maint] debugedit: Add some testcases and handle .debug_macro (gcc -g3)

2019-06-17 Thread Mark Wielaard
Hi, debugedit wouldn't properly handle gcc -g3 which generates .debug_macro sections. The sections would contain references to .debug_str which debugedit rewrites. But it would not update the references in .debug_macro which would upset various tools. For example gdb:

[Rpm-maint] [PATCH 4/5] Handle .debug_macro in debugedit.

2019-06-17 Thread Mark Wielaard
When compiling with -g3 gcc will generate a .debug_macro section which has pointers to the .debug_str section. Since we might rewrite the .debug_str section, we also need to update any .debug_macro pointers. Updated the debugedit.at testcase by building everything with -g and add various checks

[Rpm-maint] [PATCH 1/5] Add some color to the tests if available and the terminal supports it.

2019-06-17 Thread Mark Wielaard
While working on some new testcases it helped to see the test results in color. We could all use some extra color while working on dull tasks. --- tests/local.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/local.at b/tests/local.at index 42eef1c..42c799b 100644 ---

Re: [Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)

2019-06-17 Thread Panu Matilainen
pmatilai commented on this pull request. > @@ -178,13 +179,17 @@ static int dateToTimet(const char * datestr, time_t * > secs, int * date_words) if (*secs == -1) goto exit; +if (tzname[1][0] == 0) + rpmlog(RPMLOG_WARNING, _("time zone in %%changelog not in tz database:

Re: [Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)

2019-06-17 Thread Panu Matilainen
pmatilai commented on this pull request. > @@ -44,7 +44,8 @@ static int dateToTimet(const char * datestr, time_t * secs, > int * date_words) struct tm time, ntime; const char * const * idx; char *p, *pe, *q, *date, *tz; -char tz_name[10]; /* name of timezone