I kind of fail to see the point, but I'll do it anyways just to please you.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
These are essentially unrelated changes, hence they belong to separate commits.
It might not seem that valuable to the author, but it makes reviewing much
easier, and the biggest value of strict commit-per-logical-change comes over
time from bisecting, cherry-picking etc.
Lumping such changes
@KOLANICH I'd rather you use the Debian bug reference than the patch URL. We
_have_ the patch, after all.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@KOLANICH pushed 1 commit.
6be64508deb6f79f9daa82f316e2fd13fac725f1 /scripts/check-rpaths: Do not use
bashism.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
I get that, but I was under the impression that ndb is still marked as
experimental. (That's about to change in the near future, though.)
Anyway, force pushed to multiple commits.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Merged #1004 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1004#event-2938440405___
Rpm-maint mailing list
Oh, I don't see experimental status affecting change-per-commit requirement at
all, as the commits will remain forever regardless of the status. Various other
aspects can be somewhat relaxed on experimental code of course.
Anyway, splitting up much appreciated, thanks.
--
You are receiving
Yes, the patch URL is uninteresting and irrelevant, a link to the *bug* would
be relevant. Also the "original message" and quotation just makes it
unnecessarily strange. Just do as @Conan-Kudo requested in
https://github.com/rpm-software-management/rpm/pull/984#issuecomment-570160992,
thanks.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1005
-- Commit Summary --
* ndb: only clear the dbenv in the rpmdb if the last reference is gone
* ndb: add a rpmxdbDelAllBlobs method
* ndb: implement index regeneration
Merged #1003 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1003#event-2937695014___
Rpm-maint mailing list
Closed #1002 via #1003.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1002#event-2937695020___
Rpm-maint mailing list
Merged #997 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/997#event-2937694143___
Rpm-maint mailing list
Yup, much better now :)
Thanks for the patch!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/997#issuecomment-572928117___
Please split to individual commits.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1004#issuecomment-572929304___
Rpm-maint
14 matches
Mail list logo
