Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)

2020-06-11 Thread Panu Matilainen
...but other than the nit about the setenv/getenv thing, looks fine.
Special thanks for the thorough explanation of the issues in the commit message!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#issuecomment-642446435___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Execute tests in independent testing roots to enable parallel running (#1268)

2020-06-11 Thread Panu Matilainen
Up to now weve run tests in a mish-mash of an environment where bits and 
pieces of previous tests might exist, and as state has been shared its 
been impossible to execute tests in parallel.

This makes the pre-populated testing-root read-only to the owner to force all 
writers to perform an extra setup call to gain a private testing environment. 
Most of the users needing this already had RPMDB_INIT calls to ensure clean 
rpmdb state so thats where this is hooked onto.

Theres a fair bit of gymnastics with the environment to make things match 
on both sides of fakechroot, some of which can hopefully go away eventually 
once the dust from this settles. This is also rather heavy as it is, on my 
laptop serial execution goes down from ~1m15s to ~1m45s, but then parallel 
execution with -j8 is down to ~50s. There should be a number of optimizations 
that can be made, such as setting up links for writable directories instead of 
copying the entire testing-tree around, but leaving that as a future exercise. 
This is more of an enabler than the goal state.

Note that this does *not* enable test-suite parallel running for `make -jN 
check`, because `make` does not export the -j argument in a way that we could 
pass to `./rpmtests` from the makefile. To enable that, one needs to pass a 
suitable -jN argument through TESTSUITEFLAGS, such as `make -j8 check 
TESTSUITEFLAGS=-j8`. Or run invoke `rpmtests` manually.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1268

-- Commit Summary --

  * Always refer to our testing root directory via ${RPMTEST}
  * Merge RPMDB_CLEAR into RPMDB_INIT, theyre never used separately
  * Add missing RPMDB_INIT wherever we write something in the tests
  * Run tests sharing built material as groups
  * Use testroot, not host configuration for finding lua init directory
  * Dont assume pre-existing /opt in replace tests
  * Execute tests in independent testing roots to enable parallel running

-- File Changes --

M tests/Makefile.am (4)
M tests/atlocal.in (18)
M tests/debugedit.at (1)
M tests/local.at (23)
M tests/rpmbuild.at (169)
M tests/rpmbuildid.at (82)
M tests/rpmconfig.at (25)
M tests/rpmconfig2.at (22)
M tests/rpmconfig3.at (8)
M tests/rpmconflict.at (40)
M tests/rpmdb.at (18)
M tests/rpmdeps.at (36)
M tests/rpmi.at (114)
M tests/rpmio.at (2)
M tests/rpmmacro.at (7)
M tests/rpmorder.at (3)
M tests/rpmpython.at (2)
M tests/rpmquery.at (35)
M tests/rpmreplace.at (23)
M tests/rpmscript.at (5)
M tests/rpmsigdig.at (18)
M tests/rpmverify.at (19)
M tests/rpmvfylevel.at (5)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1268.patch
https://github.com/rpm-software-management/rpm/pull/1268.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1268
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Execute tests in independent testing roots to enable parallel running (#1268)

2020-06-11 Thread Panu Matilainen
@pmatilai pushed 1 commit.

320a7c8ae91a1cc3a8d45d40acc0a52965298463  Remove now redundant TOPDIR removals 
from tests


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1268/files/871f03a9213b9ab72825f6c4dad4ba39494b6b37..320a7c8ae91a1cc3a8d45d40acc0a52965298463
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the "rpmbuild debuginfo -g3 .debug_macro" test an expected fail … (#1267)

2020-06-11 Thread Tom Stellard
After more investigation, I discovered the the .debug_macro section is not a 
DWARF5 feature and is supported by clang when using the -fdebug-macro option.  
I've updated the spec file for this test to use this option when building with 
clang.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1267#issuecomment-643010658___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint