[Rpm-maint] [rpm-software-management/rpm] Fix (work around) FA_TOUCH not scoping correctly over hardlinks (#1279)
The existing FSM code doesnt correctly handle FA_TOUCH on hardlinked file sets, which causes the hardlink set to break on at least some upgrade scenarios when minimize_writes is enabled. Only enable FA_TOUCH on non-hardlinked files to work around the issue for now. While at it, rearrange the conditionals around min_writes to make it a bit clearer. Testcase adopted from original reproducer by Fabian Vogt, thanks! Fixes: #1278 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1279 -- Commit Summary -- * Fix (work around) FA_TOUCH not scoping correctly over hardlinks -- File Changes -- M lib/transaction.c (17) M tests/Makefile.am (1) A tests/data/SPECS/hlbreak.spec (22) M tests/rpmverify.at (24) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1279.patch https://github.com/rpm-software-management/rpm/pull/1279.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1279 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild should report missing files for all subpackages (#1277)
I think it depends. I had packaged MariaDB, which is big too. And they change a lot of things during each minor release. To get all changes I had to do the rebuilt for 10 times. Each one consuming 30 minutes. If I had all missing/duplicate files at once, I think this can be done in 2 rebuilds. If possible, maybe we can have a switch to continue and report them all. So each one can decide which option fits to him or the package to build. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1277#issuecomment-647997464___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] RPM 4.16.0 beta2 released!
Some fairly important fixes cropped up in the last few weeks so we decided to go with a second beta for a change. The highlights since beta1 include: - fix hardlink breakage on upgrade when minimize_writes is enabled - fix some file triggers missed with sqlite backend - fix SSD optimizations also enabling IO-flushing - fix too small signature header size limit - fix fail build on dependency generator and %_build_pkgcheck_set errors - fix data race in threaded package generation - fix metainfo dependency generator regression - fix Python addErase() not raising exception on non-existent packages - fix test-suite parallel execution Download info & further details at: https://rpm.org/wiki/Releases/4.16.0 On behalf of rpm-team, - Panu - ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)
@pmatilai pushed 2 commits. 43a4608d2b0012b1799d6de8366bc1762c80af48 Update popt download location 2bb712eb584e36161ddb521f991cba1312403f05 Preparing for rpm 4.16.0-beta2 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1281/files/1434c21c450b77de1fe7d73e2e74d50c25aa587a..2bb712eb584e36161ddb521f991cba1312403f05 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)
Merged #1281 into rpm-4.16.x. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1281#event-3472632758___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)
This pull request **fixes 1 alert** when merging 5936122a35ed522f2c59fa656506a44d86a7270f into e50e0a8fe9f7976a00a2909f72a300cec97b82d4 - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-30aaffc331b8ddb00e701d925951e97cc1586cdf) **fixed alerts:** * 1 for Unnecessary delete statement in function -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1281#issuecomment-648105077___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Update popt download location (#1282)
Merged #1282 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1282#event-3472572629___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] Announcing POPT upstream reboot and 1.18 release!
At the time of the rpm.org upstream reboot back in 2006 [1], the idea was to split out popt from the rpm codebase and then ... something. Only we were too busy dealing with rpm itself and popt got left behind. The last popt release is from 2010 and about a year ago it's download site dropped off the net. People have been prodding us about this for some time now, popt being a mandatory dependency of rpm but also used by several other prominent OSS projects such as Samba, SSSD and Gnome. So after heroic efforts of Neal Gompa to convert the rusty old CVS (anybody still remember *that* horror?) repo into a nice shiny git repo, here goes. From now on, popt will be maintained under the rpm-software-management umbrella at https://github.com/rpm-software-management/popt where bugs can be reported and pull-requests submitted, with release tarballs on at http://ftp.rpm.org/popt/ To accompany the launch there's also a new 1.18 release: https://github.com/rpm-software-management/popt/releases/tag/popt-1.18-release http://ftp.rpm.org/popt/releases/popt-1.x/popt-1.18.tar.gz Much like with rpm itself back in the day, this first release is all about collecting existing fixes and cleaning up the codebase, starting with the last widely used 1.16 release as the basis. There are no new features in this release or in the immediate plans, time will tell where this all will lead. More details in the release notes, but the executive summary of changes since 1.16 is: - fix an ugly and ancient security issue with popt failing to drop privileges on alias exec from a SUID/SGID program - perform rudimentary sanity checks when reading in popt config files - collect accumulated misc fixes (memleaks etc) from distros - convert translations to utf-8 encoding - dust off ten years worth of autotools sediment - reorganize and clean up the source tree for clarity - remove the obnoxious splint annotations from the sources 1.18 is supposed to be fully ABI and API compatible with 1.16 to enable easy upgrading to a supported version. On behalf of the rpm-team, - Panu - ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make the "rpmbuild debuginfo -g3 .debug_macro" test an expected fail … (#1267)
@pmatilai It would definitely be nice to wire up some clang testing, since OpenMandriva and macOS use clang as the default compiler -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1267#issuecomment-648006790___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Discussion: How to handle Python extras (#1061)
We have proposed this in Fedora: https://fedoraproject.org/wiki/Changes/PythonExtras -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1061#issuecomment-648082385___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] only install rpm-plugin-selinux.8 if enabled (#1247)
Closed #1247. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1247#event-3471955830___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] only install rpm-plugin-selinux.8 if enabled (#1247)
As mentioned earlier, if we do this for one conditional thing we should do it for all of them, and also this would cause the selinux manual to be skipped from the dist tarball too depending on the enable/disable status, which is wrong. A more complete patch submitted as PR #1280, but thanks for the patch as an inspiration. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1247#issuecomment-648015860___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
Merging as is for now, thanks for the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#issuecomment-648045721___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)
Pull various important fixes + the test-suite parallelisation effort to avoid
having to deal with test conflicts with upstream for the 4.16 lifetime.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1281
-- Commit Summary --
* rpmbuild: Create full build tree after parsing a spec file
* rpmbuild: Do not create a %_sourcedir / %_specdir
* Refactor pre-flight checks for added packages to helper function
* Add a pre-flight check for removed packages too
* Fix: bump up the limit of signature header to 64MB
* Dont auto-enable IO flushing on non-rotational disks
* Unify Python addInstall/Reinstall/Erase exception message format
* Fix python ts.addErase() not raising exception on not-found packages
* metainfo.attr: Fix execution of the generator
* Fail the build if %_build_pkgcheck_set failed
* Fix completely broken prefix search on sqlite backend
* Fix .debug_macro test with clang
* Fix data race in packageBinaries() function
* Always refer to our testing root directory via ${RPMTEST}
* Merge RPMDB_CLEAR into RPMDB_INIT, theyre never used separately
* Add missing RPMDB_INIT wherever we write something in the tests
* Run tests sharing built material as groups
* Use testroot, not host configuration for finding lua init directory
* Dont assume pre-existing /opt in replace tests
* Execute tests in independent testing roots to enable parallel running
* Remove now redundant TOPDIR removals from tests
* Merge obsoletion tests sharing built content to single group
* Merge dependency tests sharing built material to common groups
* Run CI test-suite in parallel, limit parallelism to $(nproc)
* Merge %config tests sharing built content into common groups
* Merge %config symlink tests sharing built content into common groups
* Merge config filetype change tests sharing built content into common groups
* Merge file type replacement tests sharing built content into common groups
* Merge spec conditional tests into one group
* Eliminate redundant source file copying from build tests
* Merge minimize_writes tests sharing built content into common groups
* Merge --addsign tests into a a common group
* Localize gpg-agent setup to --addsign tests
* macros: force add files to git index
* Always fail build on dependency generator failures (#1183)
* Add --excludeartifacts install option
* Account for symlinks in total package size (RhBug:1848199)
* Fix (work around) FA_TOUCH not scoping correctly over hardlinks
* Dont install man pages for disabled features
* Preparing for rpm 4.16.0-beta2
-- File Changes --
M build/files.c (11)
M build/pack.c (9)
M build/rpmfc.c (32)
M ci/Dockerfile (2)
M configure.ac (2)
M doc/Makefile.am (32)
M doc/rpm.8 (4)
M fileattrs/metainfo.attr (2)
M lib/backend/sqlite.c (51)
M lib/header.c (2)
M lib/poptI.c (3)
M lib/rpmprob.c (5)
M lib/rpmts.h (3)
M lib/transaction.c (143)
M macros.in (8)
M po/ar.po (276)
M po/br.po (280)
M po/ca.po (280)
M po/cmn.po (280)
M po/cs.po (280)
M po/da.po (280)
M po/de.po (280)
M po/el.po (275)
M po/eo.po (280)
M po/es.po (280)
M po/fi.po (280)
M po/fr.po (280)
M po/id.po (275)
M po/is.po (279)
M po/it.po (280)
M po/ja.po (280)
M po/ko.po (280)
M po/ms.po (275)
M po/nb.po (280)
M po/nl.po (276)
M po/pl.po (280)
M po/pt.po (280)
M po/pt_BR.po (280)
M po/rpm.pot (277)
M po/ru.po (0)
M po/sk.po (0)
M po/sl.po (0)
M po/sr.po (0)
M po/s...@latin.po (0)
M po/sv.po (0)
M po/te.po (0)
M po/tr.po (0)
M po/uk.po (0)
M po/vi.po (0)
M po/zh_CN.po (0)
M po/zh_TW.po (0)
M python/rpm/transaction.py (0)
M rpmbuild.c (0)
M tests/Makefile.am (0)
M tests/atlocal.in (0)
M tests/data/SPECS/hello-g3.spec (0)
A tests/data/SPECS/hlbreak.spec (0)
M tests/debugedit.at (0)
M tests/local.at (0)
M tests/rpmbuild.at (0)
M tests/rpmbuildid.at (0)
M tests/rpmconfig.at (0)
M tests/rpmconfig2.at (0)
M tests/rpmconfig3.at (0)
M tests/rpmconflict.at (0)
M tests/rpmdb.at (0)
M tests/rpmdeps.at (0)
M tests/rpmi.at (0)
M tests/rpmio.at (0)
M tests/rpmmacro.at (0)
M tests/rpmorder.at (0)
M tests/rpmpython.at (0)
M tests/rpmquery.at (0)
M tests/rpmreplace.at (0)
M tests/rpmscript.at (0)
M tests/rpmsigdig.at (0)
M tests/rpmverify.at (0)
M tests/rpmvfylevel.at (0)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/1281.patch
https://github.com/rpm-software-management/rpm/pull/1281.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1281
___
Rpm-maint mailing list
[Rpm-maint] [rpm-software-management/rpm] Don't install man pages for disabled features (#1280)
Doesnt make much sense to install manuals for features that are not enabled in a build. Conditionalize our man page installation where necessary, taking care to include the manuals in tarballs regardless of configured status. Inspired by PR (#1247) from Thierry Vignaud You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1280 -- Commit Summary -- * Dont install man pages for disabled features -- File Changes -- M doc/Makefile.am (32) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1280.patch https://github.com/rpm-software-management/rpm/pull/1280.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1280 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)
Merged #1271 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1271#event-3472161361___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
Closed #1183 via #1271. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#event-3472161387___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Account for symlinks in total package size (RhBug:1848199) (#1275)
Merged #1275 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1275#event-3472164261___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix (work around) FA_TOUCH not scoping correctly over hardlinks (#1279)
Merged #1279 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1279#event-3472164907___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't install man pages for disabled features (#1280)
Merged #1280 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1280#event-3472165281___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Package upgrades break if hardlinks got added (#1278)
Closed #1278 via #1279. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1278#event-3472164919___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
Merged #1246 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#event-3472197426___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Package upgrades break if hardlinks got added (#1278)
Thanks for the quick fix! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1278#issuecomment-648050421___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add --excludeartifacts install option (#1274)
Merged #1274 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1274#event-3472180157___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Rpm 4.16 beta2 (#1281)
This pull request **fixes 1 alert** when merging 1434c21c450b77de1fe7d73e2e74d50c25aa587a into e50e0a8fe9f7976a00a2909f72a300cec97b82d4 - [view on LGTM.com](https://lgtm.com/projects/g/rpm-software-management/rpm/rev/pr-84871d636d7ad0c5305651d5d4151647befc5b71) **fixed alerts:** * 1 for Unnecessary delete statement in function -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1281#issuecomment-648058283___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Update popt download location (#1282)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1282 -- Commit Summary -- * Update popt download location -- File Changes -- M INSTALL (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1282.patch https://github.com/rpm-software-management/rpm/pull/1282.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1282 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Package upgrades break if hardlinks got added (#1278)
Thanks for reporting and the nice reproducer! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1278#issuecomment-648046616___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [Rpm-announce] RPM 4.16.0 beta2 released!
Le mar. 23 juin 2020 à 14:41, Panu Matilainen a écrit : > > Some fairly important fixes cropped up in the last few weeks so we > decided to go with a second beta for a change. The highlights since > beta1 include: > > - fix hardlink breakage on upgrade when minimize_writes is enabled > - fix some file triggers missed with sqlite backend > - fix SSD optimizations also enabling IO-flushing > - fix too small signature header size limit > - fix fail build on dependency generator and %_build_pkgcheck_set errors > - fix data race in threaded package generation > - fix metainfo dependency generator regression > - fix Python addErase() not raising exception on non-existent packages > - fix test-suite parallel execution > > Download info & further details at: > > https://rpm.org/wiki/Releases/4.16.0 > > On behalf of rpm-team, > It doesn't compile on arches other than x86_64 (see my comment in the appropriate thread) (due to hardcoded x86_64 in expected test output) ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)
@dmnks pushed 2 commits. 7080e2456d513d54538129a4d414848591b49508 GPG: Switch back to pipe(7) for signing 5e81da9a19f576ad35d6358ed3d29787f8a708cc GPG: refactor: clean up exit label -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/938/files/fe877767eb2350c1537f163e5f07d9ab950f5ab6..5e81da9a19f576ad35d6358ed3d29787f8a708cc ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)
@dmnks pushed 2 commits. 5b3831f7d5d76bfefcd2a28a5aabddc39866da19 GPG: Switch back to pipe(7) for signing e91e2ad55e18131aea621f3c2e6772bc891d1aa4 GPG: refactor: clean up exit label -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/938/files/5e81da9a19f576ad35d6358ed3d29787f8a708cc..e91e2ad55e18131aea621f3c2e6772bc891d1aa4 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)
Rebased and fixed the `%m` thing. Apologies for the long "round-trip delay time" on this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/938#issuecomment-648253508___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)
@dmnks commented on this pull request.
>
if (gpg_path && *gpg_path != '\0')
(void) setenv("GNUPGHOME", gpg_path, 1);
+ if (tty)
+ setenv("GPG_TTY", tty, 0);
+ else if (!getenv("GPG_TTY"))
+ rpmlog(RPMLOG_WARNING, _("Could not set GPG_TTY to stdin: %m\n"));
Yeah, this was a bit sloppy, I agree. The `getenv()` test was supposed to
handle the case where the automatic setup of `GPG_TTY` failed and the variable
wasn't explicitly set by the user either. Let me try to express that better in
a followup amend :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#discussion_r444301782___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)
Merged #938 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/938#event-3475894319___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] GPG: Switch back to pipe(7) for signing (#938)
@pmatilai approved this pull request. Ok, I think we're good to go now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-436342767___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
