Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-24 Thread soig
Also rpm's own fontconfig.prov is broken: http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log

Re: [Rpm-maint] RPM 4.16.0 beta3 released!

2020-06-24 Thread Thierry Vignaud
Le mer. 24 juin 2020 à 10:47, Panu Matilainen a écrit : > > This fixes multiple dependency generator related regressions introduced > beta2, by reverting the "fail build on dependency generator failure" > change introduced there. > > We don't usually release new tarballs just because an issue

[Rpm-maint] [rpm-software-management/rpm] GPG_TTY warning causes test-suite failure in mock (#1290)

2020-06-24 Thread Panu Matilainen
Seems that something in mock environment trips up the new GPG_TTY related warning, causing (a bogus) test-suite failure due to the extra output: https://download.copr.fedorainfracloud.org/results/pmatilai/rpm-snapshot/fedora-rawhide-x86_64/01499743-rpm/build.log.gz ``` --- /dev/null 2020-06-24

Re: [Rpm-maint] [rpm-software-management/rpm] GPG_TTY warning causes test-suite failure in mock (#1290)

2020-06-24 Thread Michal Domonkos
Oh my. Thanks for sharing, I'll check that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1290#issuecomment-648804803___

Re: [Rpm-maint] [rpm-software-management/rpm] GPG_TTY warning causes test-suite failure in mock (#1290)

2020-06-24 Thread Panu Matilainen
No worries, it's not the first (or last) time mock trips up something because it's a rather special environment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [Rpm-announce] RPM 4.16.0 beta2 released!

2020-06-24 Thread Thierry Vignaud
Le mar. 23 juin 2020 à 14:41, Panu Matilainen a écrit : > > Some fairly important fixes cropped up in the last few weeks so we > decided to go with a second beta for a change. The highlights since > beta1 include: > > - fix hardlink breakage on upgrade when minimize_writes is enabled > - fix

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-24 Thread Panu Matilainen
On 6/24/20 9:30 AM, soig wrote: > Also rpm's own fontconfig.prov is broken: > http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log >

Re: [Rpm-maint] [rpm-software-management/rpm] Not ignoring generator failure shows strange issue (#1285)

2020-06-24 Thread soig
Adding: + printf("mname='%s', cmd='%s' (callable=%d)\n", mname, cmd, callable); Shows the following: grep _font RES1 -1 mname='__elf_provides', cmd='/usr/lib/rpm/elfdeps --provides ' (callable=0) mname='__font_provides', cmd=' ' (callable=0) mname='__gobjectintrospection_provides',

[Rpm-maint] [rpm-software-management/rpm] Release 4.16 beta3 (#1287)

2020-06-24 Thread Panu Matilainen
Reverts the broken dependency generator failure commit. Beta2 was released to address that sort of annoyances with beta1 and introducing new ones goes against the spirit of having a trouble-free beta experience. You can view, comment on, or merge this pull request online at:

Re: [Rpm-maint] [rpm-software-management/rpm] Since beta2 introducing // mode, some files are not removable during %clean (#1289)

2020-06-24 Thread soig
Actually with beta3, I can reproduce it locally: $ LC_ALL=C rm -fr BUILD/rpm-4.16.0-beta3/ (…) rm: cannot remove 'BUILD/rpm-4.16.0-beta3/tests/testing/data/SPECS/test-subpackages-pathpostfixes.spec': Permission denied rm: cannot remove

Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)

2020-06-24 Thread Panu Matilainen
Yup, and there's more: every caller of rpmfcExec() does so with slightly different expectations of what will happen in what situations, and rpmfcHelper() was doing +1 on errors whereas the lower layers were returning -1 and ... whatnot. It needs a *careful* review on reapproach. -- You are

Re: [Rpm-maint] [rpm-software-management/rpm] Fix depgen failure test to be architecture independent, doh (#1283)

2020-06-24 Thread Panu Matilainen
Closed #1283. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1283#event-3476168453___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)

2020-06-24 Thread Panu Matilainen
Nah, it deserves to be reverted because it can't be fixed by any one little thing, it's broken in more ways than we have tickets for and we have two already. It really needs a restart from scratch. -- You are receiving this because you are subscribed to this thread. Reply to this email

[Rpm-maint] RPM 4.16.0 beta3 released!

2020-06-24 Thread Panu Matilainen
This fixes multiple dependency generator related regressions introduced beta2, by reverting the "fail build on dependency generator failure" change introduced there. We don't usually release new tarballs just because an issue was found in a beta, but since beta2 was released to address

[Rpm-maint] [rpm-software-management/rpm] Not ignoring generator failure shows strange issue (#1285)

2020-06-24 Thread soig
rpm's own fontconfig.prov is broken: http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/updates_testing/20200624045432.daviddavid.duvel.28729/log/plasma-desktop-5.19.2-1.mga8/build.0.20200624045513.log

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-24 Thread soig
Le mer. 24 juin 2020 à 08:38, Panu Matilainen a écrit : > On 6/24/20 9:30 AM, soig wrote: > > Also rpm's own fontconfig.prov is broken: > > >

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-24 Thread Panu Matilainen
On 6/23/20 5:16 PM, rpm-maint wrote: > Architecture is hardcoded in test and thus it fails on anything not x86_64 > :-( > > See > http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623135516.tv.duvel.30441/log/rpm-4.16.0-0.beta2.1.mga8/build.0.20200623135605.log > > --- -

[Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)

2020-06-24 Thread Panu Matilainen
This is simply too broken to patch up. Revert and back to drawing board. This reverts commit fb5299b2a49460216c38674b7398296d3a6d767c. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1286 -- Commit Summary -- * Revert

Re: [Rpm-maint] RPM 4.16.0 beta3 released!

2020-06-24 Thread Thierry Vignaud
Le mer. 24 juin 2020 à 10:59, Thierry Vignaud a écrit : > > This fixes multiple dependency generator related regressions introduced >> beta2, by reverting the "fail build on dependency generator failure" >> change introduced there. >> >> We don't usually release new tarballs just because an

[Rpm-maint] [rpm-software-management/rpm] Beta3 has a new broken test (235: rpmsigdig.at:144 rpmkeys -Kv 2 rpmkeys digest) (#1288)

2020-06-24 Thread soig
Beta2 was fine besides "rpmbuild.at:482 Dependency generation 3 build": http://pkgsubmit.mageia.org/uploads/done/cauldron/core/release/20200623145307.tv.duvel.658/rpm-4.16.0-0.beta2.1.mga8/ But beta3 introduces a new failure. See build*.log files & look for "Summary of the failures" at:

Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)

2020-06-24 Thread Igor Raits
I think we should keep it for master and revert fo 4.16 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Beta3 has a new broken test (235: rpmsigdig.at:144 rpmkeys -Kv 2 rpmkeys digest) (#1288)

2020-06-24 Thread Panu Matilainen
Closed #1288. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1288#event-3476574212___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Beta3 has a new broken test (235: rpmsigdig.at:144 rpmkeys -Kv 2 rpmkeys digest) (#1288)

2020-06-24 Thread Panu Matilainen
See http://lists.rpm.org/pipermail/rpm-announce/2020-June/80.html, you managed to grab the wrong tarball. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

2020-06-24 Thread soig
Ex: $ sudo mv /usr/lib/rpm/fileattrs/font.attr{,.no} $ LC_ALL=C rpmbuild --short-circuit --define "_topdir $PWD" -ba SPECS/feh.spec (…) Wrote: /home/tv/mga/pkgs/feh/RPMS/x86_64/feh-3.4.1-1.mga8.x86_64.rpm Wrote: /home/tv/mga/pkgs/feh/RPMS/x86_64/feh-debugsource-3.4.1-1.mga8.x86_64.rpm Wrote:

[Rpm-maint] [rpm-software-management/rpm] Fix depgen failure test to be architecture independent, doh (#1283)

2020-06-24 Thread Panu Matilainen
Nobody noticed the test-results being x86_64-specific due to buildroot path getting exposed, what a dumb cause... Override the default buildroot definition to make it arch-independent for these cases. Fixes: fb5299b2a49460216c38674b7398296d3a6d767c You can view, comment on, or merge this pull

Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)

2020-06-24 Thread Panu Matilainen
Reopening as the fix was reverted (it was just too broken to live) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)

2020-06-24 Thread Panu Matilainen
Reopened #1183. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#event-3476265711___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Architecture is hardcoded in new test and thus it fails on anything not x86_64 :-( (#1284)

2020-06-24 Thread soig
This one is still not fixed in 4.16.0 beta3 AFAIK… -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Architecture is hardcoded in new test and thus it fails on anything not x86_64 :-( (#1284)

2020-06-24 Thread Panu Matilainen
It is because the problematic test doesn't even exist anymore. But if you were really hasty, you might've downloaded the wrong tarball (when things go wrong, they really do...), check that you have one with sha256sum e6196fac6adcc13ca39699627a1cfc99c79c0beb9acca8c4d065b6cc9d50471c (as per

Re: [Rpm-maint] RPM 4.16.0 beta3 released!

2020-06-24 Thread Thierry Vignaud
Le mer. 24 juin 2020 à 11:02, Thierry Vignaud a écrit : > >> This fixes multiple dependency generator related regressions introduced >>> beta2, by reverting the "fail build on dependency generator failure" >>> change introduced there. >>> >>> We don't usually release new tarballs just because an

Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)

2020-06-24 Thread soig
For references, here's the fallout: https://github.com/rpm-software-management/rpm/issues/1285 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Not ignoring generator failure shows strange issue (#1285)

2020-06-24 Thread Panu Matilainen
Right, there are ... issues with the error code handling in rpmfcExec(). For now, it's best to just revert the "always fail" commit fb5299b2a49460216c38674b7398296d3a6d767c, it's just broken. Thanks for the report. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [Rpm-maint] [rpm-software-management/rpm] Release 4.16 beta3 (#1287)

2020-06-24 Thread Panu Matilainen
Merged #1287 into rpm-4.16.x. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1287#event-3476314408___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Not ignoring generator failure shows strange issue (#1285)

2020-06-24 Thread Panu Matilainen
Closed #1285. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1285#event-3476588512___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Not ignoring generator failure shows strange issue (#1285)

2020-06-24 Thread Panu Matilainen
Fixed in master and beta3, thanks again for reporting. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Architecture is hardcoded in new test and thus it fails on anything not x86_64 :-( (#1284)

2020-06-24 Thread soig
Architecture is hardcoded in test and thus it fails on anything not x86_64 :-( See http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623135516.tv.duvel.30441/log/rpm-4.16.0-0.beta2.1.mga8/build.0.20200623135605.log --- - 2020-06-23 13:59:13.826080861 + +++

Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Always fail build on dependency generator failures (#1183)" (#1286)

2020-06-24 Thread Panu Matilainen
Merged #1286 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1286#event-3476208995___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] Since beta2 introducing // mode, some files are not removable during %clean (#1289)

2020-06-24 Thread soig
Since beta2 introducing parallel mode, some files are not removable. See build*.log at http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623141813.tv.duvel.19852/log/rpm-4.16.0-0.beta2.1.mga8/ (…) Wrote:

Re: [Rpm-maint] [rpm-software-management/rpm] Architecture is hardcoded in new test and thus it fails on anything not x86_64 :-( (#1284)

2020-06-24 Thread Panu Matilainen
Closed #1284. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1284#event-3476583293___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] Architecture is hardcoded in new test and thus it fails on anything not x86_64 :-( (#1284)

2020-06-24 Thread Panu Matilainen
Maybe a slow mirror somewhere in there. Try again until you get the right version. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Beta3 has a new broken test (235: rpmsigdig.at:144 rpmkeys -Kv 2 rpmkeys digest) (#1288)

2020-06-24 Thread soig
Indeed we can close this one. https://github.com/rpm-software-management/rpm/issues/1289 is the only remaining issue with beta3 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-06-24 Thread Miro Hrončok
Is this good to be merged? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649113390___ Rpm-maint mailing list