Re: [Rpm-maint] [rpm-software-management/rpm] OpenMP & Lua fixes for configure.ac & INSTALL (#1325)
> The right thing to do with an incompatible OpenMP is to silently disable > OpenMP unless explicitly requested by --enable-openmp. Whether it's worth the > trouble is a separate question, writing configure.ac logic is ... yeah. No > cute kittens will be harmed if we set the default to "yes" instead of > implementing "auto". Nah, the logic shouldn't be much of a problem I think. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1325#issuecomment-684552367___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Misc fixes to clamp_mtime_to_source_date_epoch logic (#1353)
- simplify code / fix build failure with -fsanitize=address - dont call exit() from middle of librpmbuild You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1353 -- Commit Summary -- * Simplify logic to work around gcc (10.2.1) false positive warning * Dont call exit() from middle of librpmbuild for no good reason -- File Changes -- M build/files.c (8) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1353.patch https://github.com/rpm-software-management/rpm/pull/1353.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1353 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Lua rpm.error() function (#1218)
Also, `rpm.with("foo")` and `rpm.without("foo")` would be lovely.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1218#issuecomment-684631129___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Misc fixes to clamp_mtime_to_source_date_epoch logic (#1353)
Merged #1353 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1353#event-3713750258___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] OpenMP & Lua fixes for configure.ac & INSTALL (#1325)
@pmatilai Coming back to this PR after a while, I wonder if silently disabling OpenMP (if the required version isn't available) is really what we want. Wouldn't it be better to just fail and let the user disable OpenMP explicitly with `--disable-openmp` if he/she decides so? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1325#issuecomment-684476437___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] OpenMP & Lua fixes for configure.ac & INSTALL (#1325)
Optimally, ./configure without specific arguments is supposed to just figure out a configuration that will work on this system, and only error out if it cannot do that - or is explicitly requested to do incompatible things. The right thing to do is to silently disable OpenMP unless explicitly requested by --enable-openmp. Whether it's worth the trouble is a separate question, writing configure.ac logic is ... yeah. No cute kittens will be harmed if we set the default to "yes" instead of implementing "auto". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1325#issuecomment-684517393___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: elfdeps: Filter Python subdirectories (#1227)
I was thinking how to handle this today. I've only figured out *wrong*
solutions:
1. Modify `%__global_provides_exclude_from` to include
`%{_libdir}/python\d+\.\d+/.+\.so`.
This obviously has several problems: I cannot really do it from Python macros,
so the information would need to be kept in the general macros file. Also, if
we ever start providing something from those `.so` files, this would no longer
work. Also, it does not scale well.
2. Negate the entire ELF generator on the specific paths and provide alternate
ELF *requires* generator (without *provides*) for them. That seems like an
awful "copy paste stuff around" hack, ale not sure how to detect the need to do
this.
3. Extend RPM generators to be able to specify different
`%__NAME_provides_exclude_path`, `%__NAME_requires_exclude_path` instead of
general `%__NAME_exclude_path` and set `%__elf_provides_exclude_path` to
`%{_libdir}/python\d+\.\d+/.+\.so`. This should work but requires a lot of
work. Also obviously, if more things want to set
`%__elf_provides_exclude_path`, they would need to figure out how or have a
shared place to configure it.
4. Use `%{_rpmconfigdir}/elfdeps --provides
%{?__elf_provides_exclude_path:--exclude '%{__elf_provides_exclude_path}'}` in
`%__elf_provides` to simulate the above. However, the problem continues: If
both Perl and Python want to set `%__elf_provides_exclude_path` to "their"
path, they would need to have a shared place to configure it.
:/
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1227#issuecomment-684717757___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
Edit: commit message updated to talk about _minimize_writes instead of _minimize_io. And here I was wondering why I can't seem to reproduce it now... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347#issuecomment-684792915___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) (#1347)
@pmatilai pushed 1 commit. f22f7cc156822d6ffae77ad5101150f2514a5e9f Upgrade FA_TOUCH to FA_CREATE if the file went away (RhBug:1872141) -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1347/files/34f715884461dd91ee7f1430619d0da95e218b2a..f22f7cc156822d6ffae77ad5101150f2514a5e9f ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix some address-sanitizer findings (#1354)
- Fix possible read beyond buffer in rstrnlenhash() - Add missing terminator to copyTagsFromMainDebug array You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1354 -- Commit Summary -- * Add missing terminator to copyTagsFromMainDebug array * Fix possible read beyond buffer in rstrnlenhash() -- File Changes -- M build/files.c (1) M rpmio/rpmstrpool.c (3) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1354.patch https://github.com/rpm-software-management/rpm/pull/1354.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1354 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] OpenMP & Lua fixes for configure.ac & INSTALL (#1325)
@pmatilai Updated, please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1325#issuecomment-684947396___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] OpenMP & Lua fixes for configure.ac & INSTALL (#1325)
@dmnks pushed 2 commits. 82c5af992ed87bb6665de2d382166a563cc7b398 Check for OpenMP version at configure time c3af4801917c6cf3d5b5153a02f4cc09f98d6ca2 Bump Lua to 5.2 in configure script -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1325/files/b1ef1a1326f2e777ea43790a79ea5fa640fbb521..c3af4801917c6cf3d5b5153a02f4cc09f98d6ca2 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
