Re: [Rpm-maint] [rpm-software-management/rpm] Translations update from Weblate (#1514)
Merged #1514 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1514#event-4266568589___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: Print Provides-Extra entries for Python packa… (#1014)
Long time, no activity. Is this still being worked on? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1014#issuecomment-769850818___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add an option for zstd long distance matching compression (#1507)
The problem here is that it reserves a letter in a common namespace for a highly compressor-specific option. I've no objections to support compressor-specific things somehow, but we need to isolate them to a section of their own somehow, eg put them after an optional extra delimiter in the string, so we can have one code to parse the common parts and each compressor can have their own code for their specifics. Also, is this option specific to compression-time only, or is it relevant for decompression too? We have no means to separate the two ATM, and this is an issue with the T-options too, it shouldn't actually be stored in the rpmio string as it's not relevant for decompressing. The other thing here, although largely not actually introduced in this patch, is that the warning messages are a bit hysterical: they're awfully verbose, yet manage to say remarkably little: none of them say what the invalid value is, only that they'll be using something else. I'd suggest collapsing all those messages to a RPMLOG_DEBUG message which just says "invalid value %d for %s, using %d" essentially. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1507#issuecomment-769848838___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %postbuild section / Allow dynamic sub packages (#1239)
Closed #1239. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1239#event-4266561742___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] zstd: use thread pool (#1466)
I see your concerns and the pull request is hack a bit. On the other hand, `zstd` provides a nice thread pool functionality and package build really benefits from it. Right now, packages like Firefox also mostly compressed in one thread as compression of the biggest `.rpm` takes minutes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1466#issuecomment-769711886___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] zstd: use thread pool (#1466)
Been thinking about it on and off. It'd be one thing if it was just allocating cpu's out of N available, but we're married to OMP which doesn't want to be micro-managed from the outside, and then we have these independent libraries using their own threading schemes... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1466#issuecomment-769697431___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
OK, I'll fold the comments into the Markdown docs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1520#issuecomment-769807126___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
@encukou commented on this pull request.
> ## Check whether an option is enabled or disabled
-To define `BuildRequires` depending on the command-line switch, you can use the
-`%{with foo}` macro:
+To make parts of the spec file conditional depending on the command-line
+switch, you can use the `%{with foo}` macro or its counterpart,
+`%{wthout foo}`:
```suggestion
`%{without foo}`:
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1520#discussion_r566823894___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
@encukou pushed 1 commit. e0d581b9b7c47b1817700cc35ea99a21963a97df Add newly added file to Makefile.am -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1520/files/9218cbdeef7a9839d7a7b1033d5325c3e0444d34..e0d581b9b7c47b1817700cc35ea99a21963a97df ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
@encukou pushed 1 commit. 9218cbdeef7a9839d7a7b1033d5325c3e0444d34 Fix typos in docs -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1520/files/831de9ed06a9e33957074105693b04226d636b21..9218cbdeef7a9839d7a7b1033d5325c3e0444d34 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Arm detection improvements (#946)
This got stalled ages ago, and in the meanwhile the Arm stuff has been reverted, the last of those as late as 6e51ca5959d9e5159fdd75c0462c900d342f2cce. So we're back to square one and this PR is no longer applicable, if/when there's something more to do lets start afresh in a new ticket/PR. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/946#issuecomment-769813675___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix Arm detection improvements (#946)
Closed #946. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/946#event-4266226465___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix support of MIPS r6 (#916)
This seems to have stalled without coming to much any conclusion. "Make it like Debian" is not a fix when it breaks compatibility with existing systems and packages. Sorry but I have no choice but to close this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/916#issuecomment-769819622___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix support of MIPS r6 (#916)
Closed #916. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/916#event-4266279718___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add popt to our pkgconfig dependencies (#1524)
Fixes: #939 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1524 -- Commit Summary -- * Add popt to our pkgconfig dependencies -- File Changes -- M rpm.pc.in (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1524.patch https://github.com/rpm-software-management/rpm/pull/1524.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1524 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add popt to Requires. (#940)
Okay, we got a brand new popt out there for a while now, might as well get this over with. It's not like anybody is really dependent on popt older than 1.16. Since there's now a conflict, and the delay is really our fault, handling this by myself via #1524. Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/940#issuecomment-769792921___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add popt to Requires. (#940)
Closed #940. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/940#event-4266056164___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add popt to our pkgconfig dependencies (#1524)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1524#pullrequestreview-579236161___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
@pmatilai Squash your fixup commit into the other one, and I think it's good to go. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523#issuecomment-769794707___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
@Conan-Kudo approved this pull request. You beat me to it! BDB has served us well since the beginning, now it's time to say farewell... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523#pullrequestreview-579237724___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add popt to our pkgconfig dependencies (#1524)
Merged #1524 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1524#event-4266073147___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.0: missing pkgconfig dependencies (#939)
Closed #939 via #1524. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/939#event-4266073163___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
Oh BTW, https://github.com/rpm-software-management/rpm/blob/master/doc/manual/conditionalbuilds.md would be a better place for bulk of the documentation, the fact that there's verbose documentation with examples on pre-existing %bcond in macros file is only a historical artifact from not having a better place for it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1520#issuecomment-769799661___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
With the way this is going, I suspect there's one or two more BDB references lurking about somewhere :sweat_smile: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523#issuecomment-769802802___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Allow to keep a minimum number of changelog entries (#931)
Closed #931. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/931#event-4266145879___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Allow to keep a minimum number of changelog entries (#931)
With #1328 merged I am not sure if we really want to add another feature to control changelog behaviour right now. Closing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/931#issuecomment-769803916___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
@pmatilai pushed 1 commit. a2be4a808ad6b3b5de7441ec7c878d7cad00c0fc Remove support for Berkeley Database backend -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523/files/1535cb0f742fce8971a371bbc5927a55a92fff4b..a2be4a808ad6b3b5de7441ec7c878d7cad00c0fc ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
> removing BDB itself now is a simple act ...or it *should* be. I had it all done locally but must've messed up something with git. Sigh. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523#issuecomment-769763016___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Possible deadlock when macro tracing and debug is turned on (#1418)
Closed #1418 via #1515. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1418#event-4266021478___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: useful lua errors (#545)
Closed #545 via f67d239ccd709d44f5258a5ead01502a0b437d48. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/545#event-4266021577___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improve macro traceback behavior (#1515)
Merged #1515 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1515#event-4266021470___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
We all want to get rid of BDB, but in order to do that we have to pick a new default. Sqlite has a proven track record over multiple decades in terms of compatibility and longevity, and is the nobody ever got fired for... choice in this space really. Its also developer friendly as the database is easy to inspect and a *lot* of people are familiar with it and its API. Ndb has its own benefits such as independence from external libraries for those who care about that, but the above is what matter more to me: even if the entire rpm community gets run over by a truck, there will still be plenty of people deeply familiar with sqlite around. With the default changed, removing BDB itself now is a simple act. I wont be shedding a single tear over it, but it certainly is an end of an era. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1523 -- Commit Summary -- * Make sqlite the default database backend * Remove support for Berkeley Database backend -- File Changes -- D db3/configure (34) D lib/backend/db3.c (1389) M macros.in (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1523.patch https://github.com/rpm-software-management/rpm/pull/1523.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
@pmatilai pushed 1 commit. 1535cb0f742fce8971a371bbc5927a55a92fff4b Remove support for Berkeley Database backend -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523/files/a5f51a334682b9c15b632fda53500c872595dd44..1535cb0f742fce8971a371bbc5927a55a92fff4b ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
@pmatilai pushed 1 commit. 85bd36b3259c180d68c98b8e0e9abe7dcdcd25fe Remove support for Berkeley Database backend -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523/files/a2be4a808ad6b3b5de7441ec7c878d7cad00c0fc..85bd36b3259c180d68c98b8e0e9abe7dcdcd25fe ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
@pmatilai pushed 1 commit. 3767ec34a7dda9fb92a51307128539574d3e1c8e Remove support for Berkeley Database backend -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523/files/85bd36b3259c180d68c98b8e0e9abe7dcdcd25fe..3767ec34a7dda9fb92a51307128539574d3e1c8e ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
The added tests are failing probably because the added spec is missing from tests/Makefile.am. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1520#issuecomment-769774130___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
@hroncok commented on this pull request. > -To use this feature in a spec file, add this to the beginning of the file: +To enable a build conditional in a spec file, use the `%bcond` macro at the +beginning of the file, specifying the name of the conditional and its default +value: + +``` +# To build with "gnutls" by default: +%bcond gnutls 1 +# To build without "gnutls" default: ```suggestion # To build without "gnutls" by default: ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1520#pullrequestreview-579210256___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
In general, I like this feature, and once it lands in RPM, I'll probably port this to debbuild. It makes a ton more sense than the existing stuff. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1520#issuecomment-769777511___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
@lubomir commented on this pull request.
> ## Check whether an option is enabled or disabled
-To define `BuildRequires` depending on the command-line switch, you can use the
-`%{with foo}` macro:
+To make parts of the spec file conditional depending on the command-line
+switch, you can use the `%{with foo}` macro or its counterpart,
+`%{wthout foo}`:
Typo: wthout → without
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1520#pullrequestreview-579214502___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Default to sqlite backend and remove support for BDB (#1523)
@pmatilai pushed 1 commit. 7ba9793302b033821fab6d3f01e02eece49c7b30 fixup! Remove support for Berkeley Database backend -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1523/files/3767ec34a7dda9fb92a51307128539574d3e1c8e..7ba9793302b033821fab6d3f01e02eece49c7b30 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Also check DT_RUNPATH when looking for rpath issues (#1487)
Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1487#issuecomment-769827089___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Also check DT_RUNPATH when looking for rpath issues (#1487)
Merged #1487 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1487#event-4266343082___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
All info from the comments in the macro file is in the docs, except that:
> When checking conditions: never use `without_foo`, `_with_foo` nor
> `_without_foo`, only `with_foo`.
contradics with the [Pass it to
%configure](https://github.com/rpm-software-management/rpm/blob/master/doc/manual/conditionalbuilds.md#pass-it-to-configure)
section, which uses `_with_*`.
Inded, this will not work correctly when used in combination with `%bcond` and
`%bcond_without`, because it doesn't honor the "default".
So, I'd like to remove that section entirely. The section above already
explains what to do – some variation of:
%{?with_gnutls:--with static} \
%{!?with_openssl:--without openssl}
... which is more verbose, but works with %bcond` & `%bcond_without`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1520#issuecomment-769827340___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Also check DT_RUNPATH when looking for rpath issues (#1487)
No comments and no objections from anybody, guess this is good to go. The rpath-check isn't wired to anything in rpm so it's a low risk thing anyhow. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1487#issuecomment-769826983___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)
> So, I'd like to remove that section entirely. Feel free. I doubt anybody has paid this close attention to the docs in decades... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1520#issuecomment-769829470___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpmio: Fix lzopen_internal mode parsing when 'Tn' is used (#1478)
Merged #1478 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1478#event-4266370988___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpmio: Fix lzopen_internal mode parsing when 'Tn' is used (#1478)
Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1478#issuecomment-769830494___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
