Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Demi Marie Obenour
> @DemiMarie thank you! What version of lua? I had 5.2.0 and it told me it > wasn't recent enough. Should I try a more recent one (which one?) You need 5.4.0, IIRC. 5.3.0 might work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [Rpm-maint] [rpm-software-management/rpm] Fall back to /tmp if TMPDIR is bogus (#1567)

2021-03-17 Thread Panu Matilainen
Yup, this sounds like papering over some issue in either local setup or something else, and I don't think we should do that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Phasing out obsolete crypto in rpm (#1292)

2021-03-17 Thread Panu Matilainen
I'm not sure what you mean by that. At least with the openssl-backend, whatever system policy is set is already honored - including FIPS, which in fact does cause v3 (and pre 4.14 built packages too) to fail to install. People are running into this quite a bit in RHEL 8. -- You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] Fall back to /tmp if TMPDIR is bogus (#1567)

2021-03-17 Thread Michal Domonkos
Containers aside, I'm still now sure why the `TMPDIR` variable would be set to anything other than a directory? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Panu Matilainen
No no, Lua 5.2 is the oldest supported version, as it says in INSTALL and configure.ac. On some distros (eg Debian and derivates) lua.pc is versioned and our configure.ac wont find it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

[Rpm-maint] [rpm-software-management/rpm] Update credits for a change (#1582)

2021-03-17 Thread Panu Matilainen
Lotsa new names, many from translations but otherwise too. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1582 -- Commit Summary -- * Update credits for a change -- File Changes -- M .mailmap (2) M CREDITS (45)

Re: [Rpm-maint] [rpm-software-management/rpm] Translations update from Weblate (#1569)

2021-03-17 Thread Weblate (bot)
@weblate pushed 2 commits. ba9951856153d5e707e24986c66255633d852a4c Translated using Weblate (Finnish) fcae845b3b2f38a78b729e5b3c8d64fe745fa6a4 Translated using Weblate (Korean) -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)

2021-03-17 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -24,10 +53,12 @@ If you want to change whether or not an option is enabled > by default, only change `%bcond_with` to `%bcond_without` or vice versa. In such a case, the remainder of the spec file can be left unchanged. + Seems like stray

Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Vanessasaurus
Could it be an issue with not finding lua.pc? I was looking at this post, and that seems to be important: https://stackoverflow.com/questions/47458678/why-lua-5-3-can-not-find-the-path-of-include-missing-lua-include-dir I've been trying all morning to get this to work with various variables

Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)

2021-03-17 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -76,47 +76,25 @@ %defined() %{expand:%%{?%{1}:1}%%{!?%{1}:0}} %undefined() %{expand:%%{?%{1}:0}%%{!?%{1}:1}} -# Shorthand for %{defined with_...} +# Handle conditional builds. +# (see 'conditionalbuilds' in the manual) +# +# Internally,

Re: [Rpm-maint] [rpm-software-management/rpm] Enable hardening flags where available (#1501)

2021-03-17 Thread Demi Marie Obenour
@DemiMarie pushed 1 commit. a1b3a4582307786ed9e737d7945d1d6fe2a98c50 Enable hardening flags where available -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)

2021-03-17 Thread Panu Matilainen
Sorry, this has gotten a bit forgotten in middle of other action. The idea is nice, certainly. Just some minor nitpicks, plus rebase and squash the "doc nit" commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Check for overflow in computing blob->rdl (#1583)

2021-03-17 Thread Demi Marie Obenour
By using GCC’s overflow-checking builtins, we avoid needing to reason about overflow manually, which is error-prone. Having GCC do the arithmetic in infinite signed precision is much nicer. This was assigned CVE-2021-20249, which is why I am making this PR. You can view, comment on, or merge

Re: [Rpm-maint] [rpm-software-management/rpm] Add %bcond macro for defining build conditionals (#1520)

2021-03-17 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -990,3 +990,25 @@ xxx error: bad ]) AT_CLEANUP + +AT_SETUP([bcond macro]) +AT_KEYWORDS([macros]) +AT_CHECK([ Move this test into the other one in rpmbuild.at - the macro tests are more about testing the macro language and its builtins. There

Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Vanessasaurus
Is there a patch we can use [maybe here](http://lua-users.org/wiki/LuaPowerPatches) to patch our lua install to have this file? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Vanessasaurus
Ok, I found a patch to generate lua.pc, added to PKG_CONFIG_PATH, and it starts the build, but then errors out: ``` ==> Error: ProcessError: Command exited with status 2: 'make' '-j8' 23 errors found in build log: 1023mv -f $depbase.Tpo $depbase.Po 1024libtool: link:

Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Vanessasaurus
okay I think I'm beyond that error - now I have: ``` ==> Error: ProcessError: Command exited with status 2: 'make' '-j8' 16 errors found in build log: 1024mv -f .deps/libcliutils_la-cliutils.Tpo .deps/libcliutils_la-cliutils.Plo 1025depbase=`echo tools/hashtab.o | sed

Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Vanessasaurus
They were removed here https://github.com/rpm-software-management/rpm/commit/376fef14a61a9748ce004888fe19445719a5d2d5#diff-c9a9cfdfa5b80aab803ef1466d35d0b6ef4d7435b2663cd789e50493ace95857. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Vanessasaurus
These functions have been deprecated but the debugedit library is not updated? https://github.com/rpm-software-management/rpm/blob/635edd95230e17e8ada5793719d7e385e729df30/rpmio/rpmlua.h -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [Rpm-maint] [rpm-software-management/rpm] How to compile debugedit? (#1581)

2021-03-17 Thread Vanessasaurus
Okay so I went back and used this older version, and installed binutils to get the first set of missing symbols, and now I have this: ``` >> 1071 /home/vanessa/Desktop/Code/spack-dev/opt/spack/linux-ubuntu20.04-skylake/gcc-9.3.0/binutils-2.36.1-rwurk7323mkmtj2gcqzb2frviciev3eu/bin/