Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Michal Domonkos
> All these typos looks like copy-slopping under heavy vodka influence, only I > don't have the excuse of chemical substances here. An embarrassing slip of > self-review from me, thanks for bothering to fine-comb it all. Actually, in this case, one would almost doubt the patch was written by a

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -469,6 +469,17 @@ static rpmpsm rpmpsmNew(rpmts ts, rpmte te, pkgGoal goal) psm->scriptArg = npkgs_installed + 1; psm->countCorrection = 0; break; + case PKG_PREUNTRANS: + if

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
@pmatilai pushed 1 commit. addcde79d4493663abc63b9f7c62832faf8d7ddf Add support for %preuntrans and %postuntrans scriptlets -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177/files/3ed777e421773b7e4f472c5db2aab102ee6593c4..addcde79d4493663abc63b9f7c62832faf8d7ddf

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
And now with some earlier fixes + additions added back for the fourth time or something. This PR really hates me :rofl: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177#issuecomment-1253426015 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -469,6 +469,17 @@ static rpmpsm rpmpsmNew(rpmts ts, rpmte te, pkgGoal goal) psm->scriptArg = npkgs_installed + 1; psm->countCorrection = 0; break; + case PKG_PREUNTRANS: + if

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Michal Domonkos
> Should be fixed now. Famous last words roll_eyes Yet you apparently only pushed to your WIP branch, not the public one here :sweat_smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177#issuecomment-1253346972 You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
@pmatilai pushed 1 commit. 3ed777e421773b7e4f472c5db2aab102ee6593c4 Add support for %preuntrans and %postuntrans scriptlets -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177/files/48f04d6638096e9eafc537d314991ba44fadff08..3ed777e421773b7e4f472c5db2aab102ee6593c4

[Rpm-maint] RPM 4.18.0 and POPT 1.19 released!

2022-09-21 Thread Panu Matilainen
I seem to be short of clever/funny remarks for the preamble this time around, so maybe I'll just pass. In what must be the driest news of the day, we're releasing RPM 4.18.0 and POPT 1.19. Despite the timing, these releases aren't technically related, and RPM continues to work with older

Re: [Rpm-maint] [rpm-software-management/rpm] Give error message for failed PGP key import (PR #2097)

2022-09-21 Thread Florian Festi
The discussion here is beside the point of the PR. This is in large parts my fault as the original patch also was beside the point. As it turns out this is unrelated to v4 OpenPGP signatures and their use of SHA-1. The current patch only returns the error of not supported older SHA-1 based

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
All these typos looks like copy-slopping under heavy vodka influence, only I don't have the excuse of chemical substances here. An embarrassing slip of self-review from me, thanks for bothering to fine-comb it all. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -37,7 +37,9 @@ enum rpmtransFlags_e { RPMTRANS_FLAG_NOCONTEXTS = (1 << 8),/*!< from --nocontexts */ RPMTRANS_FLAG_NOCAPS = (1 << 9),/*!< from --nocaps */ RPMTRANS_FLAG_NODB = (1 << 10),/*!< from --nodb */ -

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -469,6 +469,17 @@ static rpmpsm rpmpsmNew(rpmts ts, rpmte te, pkgGoal goal) psm->scriptArg = npkgs_installed + 1; psm->countCorrection = 0; break; + case PKG_PREUNTRANS: + if

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
Should be fixed now. Famous last words :roll_eyes: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177#issuecomment-1253259301 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -37,7 +37,9 @@ enum rpmtransFlags_e { RPMTRANS_FLAG_NOCONTEXTS = (1 << 8),/*!< from --nocontexts */ RPMTRANS_FLAG_NOCAPS = (1 << 9),/*!< from --nocaps */ RPMTRANS_FLAG_NODB = (1 << 10),/*!< from --nodb */ -

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
@pmatilai pushed 2 commits. 5a650b22066e3ec4325581bc18bb315e6bf79d9d Clarify countCorrection usage in psm a2aa0d290c4115991df517eaf1a66f2fff32002f Add support for %preuntrans and %postuntrans scriptlets -- View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Michal Domonkos
> When a job starts to go wrong, it often does so all the way to the end. Like > a trainwreck. laughing Indeed. We've all been there and done that :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177#issuecomment-1253364891 You

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
:facepalm: :facepalm: :facepalm: When a job starts to go wrong, it often does so all the way to the end. Like a trainwreck. :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177#issuecomment-1253352402 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-21 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -37,7 +37,9 @@ enum rpmtransFlags_e { RPMTRANS_FLAG_NOCONTEXTS = (1 << 8),/*!< from --nocontexts */ RPMTRANS_FLAG_NOCAPS = (1 << 9),/*!< from --nocaps */ RPMTRANS_FLAG_NODB = (1 << 10),/*!< from --nodb

[Rpm-maint] [rpm-software-management/rpm] RPMv6 proposal: treat IMA and fsverity signatures as part of the package (Issue #2200)

2022-09-21 Thread Demi Marie Obenour
In RPMv4, IMA and fsverity signatures are not considered part of the package, but of the signature. Therefore, they are included in the signature header (not the main header), which leads to various problems and increases attack surface. For RPMv6, I propose that they be considered part of

Re: [Rpm-maint] [rpm-software-management/rpm] Bump libtool current before 4.18 release (Issue #2113)

2022-09-21 Thread Panu Matilainen
And then I went ahead and forgot it in final too :facepalm: This isn't the best of months for me, really... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2113#issuecomment-1253556302 You are receiving this because you are subscribed

[Rpm-maint] [rpm-software-management/rpm] Unify spec terminology in documentation (Issue #2199)

2022-09-21 Thread Panu Matilainen
Our documentation including the reference manual uses all manner of mixed up terminology. We should clarify and unify the terminology used, eg talk about directives rather than tags, and sections for the %-stuff. -- Reply to this email directly or view it on GitHub:

[Rpm-maint] RPM 4.18.0: Build errors

2022-09-21 Thread Scott Andrews
%prep %setup -q -n %{name}-%{version}-release sed 's:/bin/sh:/usr/bin/sh:' -i macros.in sh autogen.sh --noconfigure %build _options=( --prefix=/usr --program-prefix= --sysconfdir=/etc --sharedstatedir=/var/lib --localstatedir=/var --with-crypto=libgcrypt --with-gnu-ld --with-archive --with-cap