[Rpm-maint] [PATCH] Cleanup: removing unnecessary repeated code.

2009-03-13 Thread Rakesh Pandit
Patch: http://rakesh.fedorapeople.org/rpm/0005--Cleanup-removing-unnecessary-repeated-code.patch -- rakesh From 4c5f5b80beb924de58a2481e6529f8272bbe35a1 Mon Sep 17 00:00:00 2001 From: Rakesh Pandit rak...@fedoraproject.org Date: Fri, 13 Mar 2009 12:50:35 +0530 Subject: [PATCH] - Cleanup:

Re: [Rpm-maint] [PATCH] Move header reading part from rpminstall to tryReadHeader function.

2009-03-13 Thread Panu Matilainen
On Wed, 11 Mar 2009, Rakesh Pandit wrote: Is tryReadHeader a good name ? - Move header reading part from rpminstall to tryReadHeader function. Patch: http://rakesh.fedorapeople.org/rpm/0001--Move-header-reading-part-from-rpminstall-to-tryRea.patch *Patch also involves removal of -#include

Re: [Rpm-maint] [PATCH] Moved code to check possibility of freshen operation to checkFreshenStatus.

2009-03-13 Thread Panu Matilainen
On Wed, 11 Mar 2009, Rakesh Pandit wrote: Is checkFreshenStatus apt enough ? - Moved code to check possibility of freshen operation to checkFreshenStatus. Patch: http://rakesh.fedorapeople.org/rpm/0002--Moved-code-to-check-possibility-of-freshen-operati.patch Looks fine to me, just an

Re: [Rpm-maint] [PATCH] Cleanup: Move similar repeating code in rpmcliArgIter to rpmcliArgIterHelper.

2009-03-13 Thread Panu Matilainen
On Fri, 13 Mar 2009, Rakesh Pandit wrote: 2009/3/13 Rakesh Pandit rakesh.pan...@gmail.com: Just that I had been looking at usage of rpmgi in query.c did some cleanup. Sorry posted the old one ... latest one: Patch:

Re: [Rpm-maint] [PATCH] Removed unnecessary rpmdbFreeIterator call ....

2009-03-13 Thread Panu Matilainen
On Fri, 13 Mar 2009, Rakesh Pandit wrote: I will factoring rpmgi.c specially rpmgiNext a bit and ripping not used parts. Aim being to ease it enough so that progress about Conflict Updating thingy, Callback methods , manifest fixs can be made at later stage. - Removed unnecessary

[Rpm-maint] upgrade process

2009-03-13 Thread Tom Brown
When an rpm is upgraded is the existing package removed before or after the post section of the package that is replacing it? I ask because in my %post of a package a symlink gets created. This symlink is also removed if the package is removed so in the %postun If i install the rpm the

Re: [Rpm-maint] upgrade process

2009-03-13 Thread Michael Schroeder
On Fri, Mar 13, 2009 at 08:06:41AM -0500, Mark Hatle wrote: New packages files installed Old package files removed (ones not already overwritten by the install) postun run post run Not really. The order is: prein new install files from new postin new preun old delete

[Rpm-maint] bug in /usr/lib/rpm/redhat/macros file?

2009-03-13 Thread Ritesh Sood
Please take a look at the following snippet from RHEL5's /usr/lib/rpm/redhat/macros file: #= = = = = = # configure macros. note that most of these are inherited # from the defaults. # %_prefix/usr

[Rpm-maint] Fwd: Looking for documentation on rpm macros and some suggestions

2009-03-13 Thread Ritesh Sood
I had sent the following mail to rpm-l...@lists.rpm.org, but haven't received a response. Perhaps rpm-maint is a more appropriate forum for my queries. Hi all, I'm not a regular rpm builder, but have the need to build some at the moment. I've been successful in building the few rpm's