[Rpm-maint] [PATCH] debugedit: skip_dir_prefix should check for dir separator.

2017-06-28 Thread Mark Wielaard
To count as a real directory prefix the string matched should either be equal to the given prefix or start with the prefix plus '/'. skip_dir_prefix is always used with base_dir or dest_dir which don't end with a slash themselves. This really only is an issue if a package would put a directory

[Rpm-maint] [PATCH] find-debuginfo.sh: Use 'return', not 'continue', to break out do_file().

2017-06-28 Thread Mark Wielaard
commit 038bfe "Split directory traversal and debuginfo extraction" put the core of a while loop into its own function 'do_file()'. That means that instead of using 'continue' to break out early it now needs to use 'return'. Otherwise the script will give errors like: continue: only meaningful

[Rpm-maint] [PATCH] find-debuginfo.sh: Filter out all like fake file names.

2017-06-28 Thread Mark Wielaard
There is no official way to mark an instruction range as being not part of some actual source code, but as part of a compiler built-in construct in DWARF. So different compilers have come up with fake source file names like or <__thread_local_inner macros>. We already filtered out the strings ""

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Pre-validate (all) header data for semantic consistency (#242)

2017-06-28 Thread Jeff Johnson
As long as --nosignature and --nodigest are commonly used everywhere -- including in depsolvers -- you can setup an internal table to associate the data type with the tag and never access the field in the header. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [Rpm-maint] [rpm-software-management/rpm] Add %mutable and %noupdate update policies (#152) (#200)

2017-06-28 Thread Panu Matilainen
This has been put on hold, closing for now at least. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add %mutable and %noupdate update policies (#152) (#200)

2017-06-28 Thread Panu Matilainen
Closed #200. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/200#event-1142057457___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] out of bounds heap read in rpmstrPoolId / rstrlenhash (#135)

2017-06-28 Thread Panu Matilainen
Closed #135. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/135#event-1142044203___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] out of bounds heap read in rpmstrPoolId / rstrlenhash (#135)

2017-06-28 Thread Panu Matilainen
The immediate crasher was already addressed, the underlying larger issue of tag validation will be tracked in #242 from here on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] invalid memory read in function providePackageNVR / doFind (#136)

2017-06-28 Thread Panu Matilainen
The immediate crasher was already addressed, the underlying larger issue of tag validation will be tracked in #242 from here on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] invalid memory read in function providePackageNVR / doFind (#136)

2017-06-28 Thread Panu Matilainen
Closed #136. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/136#event-1142043981___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] invalid memory read in rstreqn / rpmdsNewPool (#137)

2017-06-28 Thread Panu Matilainen
Closed #137. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/137#event-1142043836___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] invalid memory read in rstreqn / rpmdsNewPool (#137)

2017-06-28 Thread Panu Matilainen
The immediate crasher was already addressed, the underlying larger issue of tag validation will be tracked in #242 from here on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] heap out of bounds read in rpmfilesFDepends() (#139)

2017-06-28 Thread Panu Matilainen
The immediate crasher was already addressed, the underlying larger issue of tag validation will be tracked in #242 from here on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] invalid read in dataLength / grabData (header.c) (#138)

2017-06-28 Thread Panu Matilainen
The immediate crasher was already addressed, the underlying larger issue of tag validation will be tracked in #242 from here on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] invalid read in dataLength / grabData (header.c) (#138)

2017-06-28 Thread Panu Matilainen
Closed #138. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/138#event-1142043641___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] RFE: Pre-validate (all) header data for semantic consistency (#242)

2017-06-28 Thread Panu Matilainen
The common theme in tickets #135, #136, #137, #138 and #139 is that the datatype of a valid tag is changed to something incompatible, such as an integer tag is changed to string, which then causes crash-and-burn in various places, many of which are not able to return an error even if they

Re: [Rpm-maint] [rpm-software-management/rpm] Adding/moving RPMTAG_PUBKEYS to the signature header (#182)

2017-06-28 Thread Jeff Johnson
The suggestion of moving RPMTAG_PUBKEYS was directed to rpm.org (and you) as a better design for *.rpm packages, particularly if pursuing multiple signatures on multiple plaintext within an RPM package. *shrug* -- You are receiving this because you are subscribed to this thread. Reply to

Re: [Rpm-maint] [rpm-software-management/rpm] stack buffer overflow in glob/rpmGlob - rpm 4.13.0.1 (#156)

2017-06-28 Thread Panu Matilainen
Closing due to lack of activity and missing information. Feel free to reopen when providing the requested information about reproducing details. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Adding/moving RPMTAG_PUBKEYS to the signature header (#182)

2017-06-28 Thread Panu Matilainen
You're of course free to do whatever you wish in RPM5 but this is an issue tracker of rpm.org, please limit usage to that purpose. Closing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Adding/moving RPMTAG_PUBKEYS to the signature header (#182)

2017-06-28 Thread Panu Matilainen
Closed #182. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/182#event-1141967870___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Q: RPMTAG_PAYLOADDIGEST: compute before or after compression? (#184)

2017-06-28 Thread Panu Matilainen
This is an issue tracker, not a support forum. Closing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Q: RPMTAG_PAYLOADDIGEST: compute before or after compression? (#184)

2017-06-28 Thread Panu Matilainen
Closed #184. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/184#event-1141964299___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Make rpm fail to install unverified packages (#231)

2017-06-28 Thread Panu Matilainen
This is an issue tracker and there's no actual issue here, just a question. See http://rpm.org/community.html for the appropriate forums for questions and discussion. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Make rpm fail to install unverified packages (#231)

2017-06-28 Thread Panu Matilainen
Closed #231. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/231#event-1141961457___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Check signatures in the code (#240)

2017-06-28 Thread Panu Matilainen
Sorry but this is an issue tracker, not a support forum. See http://rpm.org/community.html -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Check signatures in the code (#240)

2017-06-28 Thread Panu Matilainen
Closed #240. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/240#event-1141957245___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for new package declarations in Perl 5.12+ (#237)

2017-06-28 Thread Panu Matilainen
Excellent, thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/237#issuecomment-311594948___ Rpm-maint mailing list

Re: [Rpm-maint] [PATCH] find-debuginfo.sh: Don't create dwz multi file if there is only one .debug.

2017-06-28 Thread Panu Matilainen
On 06/26/2017 06:38 PM, Mark Wielaard wrote: dwz -m multi only works when there are multiple .debug input files. With just one .debug file it doesn't really make sense to extract the shared debug info into a separate file and dwz will complain: dwz: Too few files for multifile optimization.

Re: [Rpm-maint] [PATCH] Update find-debuginfo.sh options and macros documentation.

2017-06-28 Thread Panu Matilainen
On 06/26/2017 02:35 PM, Mark Wielaard wrote: This adds some missing documentation for rpm macros and find-debuginfo.sh options that were recently added (or renamed). -j N, --build-id-seed SEED, --unique-debug-suffix SUFFIX and --unique-debug-src-base BASE. Signed-off-by: Mark Wielaard

Re: [Rpm-maint] [rpm-software-management/rpm] Python macro improvements (#221)

2017-06-28 Thread Panu Matilainen
Sorry, was on vacation for a week (and will be again for all of July) The patch as such looks fine to me, no problem with that. What I'm wondering about is that this of course loses is the ability to easily override python version both at run- and buildtime. The latter isn't that relevant

Re: [Rpm-maint] [rpm-software-management/rpm] Make source package detection less error prone. (#218)

2017-06-28 Thread Panu Matilainen
Sorry I'd managed to forget this whole thing between vacations and other stuff. Thanks for the patches! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Make source package detection less error prone. (#218)

2017-06-28 Thread Panu Matilainen
Merged #218. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/218#event-1141832657___ Rpm-maint mailing list