Re: [Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (#295)

@Conan-Kudo pushed 1 commit. f86b7c2 ci: Add libzstd-devel to CI Dockerfile -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Add zstd compressed payload support to RPM (#295)

This PR adds support for zstd compressed payloads for RPMs. This addresses the issues with duplicate m4 files with #283 and adds proper attribution. Obsoletes #283 Closes #256 You can view, comment on, or merge this pull request online at:

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

@Conan-Kudo : if using RPM_CHECK_LIB w internal, its a bit trickier than just adding a checkout. So you likely want to remove "internal" as the 1st thing to try in "[yes,internal:external:none]" FYI, removing "none" as in (yes,external) will fail to configure if not found (i.e. mandatory) And

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

@ignatenkobrain : I don't send PR's because I don't have the time/energy/resources to wait months for review, updating the PR with zero feedback other than "Why don't you send PR's?". That's why. -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (#225)

Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/225#pullrequestreview-53110650___

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

brp-clean-files is convenient as it'll simply make sure that files which surely has no place in builldroot are removed and accidental packaging of is prevented. The script is extremely simple and the most trivial one in this PR, so I fail to see your concern about it might break something. --

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

No idea what you mean by prefering users explicitly doing the right thing.. Trying to interpret it, it seems to contradict the purpose of these scripts in general, avoiding users having to explicitly take care of things that can be safely automized and handled automatically outside of spec

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

For the package exceptions requiring the libtool .la files, you have a disabler macro. That's the whole point of the disabler macros in general, while enabling the scripts are desired in most cases, thus enabled by default, there always might be exceptions where not desired and for those you

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

proyvind commented on this pull request. > @@ -0,0 +1,17 @@ +#!/bin/sh +# Fix .desktop files to be compliant with XDG specification Why? .desktop files issuee corrected by this script is quite widespread and goes often unnoticed. Trivial to automatically fix with script, tedious to manually

Re: [Rpm-maint] [rpm-software-management/rpm] add support for %{shrink:}, derived from rpm5.org (#234)

why remove attribution from commit message? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/234#issuecomment-318933780___

Re: [Rpm-maint] [rpm-software-management/rpm] digest_openssl: return failure if setting key failed (#293)

Merged #293. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/293#event-1184919353___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] fix couple of memory leaks in rpmbuild (#292)

Merged #292. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/292#event-1184918766___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

@n3npq @hyc @ignatenkobrain This should be fully rebased now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

@Conan-Kudo pushed 1 commit. c2cad9d Remove MDB_FIXEDMAP flag to prevent portability issues -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Macro arguments do not support quoting (#222)

Closed #222. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/222#event-1184895706___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Macro arguments do not support quoting (#222)

``` [brain@ignatenko-w541 kojilogs]$ ~/Projects/upstream/rpm/rpm --define "%foo() 1:%1 2:%2" --eval "%foo %nil bar" 1:bar 2:%2 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

@ffesti should we close this issue? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/157#issuecomment-318926262___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

ignatenkobrain requested changes on this pull request. and also, use --author when doing commit instead of stealing work done by others. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

ignatenkobrain commented on this pull request. > +dnl ## NAME: +dnl ##AC_MSG_VERBOSE -- Display a message under --verbose +dnl ## +dnl ## USAGE: +dnl ##AC_MSG_VERBOSE() +dnl ## + +AC_DEFUN([AC_MSG_VERBOSE], [ +if test ".$verbose" = .yes; then +_AS_ECHO([$1]) +fi +]) +

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

ignatenkobrain commented on this pull request. > + +dnl ## +dnl ## NAME: +dnl ##AC_MSG_TITLE -- Display a configuration title +dnl ## +dnl ## USAGE: +dnl ##AC_MSG_TITLE(, ) +dnl ## + +AC_DEFUN([AC_MSG_TITLE],[ +_AS_ECHO([Configuring $1, Version $2]) +]) + +dnl ## +dnl ## NAME:

Re: [Rpm-maint] [rpm-software-management/rpm] Zstd compression support (from jbj) (#283)

ignatenkobrain commented on this pull request. > @@ -0,0 +1,537 @@ +dnl ## +dnl ## acinclude.m4 -- manually provided local Autoconf macros +dnl ## + +dnl ## +dnl ## NAME: +dnl ##AC_MSG_TITLE -- Display a configuration title such things should go to autoconf (or autoconf-archive). --

Re: [Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (#225)

ignatenkobrain approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/225#pullrequestreview-53104988___

Re: [Rpm-maint] [rpm-software-management/rpm] add support for %{shrink:}, derived from rpm5.org (#234)

ignatenkobrain requested changes on this pull request. @proyvind please remove `derived from rpm5.org` from commit message and rebase against current master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation via thread pools (#226)

@kanavin any news here? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/226#issuecomment-318925604___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] add RPM_CHECK_LIB m4 macro (from jbj) (#282)

without real usage, just adding macro is useless. closing in favor of #283 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

See also comments at issue #281 about removing MDB_FIXEDMAP. Just delete the line that looks like `eflags |= MDB_FIXEDMAP` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

@n3npq why don't you send Pull Requests on your own. finding this attachments and converting them to real commits is painful and doesn't lead anywhere... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] RFE: include only used debuginfo files even if _debuginfo_subpackages is disabled (#294)

Currently, we just include everything under /usr/lib/debug to debuginfo package (even debug files for excluded binaries). When we use debuginfo subpackages, we strictly filter files out. We need to backport this functionality into one-big-debuginfo-style packages. -- You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Adding an LMDB backend to RPM (#281)

OK, best to turn it off. We were experimenting with it in OpenLDAP because we wanted to store pointer-based structures with live pointers and not need explicit serialization/deserialization. (I.e., all pointers in the struct just point to other parts of the mmap'd object.) It's a pretty

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

BDB and LMDB have always had the ability to have mutable databases (actually tables) in a single file. So actually there is a "Packages" (sub-)database/table in data.mdb. Since 2 of 3 backend now have sub-databases in a single file, its likely time to do the same with BDB. I've never bothered

[Rpm-maint] [rpm-software-management/rpm] digest_openssl: return failure if setting key failed (#293)

``` digest_openssl.c:552:9: warning: Value stored to 'rc' is never read rc = 0; ^~ ``` Acked-by: Stephen Gallagher Signed-off-by: Igor Gnatenko You can view, comment on, or merge this pull request online at:

[Rpm-maint] [rpm-software-management/rpm] fix couple of memory leaks in rpmbuild (#292)

``` ==9077== 336 (40 direct, 296 indirect) bytes in 1 blocks are definitely lost in loss record 32 of 37 ==9077==at 0x4C31C15: realloc (vg_replace_malloc.c:785) ==9077==by 0x57575B7: rrealloc (rpmmalloc.c:65) ==9077==by 0x574FEE2: argvAdd (argv.c:138) ==9077==by 0x4E45C8E:

Re: [Rpm-maint] [rpm-software-management/rpm] Adding an LMDB backend to RPM (#281)

Why are you using FIXEDMAP? That's going to lead to portability issues. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add LMDB backend for RPMDB to RPM (from @n3npq in #281) (#291)

Is it intended, that it's called `/data.mdb` rather `/Packages.mdb`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: