Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Sync disks at the end of transactions (RhBug:1461765)" (#318)
Defaulting to off would be as good as not existing. I already reverted it from 4.14 as it needs more time to bake, which is what git master is for. Not reverting ATM. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/318#issuecomment-327701452___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Sync disks at the end of transactions (RhBug:1461765)" (#318)
Closed #318. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/318#event-1238168421___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add support for premacros.d, complementing --predefine (#304)
There's surely prettier syntax that can be achieved, or alternative syntaxes
similar to what make does with conditional sections. E.g.
`%{!?_arch_x86_64:#}%foo bar`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/304#issuecomment-327570468___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add support for premacros.d, complementing --predefine (#304)
There's another approach to conditionalize macro definitions from configuration
by permitting existence tests in the first field.
Most of the usage cases that have been reported to me are based on
arch/os/platform, and the selection is being done by putting (some value) of
arch in path to select 1-of-N possible configurations.
A macro configuration file looks something like:
`%foo bar`
If, say, there was a namespaced macro '%_arch_x86_64' defined as a side effect
of reading /etc/rpm/platform, then the above could be conditionalized to be
defined on x86_64 only by abusing the %{?...} syntax:
`%{?_arch_x86_64:foo} bar`
I.e. define '%foo bar' only if the macro _arch_x86_64 is defined.
I'm not sure its worth the effort, partly because everyone is going to want a
value rather than an existence test.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/304#issuecomment-327569453___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
https://github.com/rpm-software-management/rpm/pull/318 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24120847___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Revert "Sync disks at the end of transactions (RhBug:1461765)" (#318)
This reverts commit b7a869f0f322cbe428e78150f2c175abea4c8c4b. This would need to be at a minimum configurable, and default to off for compatibility with software like rpm-ostree that is already taking care of all of this. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/318 -- Commit Summary -- * Revert "Sync disks at the end of transactions (RhBug:1461765)" -- File Changes -- M lib/transaction.c (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/318.patch https://github.com/rpm-software-management/rpm/pull/318.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/318 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
BTW, see also https://github.com/ostreedev/ostree/pull/1049 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24120807___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
rpm-ostree also has its own `syncfs()` calls and we definitely don't want librpm doing it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24120791___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
See issue #258 for faster (and better: includes cache invalidation) than sync(2). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24120569___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] RPM 4.14.0 release candidate 1 released!
"... but what happened to the beta?", I hear you ask. Well, we skipped it. To cut to the chase, the highlights since the alpha include: - Support for 'unless' rich dependencies - Ensure header is present in callback events - Macro argument quoting changed to be much more compatible - Experimental LMDB backend - Misc bugfixes and minor enhancements More details etc yadda yadda at the usual place: http://rpm.org/wiki/Releases/4.14.0 Being into RC territory also means we're feature frozen for 4.14.0 now. Really. OTOH flood gates at git master are open again. We're seeing an entirely unprecedented amount of contributions these days, so much so we tend to get a bit overwhelmed by it all. Try to bear with us, and thanks. On behalf of the rpm-team, - Panu - ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Python bindings from builddir are not used in tests (#265)
Yup - if you build with a --prefix different from the python used that happens. Fixed by commit 4bb954086af48d0661e4a930d31517226e39db7b -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/265#issuecomment-327509422___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Python bindings from builddir are not used in tests (#265)
Closed #265. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/265#event-1237001347___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Forbid 'if' richops in 'or' context and 'unless' richops in 'and' con… (#317)
…text Guide users to the correct operator instead. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/317 -- Commit Summary -- * Forbid 'if' richops in 'or' context and 'unless' richops in 'and' context -- File Changes -- M build/parseReqs.c (2) M lib/rpmds.c (93) M lib/rpmds.h (11) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/317.patch https://github.com/rpm-software-management/rpm/pull/317.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/317 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
AFAIK, Docker is dumb and passes everything through to the host filesystem to handle. So, yes... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110816___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
But... a sync() from within a container does sync() on the entire host? Really? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110632___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
The problem with opt-in is that exactly nobody is going to configure it so it's as good as useless. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110560___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
It wouldn't, because RPM within docker doesn't know where it runs. So I would rather for opt-in for this feature -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110540___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
Disabling the sync automatically on chroot installations would be fine by me. Would that cover the dockerd case? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110392___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Sync disks at the end of transactions (RhBug:1461765) (b7a869f)
Eek, that's horrible. Please add a way (macro) to disable this. Calling sync() hurts very much for big servers with huge disks and a big buffer cache. I get that's it's somewhat acceptable for software installation on the server (syncfs would still be much nicer so that data partitions don't get synced). But what you're forgetting is chroot installations like done by mock or container package installation done by dockerd. E.g. this would severely slow down open build service workers. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/b7a869f0f322cbe428e78150f2c175abea4c8c4b#commitcomment-24110006___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
