Re: [Rpm-maint] [rpm-software-management/rpm] COPYING: Minor grammar fixes (#380)
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/380#pullrequestreview-87009280___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: give some freshness to brp scripts (#308)
@Conan-Kudo There is nothing stopping 3: add script to SourceN: and invoke as %SOURCEn 4) change the macros that specify what scripts to run (but that is what is being claimed "clunky" when in fact what is desired of rpm is lazy DWIM) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/308#issuecomment-355627132___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: give some freshness to brp scripts (#308)
@n3npq I think that unless a brp script is provided by the package that also includes the binary to run, I think it's probably going to have to be option 1. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/308#issuecomment-355626343___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: give some freshness to brp scripts (#308)
@Conan-Kudo: Providing an additional directory where brp scripts might be found doesn't address conditionalizing which brp scripts are run dynamically. Its rather easy to add Yet Another Directory of brp scripts (augmenting PATH), but its rather harder to determine which scripts to run. There are two choices to conditionalize running brp scripts based on package content: 1) write the brp script to do nothing if condition is not met and run always. 2) add a build requires and invoke the script at the end of %install explicitly -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/308#issuecomment-355625771___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix sigheader generation for big archives (#379)
headerSizeof() is expensive: you are better off doing more careful arithmetic. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/379#issuecomment-355623506___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: '!=' vercmp operator (#376)
Um, perhaps, because an unspecified R is defined to match all releases. But you need to distinguish between the operation != (which will have to do set complements) and negated dependency operations (which solely negates the boolean return of a dependency assertion). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/376#issuecomment-355622731___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] COPYING: Minor grammar fixes (#380)
I was looking at this file in the context of dnf/rpm-ostree integration: https://github.com/rpm-software-management/dnf/pull/991#issuecomment-355587679 The incorrect use of "it's" was distracting; I ended up rewording the initial sentence to be more direct. The second hunk is another grammar fix. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/380 -- Commit Summary -- * COPYING: Minor grammar fixes -- File Changes -- M COPYING (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/380.patch https://github.com/rpm-software-management/rpm/pull/380.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/380 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC: give some freshness to brp scripts (#308)
So something I've seen in SUSE systems is that they have a brp-suse script, that reads from a drop-in directory containing brp scripts. They do this because we don't have a way of specifying vendor brp scripts out of the box in RPM. If vendors want to have more build root policies, they have to redefine the main thing and add to it. This is clunky, inelegant, and means that as things are fixed in RPM upstream, they won't apply to the distribution using the vendor config. This could lead to quirks and breakages, too. So I think a really simple enhancement would be to make it so that we support drop-in brp scripts like we do for macros and add a vendor search directory, too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/308#issuecomment-355585959___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make configure cope with multiple users/groups with ID 0 (#377)
Yeah the ci is broken since some time... Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/377#issuecomment-39906___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make configure cope with multiple users/groups with ID 0 (#377)
Merged #377. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/377#event-1411308278___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] tests: Ensure that only available gpg is used to import keys (#378)
Actually I doubt gpg v1 even works for the test-suite, and a quick test after renaming gpg2 out of the way seems to confirm that doubt. But that doesn't help with the actual gpg2 failure - I certainly have no clue what that error is, but presumably the container environment inside the runner is somehow strange. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/378#issuecomment-38872___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix sigheader generation for big archives (#379)
The old code just subtracted 8 bytes from the reserved space, but that does not take tag alignment into account and led to the signature header overwriting the package header. We now use headerSizeof to calculate the real size difference. Note that this only works reliable if the reserved space tag comes last in the signature header! You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/379 -- Commit Summary -- * Fix sigheader generation for big archives -- File Changes -- M lib/signature.c (43) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/379.patch https://github.com/rpm-software-management/rpm/pull/379.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/379 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
