Re: [Rpm-maint] [rpm-software-management/rpm] Add deltarpm support (#433)
AFAICT the ancient sanity check on sizeof lead+sigh+metah+payload has been ripped out in RPM4 (but I'm on an iPad without grep, sigh). Likely eliminated as part of implementing rpmarchive and uint64_t payload size replacement, but that is just a savvy guess, ICBW. Either way: using magic instead of payload format/compression flags makes a lot of sense for deltarpm recompression/decompression overhead elimination. At worst, deltarpm would need to fiddle up a new file size shanty check by replacing a tag in the signature header when switching a reconstructed package to no (or lzo if you must minimize disk space usage but improve performance) in deltarpm. There is also (IMHO) a need to convert payload compressions, and augment verifications of header/payload digests: the header/payload digests in the package are the definitions of what was originally used when the package was built no matter what funky transport (I.e. deltarpm) transforms on the original package content have been introduced as part of downloading and reconstruction. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/433#issuecomment-384446417___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: Add --nomanifests disabler (#437)
RPM attempts to read CLI file arguments as a manifest if a header cannot be read from the file. Since manifests are parsed free field, rpm behavior can become quite complex, particularly when ../../.. relative paths are parsed. There's a slew of mostly unimportant issues (IMHO: manifests are a very minor unused feature in RPM) that can/will be discovered by fuzzing. Hence there needs to be a means to disable manifest reading from the rpm CLI -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/437___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make sure all dependencies for scriptlet are installed before executing them (#436)
FWIW, in rpm-ostree today we lay out all files before executing scripts. Then we execute all `%pre`, then `%post` and `%posttrans`. Becuase of the `%pre` -> passwd dependency, we then do chowns after `%pre`. Also, [speaking of dependency loops and scripts](https://github.com/projectatomic/rpm-ostree/blob/e34f17fc3ee9b29f05d9910e9dff52a260964cfa/src/libpriv/rpmostree-core.c#L3813)... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/436#issuecomment-384287110___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add deltarpm support (#433)
Even simpler than a compression override tag would be to use the payload archive magic instead of the metadata compression tags to determine how the payload should be unpacked. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/433#issuecomment-384234213___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add deltarpm support (#433)
The recompression involved in reconstructing the *.rpm could be avoided if deltarpm was permitted to produce a package with an alternative (I.e. no compression) payload. Adding a compression override tag to, say, the signature header might be useful to avoid both the recompression and decompression when doing funky deltarpm transport. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/433#issuecomment-384232178___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make sure all dependencies for scriptlet are installed before executing them (#436)
Delaying scriptlet execution until after a SCC (if you prefer that term) is one approach to avoiding indeterminism from lack of ordering within an SCC: any/all executables within the SCC are guaranteed to be present. I tried to point out that delaying scriptlet execution adds a different type of indeterminism in choosing when to run scriptlets, not just the order in which to run scriptlets, during an install. The extreme case, where the entire transaction is an SCC, and all files are installed before scriptlets are run, is identical to the case of not needing package ordering through dependency prerequisites whatsoever. Try and see whether installations are more robust and breakage rarer by delaying scriptlet execution. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/436#issuecomment-384228461___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add deltarpm support (#433)
The beauty of the current way deltarpms are handled is that it's just some funky transport mechanism to get the full rpm. (Though I agree that the payload re-compression is the weak spot.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/433#issuecomment-384221590___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint