Re: [Rpm-maint] [rpm-software-management/rpm] RPM must kill all childs on exit (from section?) (#134)
Keep in mind that if rpmbuild itself used container features it'd heavily overlap with tools like `mock` - and while recursive containerization does work, it really requires both ends to be ready for it. See also https://github.com/projectatomic/bubblewrap/issues/284 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/134#issuecomment-422080378___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM must kill all childs on exit (from section?) (#134)
Just two ideas: 1. What if there was something like begin, ensure, end block? I.e. I could ensure that the executed process is really terminated, although the test suite failed. 2. What if I could somehow register/execute some process in background using some RPM framework? I.e. RPM would be aware there is some process running which should be terminated. These are not universal -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/134#issuecomment-422064577___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM must kill all childs on exit (from section?) (#134)
Well I'm not seriously suggesting dragging in systemd for a rare corner case
issue. OTOH we're not going to catch *all* children launched from a shell we
invoked without something more advanced and non-portable - all of those are
likely to look like serious overkill anyway.
We could of course do something like this:
```
-%___build_post exit $?
+%___build_post \
+ RPM_EC=$?\
+ for pid in $(jobs -p); do kill ${pid}; done\
+ exit ${RPM_EC}\
+%{nil}
```
...which won't catch a process that forked into background by itself, but it'd
catch anything invoked with &. Which would be better than nothing I guess.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/134#issuecomment-421998519___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] brp-compress: scan more thoroughly for man and info directories (#538)
The later version makes a whole lot more sense. It'll miss some previously
scanned directories like /usr/info though. Not that anybody should be using
those locations, but changes affecting backwards compatibility need to be
documented in the commit message.
Another possibility might be only scanning for info and man under %{_datadir},
this would cover all normal scenarios anyway with less chance of misfiring on
something that we shouldn't touch.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/538#issuecomment-421984909___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Info how beneficial is dwz compression. (#535)
Merged, thanks for the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/535#issuecomment-421967363___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] mailmap: invert emails for Igor Gnatenko (#537)
Merged #537 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/537#event-1849384058___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Info how beneficial is dwz compression. (#535)
Merged #535 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/535#event-1849383572___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Info how beneficial is dwz compression. (#535)
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/535#pullrequestreview-155864726___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
