Additionally if a package query with the argument was successful, there
is no need to rpm query of the argument.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/641
-- Commit Summary --
* Correct rpm -ql exit value when opt
> I think that the current behaviour is not expected by users. E.g. C don't
> evaluate #ifdef/#ifndef this way. Thus I let the test be "expected failure".
The test-suite is not about user expectations, it's about what's implemented in
rpm. The behavior is not a result of a bug, so expected failu
> the macros can be defined in the spec directly
Yes, it is a good observation.
The spec file is changed to the proposed one.
>Then there's the issue of what it actually tries to test and what it expects -
>this is not really an expected failure but expected behavior, very similarly
>to how ma
>
> On Tuesday, March 12, 2019 9:55:29 AM CET nim-nim wrote: I think there are
> two different things here, how you format rpmbuild error output to stdout/err
> Why we should care about 'rpmbuild' stdout/stderr here?
Because people do write scripts that call rpmbuild. It's a lower level of
coup
On Tuesday, March 12, 2019 9:55:29 AM CET nim-nim wrote:
> I think there are two different things here, how you format rpmbuild error
> output to stdou/err
Why we should care about 'rpmbuild' stdout/stderr here? That should be
just informative thing. For machines, rpmbuild just fails, and doing
@praiskup
> -1. I think that rpmbuild should assure that the shape of the output file is
> as deterministic as possible, no matter whether the packages are or are not
> already installed. I think it should be just a list of build requires without
> any prefix or so, without any header message,
> Yes, specific exit status would make it easier for mock, but I fail to see
> what are the expected rpmbuild exit statuses from it's manual page,
> unfortunately and it seems to be so far undefined.
Yes. I checked the code and rpmbuild *always* fail with
_exit(EXIT_FAILURE)
which has value 1
@xsuchy wrote:
> What exit code rpmbuild returns when a build fails because of
> %generate_buildrequires?
I'd say it can be non-zero, as mock doesn't necessarily have to expect a
"specific" exit status in this case. Yes, specific exit status would make it
easier for mock, but I fail to see wha
