@ignatenkobrain pushed 3 commits.
19961172f5ebc3d728eeeb6463d6478a3278bd59 rpmbuild: Generate
buildreqs.nosrc.rpm properly with --nodeps
c2f5358a3346eb8b886d87aeb2b66605094aa19a rpmbuild: Put dynamic BuildRequires
into src.rpm even with --nodeps
7d339dff7a69c778bdef4bdbae16e52ed20ac36a Fix pr
All your comments are incorporated in the new version.
First two commits are now in a single commit.The second now add a general type
of an error for inappropriate ordering of conditionals + change of
implementedTypes name.
--
You are receiving this because you are subscribed to this thread.
Re
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/660
-- Commit Summary --
* Use $ldflags in ./configure macro in order to set LDFLAGS.
-- File Changes --
M macros.in (1)
-- Patch Links --
https://github.com/rpm-softw
Hmm, just realized I misplaced this comment so the context is missing:
>No problem with the change itself, but the commit message doesn't really
>convey what's going on.
On first sight the diff looks like excessive white-space changes or something,
you need to look quite closely to see that the
Well, the point is to have a specific name. lineTypes seems fairly obvious
candidate, branchTypes would be less bad, which is not to say it's a good name.
Good names are often harder than the code itself.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
Please, do you have any idea what name can be used instead of implementedTypes?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/649#issuecomment-481998368___
