Re: [Rpm-maint] [rpm-software-management/rpm] Support triple operator for conditional shortcut (#115) (#746)

2019-08-05 Thread Panu Matilainen
pmatilai requested changes on this pull request. If I interpret that correctly, you just dismiss all the spaces that might be there. So what if you WANT to emit spaces? Also, the triple syntax has to give the same exact results as doing the same thing without the older conditional operator for

Re: [Rpm-maint] [rpm-software-management/rpm] Support triple operator for conditional shortcut (#115) (#746)

2019-08-05 Thread pavlinamv
> And how do you're supposed to know which spaces before and after the 0/1 are > intentional or not? This must expand literally to either " 0 " or " 1". According to the specification of triple operator - all spaces - after '%{?!' or '%{?', - before and after ':' that divides the operator and -

Re: [Rpm-maint] [rpm-software-management/rpm] Support triple operator for conditional shortcut (#115) (#746)

2019-08-05 Thread Panu Matilainen
``` %global with_lua %{?{_without_lua} : 0 : 1} ``` And how do you're supposed to know which spaces before and after the 0/1 are intentional or not? This *must* expand literally to either " 0 " or " 1". Rip support for the "courtesy" spaces everywhere. -- You are receiving this because you

Re: [Rpm-maint] [rpm-software-management/rpm] Need to limit threads based on available memory and address space (#804)

2019-08-05 Thread Panu Matilainen
FWIW https://bugzilla.redhat.com/show_bug.cgi?id=1118734 is also related, there are systems with huge number of CPUs but limited memory. So we'll need have means to get available memory on both per-process and system-wide basis, and have separate calculations(+macros) for the number of parallel

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild output is garbled (#794)

2019-08-05 Thread Panu Matilainen
Yeah we probably should stop grabbing stdout on our own when we dont actually use the data. Besides causing various display-artifacts under mock and the like, it's also simply doing a whole lot of work for no reason. -- You are receiving this because you are subscribed to this thread. Reply to