Re: [Rpm-maint] [rpm-software-management/rpm] Get rid of automake in favour of CMake or meson (#887)

2019-10-14 Thread ニール・ゴンパ
While I don't particularly like autotools (and generally prefer CMake to it myself), the large amount of autotest usage in this codebase for the test suite is a huge impairment for migrating to anything else. I don't expect it to change unless we dedicated time to change all this, and it might

Re: [Rpm-maint] [rpm-software-management/rpm] Don't insert rpmlib() dependencies for dynamic buildrequires (#878)

2019-10-14 Thread Pavel Raiskup
> Whether SRPM uses DynamicBuildRequires feature This is can not be answered, though, by looking at the SRPM. It depends on what system the srpm is built on. It is similar to conditional BuildRequires, etc. > Whether SRPM has DynamicBuildRequires inserted into it You mean whether RPM has some

Re: [Rpm-maint] [rpm-software-management/rpm] bad version comparison in all rpm (#896)

2019-10-14 Thread Michael Schroeder
Closed #896. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/896#event-2710646748___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] bad version comparison in all rpm (#896)

2019-10-14 Thread Michael Schroeder
No, that's correct. The `-` character compares the same as the `.` character, and 5 is greater than 1. The `rpmvercmp` function only compares the version or the release parts. You need to split the input into epoch/version/release and then do individual rpmvercmp calls. -- You are receiving

[Rpm-maint] [rpm-software-management/rpm] bad version comparison in all rpm (#896)

2019-10-14 Thread Alexander Stefanov
example #include #include #include ``` int main() { const char * version1 = "0.13-5"; const char * version2 = "0.13.1-5"; int result = rpmvercmp(version1, version2); if (result == -1) std::cout << version1 << " < " << version2 << std::endl;; if (result == 0) std::cout <<

Re: [Rpm-maint] [rpm-software-management/rpm] Added option to rpmbuild to check the build dependencies (-bd, -td, -rd) (#876)

2019-10-14 Thread Panu Matilainen
Also a test-case or two wouldn't hurt. It should be easy to adapt the test for dynamic buildrequires into a new test covering this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Added option to rpmbuild to check the build dependencies (-bd, -td, -rd) (#876)

2019-10-14 Thread Florian Festi
The new parameters need to be added to the rpmbuild man page before they can be merged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: