Re: [Rpm-maint] [rpm-software-management/rpm] Make database backends self-aware (#910)
> Make database backends self-aware :cold_sweat: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/910#issuecomment-544540645___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make database backends self-aware (#910)
Rebased and added both rpmdbStat() and rpmdbFStat() now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/910#issuecomment-544510621___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make database backends self-aware (#910)
mlschroe approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/910#pullrequestreview-304543216___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Multiple fixes in rpmxdb.c for the ndb database backend (#909)
pmatilai approved this pull request. Fine with me -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/909#pullrequestreview-304537154___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Multiple fixes in rpmxdb.c for the ndb database backend (#909)
Merged #909 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/909#event-2729539592___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Make database backends self-aware (#910)
Okay okay, maybe not... Add name and path members to backend db_ops struct, use them for configuring and detecting, and misc related tweaks. Started doing this for implementing rpmdbStat(), but got stuck wondering about the API: my initial version requires an open rpmdb for stating, which limits its usefulness. Perhaps there should be separate calls for an open database and non-open one, just like theres fstat() and stat(). Thoughts? You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/910 -- Commit Summary -- * Add backend name and path of main database file to db_ops struct * Use the new backend struct data for backend configuration and detection * Use paths from db_ops in the backends too where possible * Document dummy backend in macros, warn on dummy fallback -- File Changes -- M lib/backend/db3.c (3) M lib/backend/dbi.c (96) M lib/backend/dbi.h (5) M lib/backend/dummydb.c (3) M lib/backend/lmdb.c (3) M lib/backend/ndb/glue.c (5) M lib/backend/sqlite.c (5) M macros.in (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/910.patch https://github.com/rpm-software-management/rpm/pull/910.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/910 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Database utility cleanup (#905)
Merged #905 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/905#event-2729509297___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
Gak... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#issuecomment-544485048___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
Urks. I always had a feeling the cancel stuff is fishy, but... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#issuecomment-544481722___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
Note that some error paths don't work correctly when building without omp. Those are the ones that use `#pragma omp cancel parallel`, where the `goto exit;` statements were deleted. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#issuecomment-544473304___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Multiple fixes in rpmxdb.c for the ndb database backend (#909)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/909 -- Commit Summary -- * Use xdbs pagesize instead of sysconf(_SC_PAGE_SIZE) * Multiple fixes in rpmxdb.c for the ndb database backend -- File Changes -- M lib/backend/ndb/rpmidx.c (7) M lib/backend/ndb/rpmxdb.c (13) M lib/backend/ndb/rpmxdb.h (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/909.patch https://github.com/rpm-software-management/rpm/pull/909.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/909 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild: %patch: fix a memory leak (#873)
@pmatilai Ah, oops. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/873#issuecomment-544452654___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild: %patch: fix a memory leak (#873)
Dropping opt_P doesn't mean dropping %patch -P. If you look at the code, you'll notice that the opt_P variable is entirely unused, the values are obtained via other means - opt_P couldn't supply multiple values of -P at any rate. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/873#issuecomment-544365188___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
Thanks for the patch, it's another one for the impending 4.15.x bugfix release. Also interesting and useful to know OM is using Clang, should keep us honest wrt gcc extensions and such ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#issuecomment-544364435___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
Merged #907 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#event-2728415806___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
pmatilai approved this pull request. Sure, doesn't get much more obvious than this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#pullrequestreview-304343616___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Fully shutdown DBUS on systemd_inhibit cleanup (RhBug:1714657)" (#900)
We don't specifically mark stuff for backporting, but this is an obvious one as it's a regression. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/900#issuecomment-544363427___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
