Re: [Rpm-maint] [rpm-software-management/rpm] Make database backends self-aware (#910)
> Make database backends self-aware :cold_sweat: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/910#issuecomment-544540645___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make database backends self-aware (#910)
Rebased and added both rpmdbStat() and rpmdbFStat() now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/910#issuecomment-544510621___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make database backends self-aware (#910)
mlschroe approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/910#pullrequestreview-304543216___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Multiple fixes in rpmxdb.c for the ndb database backend (#909)
pmatilai approved this pull request. Fine with me -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/909#pullrequestreview-304537154___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Multiple fixes in rpmxdb.c for the ndb database backend (#909)
Merged #909 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/909#event-2729539592___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Make database backends self-aware (#910)
Okay okay, maybe not... Add name and path members to backend db_ops struct, use them for configuring and detecting, and misc related tweaks. Started doing this for implementing rpmdbStat(), but got stuck wondering about the API: my initial version requires an open rpmdb for stat'ing, which limits its usefulness. Perhaps there should be separate calls for an open database and non-open one, just like there's fstat() and stat(). Thoughts? You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/910 -- Commit Summary -- * Add backend name and path of main database file to db_ops struct * Use the new backend struct data for backend configuration and detection * Use paths from db_ops in the backends too where possible * Document dummy backend in macros, warn on dummy fallback -- File Changes -- M lib/backend/db3.c (3) M lib/backend/dbi.c (96) M lib/backend/dbi.h (5) M lib/backend/dummydb.c (3) M lib/backend/lmdb.c (3) M lib/backend/ndb/glue.c (5) M lib/backend/sqlite.c (5) M macros.in (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/910.patch https://github.com/rpm-software-management/rpm/pull/910.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/910 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Database utility cleanup (#905)
Merged #905 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/905#event-2729509297___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
Gak... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#issuecomment-544485048___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
Urks. I always had a feeling the cancel stuff is fishy, but... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#issuecomment-544481722___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: Add missing ifdef to conditionalize omp.h include statement (#907)
Note that some error paths don't work correctly when building without omp. Those are the ones that use `#pragma omp cancel parallel`, where the `goto exit;` statements were deleted. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/907#issuecomment-544473304___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Multiple fixes in rpmxdb.c for the ndb database backend (#909)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/909 -- Commit Summary -- * Use xdb's pagesize instead of sysconf(_SC_PAGE_SIZE) * Multiple fixes in rpmxdb.c for the ndb database backend -- File Changes -- M lib/backend/ndb/rpmidx.c (7) M lib/backend/ndb/rpmxdb.c (13) M lib/backend/ndb/rpmxdb.h (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/909.patch https://github.com/rpm-software-management/rpm/pull/909.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/909 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild: %patch: fix a memory leak (#873)
@pmatilai Ah, oops. 😶 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/873#issuecomment-544452654___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] Using RPM with NDB on macOS
On 10/20/19 3:47 AM, Neal Gompa wrote: Hey all, As I had alluded to in the pull request adding the SQLite rpmdb backend[1], I have been doing some work every once in a while for the past few years on rpm for macOS. A point of frustration has been having a working bdb package, and maintaining bdb is functionally impossible for me, as I have no capability to fix bugs there. I had been experimenting with LMDB since it was introduced. Unfortunately, it turned out to be more problematic than I expected. Originally, NDB didn't work on macOS because of its usage of mremap() (which does not exist on macOS)[2]. Thankfully, Michael Schroeder recently fixed this in git master[3], so I gave it another try. After a minor issue[4] and a backport of the ndb fixes to rpm 4.15[5], I was able to transition to ndb and start trying it. I've gotten rpm itself working with ndb, and it seems like all the basic actions work perfectly fine with ndb. I'm working on building up a package manager stack so that I can start doing some more interesting tests, but there are issues with libsolv where it makes the assumption about where the rpmdb path is and what type of rpmdb it is... My current plan is to at least get to the point where I can try working with the solv(1) demo program included in libsolv, and then proceed from there. At least with the DNF stack, there's still the problem that it assumes bdb[6] and specific rpmdb paths. I'd like to get to the point that I could use MicroDNF[7]... [1]: https://github.com/rpm-software-management/rpm/pull/899#issuecomment-543129651 [2]: https://github.com/rpm-software-management/rpm/issues/334 [3]: https://github.com/rpm-software-management/rpm/commit/3625ca14c752fa229c79891fcc6374df40b5b588 [4]: https://github.com/rpm-software-management/rpm/pull/907 [5]: https://github.com/rpm-software-management/rpm/compare/rpm-4.15.x...Conan-Kudo:rpm-4.15.0-osx-ndb [6]: https://github.com/rpm-software-management/libdnf/issues/362 [7]: https://github.com/rpm-software-management/microdnf Add https://github.com/openSUSE/libsolv/issues/354 to the list, it's essentially the very same thing as libdnf ticket #362. - Panu - ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
