IIRC on rpm5.org last time I saw popt 0.17 which had way more freshen
translations (and more translations) and all .po files converted to UTF-8 + few
minor code cleanups.
Looks like rpm5.org domain disappeared :/
If that tree still is somewhere it would be good to merge all those changes.
I shoul
Corrected patch in progress, will push tomorrow.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#issuecomment-555122938___
Rp
To elaborate a bit, the reason this bumps popt version dependency to 1.16 is
that older versions did not *have* the pkgconfig file, and so cannot satisfy
the dependency. The rpm.pc was added long before popt added its own, which is
the main reason it's not there now.
Expressing that dependency
Good point @mlschroe , we're still in a library here and the calling process
may have forked children we don't know about, and whose termination should not
affect our behavior. So we should only abort if the SIGCHLD originated from our
forked gpg process, and probably use SA_NOCLDSTOP to ignore
> (A different fix that might also work (untested) would be to simply open the
> named pipe for reading before doing the exec call. You can even do that
> before the fork(). The opened file descriptor will not be used by gpg, but
> that shouldn't hurt.)
Turns out this won't work. When calling `
Brainstorming:
* bcond_default_same + bcond_default_opposite
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/941#issuecomment-555008238___
I agree. `%bcond_inherit` and `%bcond_antiinherit` are indeed not very good.
Brainstorming some ideas:
* bcond_default_as
* bcond_default_like
* bcond_like
* bcond_as
For the opposite relation, I'm unsure. Mayeb we can use something like
```
%bcond_like ! bootstrap
```
However I'm unsure i
I would find it useful as well. However, we should really consider the naming,
as bconds are already confusing enough, this could become completely unreadable
to people not-in-the-know.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
> (A different fix that might also work (untested) would be to simply open the
> named pipe for reading before doing the exec call. You can even do that
> before the fork(). The opened file descriptor will not be used by gpg, but
> that shouldn't hurt.)
This actually sounds pretty good. I'll gi
> A SIGCHLD can happen all the time for whatever reason, you need at least to
> check if the process still exists and retry the Fopen if it does and the
> error is EINTR.
Could you please elaborate? The thing is, what we're trying to do here is to
actually get Fopen unblock when a SIGCHLD happe
I often find myself writing code like this:
```
%bcond_with some_thing
%if %{with some_thing}
%bcond_with some_other_thing
%else
%bcond_without some_other_thing
%endif
```
Or the other way around:
```
%bcond_with some_thing
%if %{with some_thing}
%bcond_without some_other_thing
%else
%bcond_wi
Oh, ugh. Now that I started rebasing rawhide to 4.15.1 I notice Fedora also
reverted 8c3a7b8fa92b49a811fe36b60857b12f5d7db8a8 and upstream should've
probably done the same because now the detection code can come up with
architectures that are not in the rpmrc anymore.
Which means that as far as
ffesti commented on this pull request.
> @@ -659,6 +674,10 @@ int main(int argc, char *argv[])
case 's':
ba->buildAmount |= RPMBUILD_PACKAGESOURCE;
break;
+case 'd':
This looks fishy. The `'r'` case also gets
```
ba->buildAmount |= RPMBUILD_PREP;
```
and I fail to see
Ok, opposite to what is discussed in #875 this patch does not the same thing as
`rpmbuild -bb --nobuild`. The later does not execute `%generate_buildrequires`
while this patch clearly tries to do that. In it's function it is very close to
-br but does not build the srpm if no issue is encountere
This is first and foremost a critical bugfix release to address some
regressions introduced in 4.15.0 and a few other important bugs in that
release. This would've been called 4.15.0.1 if it wasn't for one thing:
a new (optional) libgcrypt crypto backend, which is good news for those
who wer
Merged #923 into rpm-4.15.x.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/923#event-2807024391___
Rpm-maint mailing list
Rpm-m
Okay, that's it then. Thanks for the feedback.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/923#issuecomment-554960749___
Rpm-
(A different fix that might also work (untested) would be to simply open the
named pipe for reading before doing the exec call. You can even do that before
the fork(). The opened file descriptor will not be used by gpg, but that
shouldn't hurt.)
--
You are receiving this because you are subsc
Right, I'll add a remark to 4.15.0 release notes about it then to make it
official behavior change.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/875#issuecomment-55495
A SIGCHLD can happen all the time for whatever reason, you need at least to
check if the process still exists and retry the Fopen if it does and the error
is EINTR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://gi
Ok, as there is a supported way of doing this already I am just closing this.
Adding a new top level command that does the same thing only would add to the
confusion and create even more weird interactions with all the different
parameters.
--
You are receiving this because you are subscribed t
Closed #875.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/875#event-2806912594___
Rpm-maint mailing list
Rpm-maint@lists.rpm
This effectively sets our popt version requirement to >= 1.16 from the current
>= 1.13.
It's not necessarily a bad thing (1.16 wasn't exactly released yesterday), but
such a thing needs to be a conscious decision and documented appropriately in
the commit message and INSTALL.
--
You are receiv
pmatilai commented on this pull request.
> @@ -276,7 +282,26 @@ static int runGPG(sigTarget sigt, const char *sigfile)
rpmPopMacro(NULL, "__plaintext_filename");
rpmPopMacro(NULL, "__signature_filename");
+/* The child GPG process may terminate without ever opening the pipe (such
dmnks commented on this pull request.
> @@ -276,7 +282,26 @@ static int runGPG(sigTarget sigt, const char *sigfile)
rpmPopMacro(NULL, "__plaintext_filename");
rpmPopMacro(NULL, "__signature_filename");
+/* The child GPG process may terminate without ever opening the pipe (such
+
pmatilai commented on this pull request.
> @@ -276,7 +282,26 @@ static int runGPG(sigTarget sigt, const char *sigfile)
rpmPopMacro(NULL, "__plaintext_filename");
rpmPopMacro(NULL, "__signature_filename");
+/* The child GPG process may terminate without ever opening the pipe (such
dmnks commented on this pull request.
> @@ -276,7 +282,26 @@ static int runGPG(sigTarget sigt, const char *sigfile)
rpmPopMacro(NULL, "__plaintext_filename");
rpmPopMacro(NULL, "__signature_filename");
+/* The child GPG process may terminate without ever opening the pipe (such
+
dmnks commented on this pull request.
> @@ -276,7 +282,26 @@ static int runGPG(sigTarget sigt, const char *sigfile)
rpmPopMacro(NULL, "__plaintext_filename");
rpmPopMacro(NULL, "__signature_filename");
+/* The child GPG process may terminate without ever opening the pipe (such
+
28 matches
Mail list logo
