Re: [Rpm-maint] [rpm-software-management/rpm] rpmconstant API should exist in librpm itself (#992)

2019-12-26 Thread ニール・ゴンパ
The problem with "randomly" defined tags is that the lack of consistency means 
that RPMs can become incompatible with each other, simply by using the same 
spots in the rpm header for different purposes. I suppose if the tag names were 
discoverable from the header (e.g. with rpmconstant API), then this would be 
less of a problem, since we wouldn't rely on fixed addresses for tags in the 
enum...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/992#issuecomment-569175195___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Fix compilation on platforms without MAP_POPULATE (#985)

2019-12-26 Thread KOLANICH
>I think this desserves some better commit message 

I have just preserved the message present in the patch. BTW, it LGTM. How do 
you propose to change it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/985#issuecomment-569055577___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2019-12-26 Thread KOLANICH
>it'll be a dead link if this is merged.

There is a backup on WebArchive now. We all know that if we see a dead link we 
should check WebArchive for it :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984#issuecomment-569055065___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Fix compilation on platforms without MAP_POPULATE (#985)

2019-12-26 Thread KOLANICH
@KOLANICH pushed 1 commit.

9ca1ac7b62bede14906359e3cd07a8d9069df29f  Fix compilation on platforms without 
MAP_POPULATE


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/985/files/152f3326ba895264da10e0904eaa529e59be77eb..9ca1ac7b62bede14906359e3cd07a8d9069df29f
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2019-12-26 Thread KOLANICH
@KOLANICH pushed 3 commits.

4c7323f69b4fddf928245e9db2d1c9ca9b277ef2  Fix building with no BerkeleyDB 
support
166c6c5a1e066bd485f3be98feb5935b1b050f3a  Move db_descr assignment from rpmdb 
to dbi
17645a87842f6f478d01bebf1c0c1e827e8db4c6  Do not use bashism for gettext


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984/files/3c297794a53a5a4a3cc13b183ad0323b830c7df9..17645a87842f6f478d01bebf1c0c1e827e8db4c6
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] rpmconstant API should exist in librpm itself (#992)

2019-12-26 Thread Igor Gnatenko
I think it would be useful to be able to define "random" RPMTAG_* somewhere 
from rpm macro so that we don't have to have things like RPMTAG_MODULARITYLABEL 
in RPM upstream, but rather define it in Fedora/RHEL. And have RPM API to be 
able to retrieve such values.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/992#issuecomment-569036523___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2019-12-26 Thread ニール・ゴンパ
@KOLANICH I'd rather have the link to the Debian patch file removed from the 
commit message. It's not particularly important...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984#issuecomment-569015987___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] rpmconstant API should exist in librpm itself (#992)

2019-12-26 Thread ニール・ゴンパ
Mageia (and Mandriva before it) has had a librpm extension library called 
[rpmconstant](https://github.com/rpm-software-management/rpmconstant) for a 
long time now.

I am not sure why this functionality does not exist in librpm itself, but it 
probably should. While I am not proposing the existing rpmconstant code gets 
merged in (unless we can get it relicensed to LGPLv2+ like the rest of librpm, 
this is probably a no-go), I think it makes sense that the API it offers is 
available as part of librpm, effectively obsoleting the rpmconstant project.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/992___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Berkeley DB not disabled with --disable-bdb (#983)

2019-12-26 Thread ニール・ゴンパ
@stefanbidi Can you try with the current git master? This should be fixed now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/983#issuecomment-569014057___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] fix zstd magic (#991)

2019-12-26 Thread ニール・ゴンパ
Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/991#pullrequestreview-336458025___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for reading BDB without the library (#980)

2019-12-26 Thread ニール・ゴンパ
@mlschroe This should probably conflict with the option to enable the normal 
bdb backend. I see no reason for both to be enabled at the same time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/980#issuecomment-569008611___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for reading BDB without the library (#980)

2019-12-26 Thread Igor Gnatenko
ignatenkobrain approved this pull request.

```
 5 files changed, 837 insertions(+)
```

:/



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/980#pullrequestreview-336448477___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix building without BerkeleyDB support and move db_descr assignment (#979)

2019-12-26 Thread Igor Gnatenko
Merged #979 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/979#event-2908650999___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint