Re: [Rpm-maint] [rpm-software-management/rpm] Document RPM generator input and output format (#1011)
Maybe `echo -n ` is used to additionally print `= XXX`, then the output format must be just line-by-line values? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1011#issuecomment-574770755___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Document RPM generator input and output format (#1011)
I have found what was wrong ("NAME needs to be replaced by the name choosen for
the file attribute and needs to be the same as the file name of the macro file
itself").
But please document the input and output format. `pkgconfigdeps.sh` uses `echo
-n 'value '` and then `echo` an empty line, `find-provides.php` uses just
`echo`
(https://github.com/rpm-software-management/rpm/blob/master/scripts/find-provides.php#L14).
Also in https://rpm.org/user_doc/dependency_generators.html it is first written:
"generation of Provides: and Requires:"
but then examples are givven for recommends etc.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1011#issuecomment-574765409___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] 3 cleanup fixes (#359)
Bad reading, bad patch. Sorry for the NULL pointer dereference. I'm not sure, I might have mixed up somewhere with the different backends. That said, the real problem could have been confusion about the code that calls closeEnv(). It doesn't seem to make sense to test if `rdb->db_dbenv` is NULL before calling closeEnv(). It suggests we're not sure if we've called openEnv() or not. But if we're not sure, then how do we know whether to decrement `rdb->db_dbenv->refs` or not? IOW, I think what I should have sent is: ```diff diff --git a/lib/backend/ndb/glue.c b/lib/backend/ndb/glue.c index 90c10f889..46e115846 100644 --- a/lib/backend/ndb/glue.c +++ b/lib/backend/ndb/glue.c @@ -74,8 +74,7 @@ static int ndb_Close(dbiIndex dbi, unsigned int flags) rpmidxClose(dbi->dbi_db); rpmlog(RPMLOG_DEBUG, "closed db index %s\n", dbi->dbi_file); } -if (rdb->db_dbenv) - closeEnv(rdb); +closeEnv(rdb); dbi->dbi_db = 0; return 0; } ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/359#issuecomment-574760188___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Document RPM generator input and output format (#1011)
I have been writing an RPM generator (https://rpm.org/user_doc/dependency_generators.html) and I can't understand which output format it must have. Script is here: https://abf.io/import/devel-rpm-generators/ It simply does not work, no provides/requires are generated, I have looked into `pkgconfigdeps.sh`, tried to make the same output format, but it still does not work. Neither stdout not stderr are printed. But, if I run it locally, it works correctly: `` ` bash-4.4# ls /usr/lib64/*.so | $(rpm --eval %__devel_provides) 2>/dev/null devel(libBrokenLocale(64bit)) devel(libanl(64bit)) devel(libatomic(64bit)) devel(libc(64bit)) devel(libcrypt(64bit)) devel(libdl(64bit)) <...> ``` Just as `pkgconfigdeps.sh`: ``` bash-4.4# ls /usr/lib64/pkgconfig/*.pc -1v | /usr/lib/rpm/pkgconfigdeps.sh --provides pkgconfig(libzstd) = 1.4.3 pkgconfig(popt) = 1.16 pkgconfig(rpm) = 4.15.1 ``` Example build log with this generator enabled: https://abf.io/build_lists/3186141 Currently the output method is: ``` echo -n "$@ " echo ``` (https://abf.io/import/devel-rpm-generators/blob/rosa2019.1/develgen.sh#lc-7) It is like https://github.com/rpm-software-management/rpm/blob/master/scripts/pkgconfigdeps.sh#L34 Please help to understand what is wrong in https://abf.io/import/devel-rpm-generators/ . There is no documentation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1011___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add NEVR provides for all packages that would be built into source rpms (#891)
Since there are no objections... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/891#issuecomment-574627598___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add NEVR provides for all packages that would be built into source rpms (#891)
Merged #891 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/891#event-2950529863___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] 3 cleanup fixes (#359)
Hmm, the ndb glue change here looks decidedly wrong to me, the thing is reference counted for a reason (guess this shows just how much attention I've been paying to ndb changes, and I guess that needs to change from now on) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/359#issuecomment-574616568___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] 3 cleanup fixes (#359)
FYI: I had to revert the ndb glue change, as it caused segfaults if just an index dbi got closed. The commit doesn't contain any information about the problem it tries to solve, do you remember why your change was necessary? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/359#issuecomment-574609659___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Merged #1009 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#event-2950342476___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb compilation fails with -Werror on gcc 9.2.1 / glibc 2.30 (#1008)
Closed #1008 via #1009. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1008#event-2950342480___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
pmatilai approved this pull request. This is quite a reasonable way to get around the dumb warning in general I think. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#pullrequestreview-343132896___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Right, I hate these unsilenceable "we know better" warnings too, with a passion. BTW thanks for the pointer, at least in the newer bug points out there's now a "nodiscard" attribute that does the right thing for these cases. Guess we should lobby glibc to adopt that instead of the obnoxious warn_unused_result. Anyway, works for me, thanks for fixing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#issuecomment-574604640___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Reopened #1009. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#event-2950287205___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
@mlschroe pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009/files/9076d958bf91502eed454283d7daeafece4c6836..471e7d8bb26f0d7be877a261812b8dd8172650d3 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Closed #1009. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#event-2950269608___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
Oh my. The gcc people seem to be not too happy about this, but it's hard to fix because the void cast is optimized away before the unused result check is done. See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425 Anyway, fixed to something that will work with the current gcc version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#issuecomment-574596279___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: check rich dependencies for special characters (4.14.x) (#605)
But then, we process backports in batches anyway so this is not going to be merged via this PR anyway, closing. Still, we need to come up with a way to earmark commits for inclusion in stable releases, and a more open process for doing those stable updates in general. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/605#issuecomment-574574687___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] build: check rich dependencies for special characters (4.14.x) (#605)
Closed #605. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/605#event-2950093383___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add --zlib-compress-debug-sections to find-debug-info.sh (#795)
Dusting off old PRs... Has this gone into openSUSE by now, any experiences collected? At any rate, you'll need to rebase this PR and get rid of the extra merge commit in order to proceed. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/795#issuecomment-574573339___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)
Merged #927 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/927#event-2950049257___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use git apply --reject to assist with modifying patches (#927)
Sorry for dropping the ball here, seems obvious enough to me. Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/927#issuecomment-574569382___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] ndb: fix ftruncate return value warning (#1009)
pmatilai requested changes on this pull request. As per above: this doesn't actually change the behavior at all, so NAK. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1009#pullrequestreview-343075223___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM Signature Tags MD5 TAG size after --addsign (#1010)
Closed #1010. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1010#event-2950016749___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM Signature Tags MD5 TAG size after --addsign (#1010)
That's a bug in your rpm, optimization that gets wrong results on exact data is not a legit optimization. We actually had the same bug although in slightly limited form, see #398 for the discussion and fix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1010#issuecomment-574565245___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM Signature Tags MD5 TAG size after --addsign (#1010)
We use a weird version of rpm, which computes data size by subtracting next offset from the current one, which yields 18 bytes and then MD5 check fails. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1010#issuecomment-574553032___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
