So, apologies for the confusion and thanks for the patch!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #928 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/928#event-2992242517___
Rpm-maint mailing list
Ehm, so @ffesti kicked me to *actually look* at the patch reveals that -u is
not being introduced, just that it'll now accept the format in addition.
:man_facepalming:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@ffesti, to me the issue here is whether to accept the use of non-standard -u
option to diff. In the Linux world, unidiffs *are* the de-facto standard, and
I'm much happier with the format itself, so it's just a question of who we end
up hurting if we change it.
--
You are receiving this
May be this also deserves a test case or two.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1022#issuecomment-580115091___
Oh, it was perfectly clear and I fully agree. I just fixed the easy part
because, well, it's easy :smile: The config stuff is not.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
The patch and the commit message looks good now. Ready to be merged IMHO.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Ok, may be this was not clear enough from my comments: I want to see the last
few issues with the macro handling resolved and the patch merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
ffesti commented on this pull request.
> @@ -0,0 +1,17 @@
+.TH "RPM-AUDIT" "8" "28 Jan 2020" "Red Hat, Inc."
+.SH NAME
+rpm-plugin-audit \- Audit plugin for the RPM Package Manager
+
+.SH Description
+
+The plugin writes basic information about rpm transactions to the audit log -
like packages
ffesti commented on this pull request.
> +.SH DESCRIPTION
+\fBrpm2archive\fP converts the .rpm files specified as arguments to gz
+compressed tar files with suffix ".tgz".
+
+If '-' is given as argument, an rpm stream is read from standard in and
+written to standard out.
+
+In opposite to
I kept the changes to the plugin man pages as a separate patch to make them
easier to review. Will squash them before them getting merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
pmatilai commented on this pull request.
> @@ -1415,8 +1467,23 @@ static int rpmtsSetup(rpmts ts, rpmprobFilterFlags
> ignoreSet)
return 0;
}
+/* Enable / disable optimizations for solid state disks */
+static void setSSD(int enable)
+{
+if (enable) {
+ rpmlog(RPMLOG_DEBUG,
@pmatilai pushed 1 commit.
94dfac0bfabeadde5ff9a4045ad871954adeb8b0 Auto-enable optimizations for
non-rotational disks on Linux
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Merged #1026 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1026#event-2989680181___
Rpm-maint mailing list
@ffesti pushed 1 commit.
ddbf30cf96a33319805b362b01d8a6fdfe7dea9c Allow qualifiers like pre, post,
preun, ... for weak dependencies, too
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@mlschroe pushed 5 commits.
da94ee8195da2bc841e2a4606f2948d46a1109bb Drop useless %{F:..} built-in macro
85e5a70368854da0537099128530b0df69ca2216 Fix regression on v3 package handling
on database rebuild
d5c69756cf6cd16e7c2e8b81fba19bf81f3dd1ba Explicitly mention that the rpmio/
sub dir is
Commit 708e61307bc3fd027b016fdf5a1d1a5274c1843c introduced a memory leak
on the error object: if the message is suppressed then the error object
is never freed. Test for the suppression conditions separately to fix.
You can view, comment on, or merge this pull request online at:
Oh and BTW, the code failing with gcc 10 got nuked in commit
da94ee8195da2bc841e2a4606f2948d46a1109bb so rebase will get rid of the
unrelated CI failure.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #1023 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1023#event-2989369001___
Rpm-maint mailing list
And we have a winner.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1023#issuecomment-579740663___
Rpm-maint mailing list
Adjusted commit message to include more history and reasoning.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@ffesti pushed 3 commits.
da94ee8195da2bc841e2a4606f2948d46a1109bb Drop useless %{F:..} built-in macro
85e5a70368854da0537099128530b0df69ca2216 Fix regression on v3 package handling
on database rebuild
b04038b71d4fe18db1d85f0c159985725254d8cc Explicitly mention that the rpmio/
sub dir is
No, signing is just, well, signing. Keyring stuff is in librpm/librpmio.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Hmm, makes sense.
What about importing GPG keys and keyring management? That's not in sign, is it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #1025 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1025#event-2989264260___
Rpm-maint mailing list
Closed #1017 via #1025.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1017#event-2989264275___
Rpm-maint mailing list
Good catch, thanks.
These things really just make me want to drop the gauntlet on v3 packages
finally. But until then...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1025#pullrequestreview-350054499___
Introduced in commit 27ea3f8624560bd158fc7bc801639310a0ffab10, the
wrong header is being added in case of v3 packages.
Fixes: #1017
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1025
-- Commit Summary --
* Fix regression
Merged #1024 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1024#event-2989204693___
Rpm-maint mailing list
My sentiments exactly. And to have this gem block our CI due to tripping a new
warning from gcc-10... :joy:
Removing it wont fix the generic case in #1019 but nobody should spend time
fixing this code...
--
You are receiving this because you are subscribed to this thread.
Reply to this email
@pmatilai Why would signing (also split out from lib) be desirable as GPL
verses LGPL?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Conan-Kudo approved this pull request.
*blinks* ... wut...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
After a closer look, sorry guys but I don't believe this API belongs to rpm at
all.
These things are better handled in language specific bindings, exposing only
things that the particular bindings actually implement and in ways that are
native to that language.
--
You are receiving this
Closed #992.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/992#event-2989181925___
Rpm-maint mailing list
Or LGPLv2+, which would be equally sufficient.
`rpmconstant` only has two authors: Thierry Vignaud and Olivier Thauvin. We can
probably reach both authors and request relicensing `rpmconstant` to LGPLv2+,
which makes it suitable for integration into RPM.
--
You are receiving this because you
As the code in the rpmio sub directory was split out of the lib sub dir
it is already under LGPL as code derived from the source code
in the
lib subdirectory according to the license. But not having the sub
directory
mentioned in the license confuses users and contributers.
So this change does
mikhailnov commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
@pmatilai I agree that *.debug
pmatilai commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
res and rc are used pretty much
The ability to automatically convert is kinda cool, but it's not safe to just
go ahead and convert anytime we spot a difference - think of eg chroot
manipulation. My plan was always to just leave any database conversion down to
an explicit --rebuilddb operation, and maybe add a hint about that
mikhailnov commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
`res` is also used, e.g. in
As the librpm part of RPM is licensed under both GPL and LGPL the current
license of rpmconstant (GPLv2) is not compatible with the rpm code base. To
integrate the code into rpm the license would need to be changed to GPL + LGPL.
--
You are receiving this because you are subscribed to this
"internal RPM values" is just incorrect. These are all constants declared in
public rpm headers. Looking at %file_const in
https://github.com/rpm-software-management/rpmconstant/blob/master/rpmh2tbl
gives a better idea of what is happening here.
So this is basically the same thing we already
Oh and BTW, I don't see any benefit from adding these in separate commits.
Might just as well merge all into one big "add manuals for xxx, yyy..." commit.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
pmatilai commented on this pull request.
> @@ -0,0 +1,17 @@
+.TH "RPM-AUDIT" "8" "28 Jan 2020" "Red Hat, Inc."
+.SH NAME
+rpm-plugin-audit \- Audit plugin for the RPM Package Manager
+
+.SH Description
+
+The plugin writes basic information about rpm transactions to the audit log -
like
pmatilai commented on this pull request.
> +.SH DESCRIPTION
+\fBrpm2archive\fP converts the .rpm files specified as arguments to gz
+compressed tar files with suffix ".tgz".
+
+If '-' is given as argument, an rpm stream is read from standard in and
+written to standard out.
+
+In opposite to
We are using weak dependency for ordering now. So it make sense to also
qualify weak dependencies with the time they are needed/wanted in the
transaction to make use of this information in ordering.
Especially (posttrans) could be useful to remove weak deps from dependency
loops during ordering
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1021
-- Commit Summary --
* Add man page for rpm2archive
* Add man page for the selinux plugin
* Add man page for the syslog plugin
* Add man page for the audit plugin
48 matches
Mail list logo
