Re: [Rpm-maint] [rpm-software-management/rpm] A saner way for marco argument escaping (#1060)

2020-02-07 Thread Panu Matilainen
Anyway, looks fine to me on the outset. I'll have a closer look next week. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] A saner way for marco argument escaping (#1060)

2020-02-07 Thread Panu Matilainen
FWIW, tested a bit with the macro generator thing - even after all this noexpand stuff, the %{basename:%{1}} testcase still ends up eating %'s in due to the re-expansion in doFoo(). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] A saner way for marco argument escaping (#1060)

2020-02-07 Thread Michael Schroeder
@mlschroe pushed 1 commit. 42b61f94e8ae14f484184984246d7ea84ae1bf20 Add rpmPushMacroFlags function to allow the definition of literal macros -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] A saner way for marco argument escaping (#1060)

2020-02-07 Thread Panu Matilainen
> We also may want to expose this by adding a rpmPushMacroLiteral() function Lets use a more generic name that takes a flags arguments so it's extensible in the future (for example a readonly/protected kind of behavior would come in handy occasionally). Another approach that wouldn't require a

Re: [Rpm-maint] [rpm-software-management/rpm] A saner way for marco argument escaping (#1060)

2020-02-07 Thread Michael Schroeder
Another good name would be `ME_LITERAL`. We also may want to expose this by adding a rpmPushMacroLiteral() function so that this can be used in other places where we don't want expansion to happen. E.g. everywhere where we have calculated a file name or path and want to set a macro for it. --

[Rpm-maint] [rpm-software-management/rpm] A saner way for marco argument escaping (#1060)

2020-02-07 Thread Michael Schroeder
This adds a ME_NOEXPAND macro flag that turns off body expansion. This is much simpler than the weird % character doubling. Its also a bit faster because theres less calls to expandMacro(). You can view, comment on, or merge this pull request online at: