While we are on it, shouldn't we move these to rpm-extras?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
olafhering commented on this pull request.
> +}
+#
+#
+usage() {
+echo >&2 "Usage: ${0##*/} -prov|-req [-f 'ocamlobjinfo cmd']"
+}
+#
+mode=
+ignore_implementation_a=()
+ignore_interface_a=()
+while test "$#" -gt 0
+do
+ : "${1}" "${2}"
+ case "${1}" in
+-prov) mode='prov' ;;
+
Conan-Kudo requested changes on this pull request.
> +}
+#
+#
+usage() {
+echo >&2 "Usage: ${0##*/} -prov|-req [-f 'ocamlobjinfo cmd']"
+}
+#
+mode=
+ignore_implementation_a=()
+ignore_interface_a=()
+while test "$#" -gt 0
+do
+ : "${1}" "${2}"
+ case "${1}" in
+-prov) mode='prov' ;;
I use rpmReadPackageFile() to get RPM headers then use headerGetString() and
headerIsSource() during the lifetime of the program. At the end, I call
headerFree() on the RPM headers I read in at the beginning but these are not
freed because the reference counts are at 67. I see headerUnlink()
Ok, I have to admit I'm not entirely sure what fpLookupSubdir is trying to fix.
It was added by Florian in commits c6ccc90d7fef0f1b65e4bf5b77d5b800d4b53ffd and
af3464a053ecb0b56cc5af494ea22955fb350757, unfortunately without a reference to
some bug.
It seems to be about having a symlink in one
@mlschroe pushed 1 commit.
1c9343142a728dce571ee0c8ce4f6fae42354588 Reduce the number of calls to
fpLookupSubdir()
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
This reduces the number of calls to fpLookupSubdir() and also gets rid of a
poolid-str-poolid roundtrip.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1071
-- Commit Summary --
* fpLookupSubdir: get rid of a
Dependencies between OCaml files containing native code are also tracked
by hashes, just like their bytecode counter parts.
OCaml native code files end with cmx, the relevent info is in cmx, cmxa
and cmxs files. Unlike all other OCaml files, cmxs files have ELF format.
OCaml has two variants of
Merged #1068 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#event-3038286887___
Rpm-maint mailing list
pmatilai approved this pull request.
Cool, thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@mlschroe pushed 1 commit.
3252e1e25872bc7820828425e1daea51d0700b13 Remove duplicated code in
fpLookupSubdir
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Ouch, no. Sorry.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#issuecomment-586170405___
Rpm-maint mailing list
Reopened #1068.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#event-3037996933___
Rpm-maint mailing list
@pmatilai was it intentional to close PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#issuecomment-586161085___
Closed #1068.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1068#event-3037849435___
Rpm-maint mailing list
Nice.
Since you're fixing the cicle/cycle comment typo already: care to fix that
entire comment while we're at it? These patches get rid of all the other //
comments in there, so that one out-of-style sticks out even more now. Plus it
could be more concise, really. Not that this is a
Merged #1069 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1069#event-3037806101___
Rpm-maint mailing list
pmatilai approved this pull request.
All those rounds of cleaning up the fsm, and still there's unused code around.
Looks good, thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
18 matches
Mail list logo
