Re: [Rpm-maint] [rpm-software-management/rpm] Add ability to calculate filedigests using Streebog-256 and Streebog-… (#1082)
Conan-Kudo requested changes on this pull request.
It's a good first start, just some initial nits...
> @@ -395,6 +395,7 @@ AC_SUBST(WITH_OPENSSL_LIB)
WITH_LIBGCRYPT_INCLUDE=
WITH_LIBGCRYPT_LIB=
if test "$with_crypto" = libgcrypt ; then
+ AC_DEFINE(WITH_LIBGCRYPT, 1, [Build with libgcrypt instead of nss3 support?])
Why the `instead of nss3 support?`? This could just be `Build with libgcrypt as
the crypto backend`.
> @@ -1229,6 +1229,17 @@ static const struct rpmlibProvides_s rpmlibProvides[]
> = {
{ "rpmlib(FileDigests)", "4.6.0-1",
(RPMSENSE_EQUAL),
N_("file digest algorithm is per package configurable") },
+#ifdef WITH_LIBGCRYPT
+/*
+ * As rpmlib(FileDigestsGOST12) is available only when RPM is built with
libcgrypt,
+ * to avoid other versions of RPM from misunderatanding hashes
+ * (see e.g. https://github.com/rpm-software-management/rpm/issues/959),
+ * require FileDigestsGOST12 separately
+ */
+{ "rpmlib(FileDigestsGOST12)", "4.16.0-1",
+ (RPMSENSE_RPMLIB|RPMSENSE_EQUAL),
+N_("file digest can be GOST R 34.11 2012 (STREEBOG256, STREEBOG512)") },
I'm not sure how to word this yet, but I don't like this wording much...
> @@ -266,6 +266,8 @@ typedef enum pgpHashAlgo_e {
PGPHASHALGO_SHA384 = 9, /*!< SHA384 */
PGPHASHALGO_SHA512 = 10, /*!< SHA512 */
PGPHASHALGO_SHA224 = 11, /*!< SHA224 */
+PGPHASHALGO_GOST12_256 = 100, /*!< GOST R 34.11-2012 256 */
+PGPHASHALGO_GOST12_512 = 101, /*!< GOST R 34.11-2012 512 */
Is there a reason we jump so many values?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1082#pullrequestreview-362355795___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make parametric macro arguments available as native Lua table (#1063)
That would definitely be useful, thanks for looking at it! Can you extend the
concept to macro arguments please? My macro files are full of:
```lua
local processall = (rpm.expand("%{-a}") ~= "") and (rpm.expand("%{-z}") == "")
localverbose = (rpm.expand("%{-v}") ~= "")
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1063#issuecomment-589226237___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Speed up dependency solving by using pool ids (#1081)
This gets rid of a couple of id-str-id roundtrips and also makes the dependency hashes in rpmtsCheck() use pool ids instead of strings. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1081 -- Commit Summary -- * Add fingerprint lookup/compare variants that take ids * Get rid of id-str-id roundtrips in rpmalAllFileSatisfiesDepend() * Only lookup the fingerprint when the directories do not match * Switch dependency checking to use pool ids instead of strings -- File Changes -- M lib/depends.c (106) M lib/fprint.c (17) M lib/fprint.h (17) M lib/rpmal.c (17) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1081.patch https://github.com/rpm-software-management/rpm/pull/1081.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1081 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Otherwise this looks pretty reasonable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-589081451___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
Not a fan of the %__multiarch_deps macro tbh. First it does not allow to completely switch to the new multiarch-deps whihc is something distributions probably want to do at some point. So it does not remove the need to eventually patch the .attr file. The other question is whether there should be a macro at all. This invites package(r)s to fiddle with it when they probably shouldn't. Are there any use cases other that switching the distribution policy? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-589079635___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
