Re: [Rpm-maint] [rpm-software-management/rpm] Convert few simple generators for a parametric ones + fix for parametric generators (#1163)

2020-04-05 Thread ニール・ゴンパ
@Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1163#pullrequestreview-387841233___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] RFE: Add possibility to generate Requires(meta) by a dependency generators (#1164)

2020-04-05 Thread Igor Gnatenko
Technically, by request I mean to be able to generate meta, pre, post and such, 
basically Requires with qualifier.

There are 2 ways how to do it:

* Just let scripts to emit `(meta|pre|post)` in the beginning/end of the string 
and parse it
* Create a new __foo_requires_meta and such in *.attr files

I think first way is much simpler to implement and to use (because usually you 
know this information from the same files and you want to avoid re-parsing 
files over and over.

I would appreciate if this could go into 4.16.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1164___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Convert desktop/metainfo generators for a parametric ones + fix for parametric generators (#1163)

2020-04-05 Thread Igor Gnatenko
@ignatenkobrain pushed 1 commit.

d6e2b928f2df67be3d051c3ffda0b16493d6d76d  Convert debuginfo generator to a 
parametric generator


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1163/files/108ddacf6f43c0cb917bafc5c6219fe6bd3872c1..d6e2b928f2df67be3d051c3ffda0b16493d6d76d
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] %1 in parametric generator contains doubled %{buildroot} (#1162)

2020-04-05 Thread Igor Gnatenko
Fixed as one of commits in 
https://github.com/rpm-software-management/rpm/pull/1163.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1162#issuecomment-609431106___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Convert desktop/metainfo generators for a parametric ones + fix for parametric generators (#1163)

2020-04-05 Thread Igor Gnatenko
@ignatenkobrain pushed 1 commit.

108ddacf6f43c0cb917bafc5c6219fe6bd3872c1  Convert desktop generator to a 
parametric generator


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1163/files/9fc8e3487b67b21b793c2c087f1002c4a5dd4064..108ddacf6f43c0cb917bafc5c6219fe6bd3872c1
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Convert desktop/metainfo generators for a parametric ones + fix for parametric generators (#1163)

2020-04-05 Thread Igor Gnatenko

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1163

-- Commit Summary --

  * Convert metainfo generator to a parametric generator
  * rpmfc: Do not prepend buildroot to a path for parametric generator
  * Convert desktop generator to a parametric generator

-- File Changes --

M build/rpmfc.c (6)
M fileattrs/desktop.attr (23)
M fileattrs/metainfo.attr (7)
M scripts/Makefile.am (7)
D scripts/desktop-file.prov (25)
D scripts/metainfo.prov (19)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1163.patch
https://github.com/rpm-software-management/rpm/pull/1163.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1163
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] %1 in parametric generator contains doubled %{buildroot} (#1162)

2020-04-05 Thread Igor Gnatenko
I was trying to port desktop generator to a parametric macro, but hit the 
problem that `rpm.expand("%1")` results into 
`/home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64//home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64/usr/share/applications/org.gnome.Terminal.desktop`.

As you can see, the BUILDROOT part is twice there.

This seems like a very trivial fix. I'll send PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1162___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint