@s-t-e-v-e-n-k pushed 1 commit.
0afbfbb67b8b5d8346271a7d8d2351ad4ed0f411 scripts/pythondistdeps: Switch to
argparse
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1181/files/0ea13f93d5b179c416042274d8
@ignatenkobrain commented on this pull request.
> +parser.add_argument('-P', '--provides', action='store_true', help='Print
> Provides')
+parser.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+parser.add_argument('-r', '--recommends', action='store_true', help='Pr
@s-t-e-v-e-n-k commented on this pull request.
> +parser.add_argument('-P', '--provides', action='store_true', help='Print
> Provides')
+parser.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+parser.add_argument('-r', '--recommends', action='store_true', help='Pri
@ignatenkobrain commented on this pull request.
> +parser.add_argument('-P', '--provides', action='store_true', help='Print
> Provides')
+parser.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+parser.add_argument('-r', '--recommends', action='store_true', help='Pr
Stop using getopt, and switch to a modern solution for parsing
arguments. Drive-by fixing some flake8 warnings, mainly whitespace.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1181
-- Commit Summary --
* scripts/pythondis
Well, we don't need to allow %global.
Anyway, let's move a step back and talk about this issue. This is about one
shot macros. Implementation wise this is not hard, it's more a question of
syntax.
It would be nice to have the following options:
- literal: do not expand the macro when using it
-
Just to xref, since this one was closed the current plan is for rpm-ostree to
wrap rpm, instead of having rpm wrap rpm-ostree:
https://github.com/coreos/rpm-ostree/pull/1789
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
There are other downsides too, such as arbitrary side-effects and code
execution on load (as opposed to time of use).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1155
Crazy thought: we could allow to use %define/%global in the macro file, as
those are illegal macro names. I.e. we could allow this:
```
%foo hello
%define bar world
```
(rpm internally somewhat rewrites the %foo to %define foo anyway)
Then we could also allow
```
%undefine foo
```
which is someth
You could also just use some macro to turn it on/off like with the other rpm
flags, i.e.:
```
%define _warn_on_undefined_macro_expansion 1
```
That would make it easy to turn it on for a whole project in OBS.
--
You are receiving this because you are subscribed to this thread.
Reply to this emai
@mlschroe , any thoughts on this? There needs to be a way to enable/disable
those warnings but I really dislike the flag approach in this patch. One
possibility for controlling it might be a macro primitive ala %trace, but
enabling those warnings globally is something we're not ready for at all
FWIW, I can easily reproduce similar timings here. Using `rpmbuild -bb
--noclean --short-circuit' to limit it to only the packaging phase, I get ~58s
before the patch and ~44s after it. It's quite a nice win.
BTW bonus points for the graphs in the commit message, they illustrate the
problem rea
@pmatilai commented on this pull request.
> rpmRC packageBinaries(rpmSpec spec, const char *cookie, int cheating)
{
rpmRC rc = RPMRC_OK;
Package pkg;
+Package *tasks;
+int i = 0;
+
+for (pkg = spec->packages; pkg != NULL; pkg = pkg->next)
+i++;
+tasks = xcallo
@pmatilai commented on this pull request.
> @@ -726,16 +727,37 @@ static rpmRC packageBinary(rpmSpec spec, Package pkg,
> const char *cookie, int ch
return rc;
}
+static int compareBinaries(const void *p1, const void *p2) {
+Package pkg1 = *(Package *)p1;
+Package pkg2 = *(Packa
14 matches
Mail list logo
