Re: [Rpm-maint] [rpm-software-management/rpm] [feature-request] %{SOURCENAME$} macro (#1197)

2020-04-26 Thread Damian Ivanov
I tried that, it didn't work at first, now copying it from here it does...
Thanks Neal.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1197#issuecomment-619549073___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] [feature-request] %{SOURCENAME$} macro (#1197)

2020-04-26 Thread Damian Ivanov
Closed #1197.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1197#event-3272939316___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] [feature-request] %{SOURCENAME$} macro (#1197)

2020-04-26 Thread ニール・ゴンパ
Wouldn't `%{basename:%{SOURCE0}}` do the trick?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1197#issuecomment-619544129___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] scripts/pythondistdeps: New test suite and various updates and fixes (#1195)

2020-04-26 Thread ニール・ゴンパ
@Conan-Kudo requested changes on this pull request.



> +
+
+if __name__ == "__main__":
+"""To allow this script to be importable (and its classes/functions
+   reused), actions are performed only when run as a main script."""
+
+parser = argparse.ArgumentParser(prog=argv[0])
+group = parser.add_mutually_exclusive_group(required=True)
+group.add_argument('-P', '--provides', action='store_true', help='Print 
Provides')
+group.add_argument('-R', '--requires', action='store_true', help='Print 
Requires')
+group.add_argument('-r', '--recommends', action='store_true', help='Print 
Recommends')
+group.add_argument('-C', '--conflicts', action='store_true', help='Print 
Conflicts')
+group.add_argument('-E', '--extras', action='store_true', help='Print 
Extras')
+group_majorver = parser.add_mutually_exclusive_group()
+group_majorver.add_argument('-M', '--majorver-provides', 
action='store_true', help='Print extra Provides with Python major version only')
+group_majorver.add_argument('--majorver-provides-versions', action='store',

Instead of making this comma separated, can we use `append` or `extend` 
instead? It would make sense to store internally as a list. This would 
eliminate the weird formatting requirements too...

> @@ -11,6 +11,10 @@
 # RPM python dependency generator, using .egg-info/.egg-link/.dist-info data
 #
 
+# Please know:
+# - Notes from an attempted rewrite from pkg_resources to importlib.metadata in
+#   2020 can be found in the message of the commit that added this line.

 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1195#pullrequestreview-400497608___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] [feature-request] %{SOURCENAME$} macro (#1197)

2020-04-26 Thread Damian Ivanov
Multiple times came across situations where it would be handy to have 
%{SOURCENAME} macros for the SOURCES.

```
Name:   test
Version:1.0
Release:0
Source0:myfile

%description
test package

%prep
%build
mkdir -p %{buildroot}%{_prefix}/MyDirectory/
install -m 0755 %{SOURCE0} %{buildroot}%{_prefix}/MyDirectory/

%install

%files
%{_prefix}/MyDirectory/%{SOURCENAME0}  # and not %{_prefix}/MyDirectory/myfile 
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1197___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint