Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup gpg-agent handling in test-suite (#1270)

2020-06-15 Thread Florian Festi
Merged #1270 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1270#event-3445622887___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-15 Thread Tom Stellard
> Okay, the problem is fairly obvious, pkg being declared way outside the > parallel block. > But rather than sprinkling more OpenMP magic dust to solve it, can you verify > that this (ie just declare the variable inside the parallel block) solves the > problem? > > ``` > #pragma omp

Re: [Rpm-maint] [rpm-software-management/rpm] Make the "rpmbuild debuginfo -g3 .debug_macro" test an expected fail … (#1267)

2020-06-15 Thread Tom Stellard
Would it be possible to backport this to the 4.16 branch? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Cleanup gpg-agent handling in test-suite (#1270)

2020-06-15 Thread Panu Matilainen
Localize the setup/teardown to the only place needing it. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1270 -- Commit Summary -- * Merge obsoletion tests sharing built content to single group * Merge dependency tests

Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)

2020-06-15 Thread Florian Festi
Wow! You now basically halved the time of the test suite takes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)

2020-06-15 Thread Florian Festi
Merged #1269 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1269#event-3443606399___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)

2020-06-15 Thread Panu Matilainen
Just for the record, this cuts down the running time of `./rpmtest -j8` on my laptop from ~52s to ~40s. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)

2020-06-15 Thread Panu Matilainen
Okay, the problem is fairly obvious, pkg being declared way outside the parallel block. But rather than sprinkling more OpenMP magic dust to solve it, can you verify that this (ie just declare the variable inside the parallel block) solves the problem? ``` #pragma omp parallel #pragma

[Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)

2020-06-15 Thread Panu Matilainen
Merge tests to groups when they share built content to avoid redundant builds over and over again, eliminate redundant copies on build tests etc. Besides removing gobs of crud, makes it run faster too. You can view, comment on, or merge this pull request online at:

Re: [Rpm-maint] [rpm-software-management/rpm] RPM fsverity support (#1203)

2020-06-15 Thread Panu Matilainen
> RPM doesn't actually need the fsverity utility to be present, but it does > need libfsverity Yup, the library is what I meant by my comment, not the utility. Thanks for adding the check. I'll need to take closer look at the updated version but overall I think its in fair shape for this