Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)
If you don't mind... yeah, please do :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1264#issuecomment-645818174___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Account for symlinks in total package size (RhBug:1848199) (#1275)
The symlinks do occupy space so they should be counted, except for hardlinks to symlinks. Rpm's own disk-space accounting is not affected, it always looks at individual file sizes rather than the total size. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1275 -- Commit Summary -- * Account for symlinks in total package size (RhBug:1848199) -- File Changes -- M build/files.c (11) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1275.patch https://github.com/rpm-software-management/rpm/pull/1275.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1275 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add --excludeartifacts install option (#1274)
Like docs, configs etc, excluding artifacts from installation might sometimes be desireable to eg save space. Inspired by https://bugzilla.redhat.com/show_bug.cgi?id=1848199 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1274 -- Commit Summary -- * Add --excludeartifacts install option -- File Changes -- M doc/rpm.8 (4) M lib/poptI.c (3) M lib/rpmts.h (3) M lib/transaction.c (8) M tests/rpmi.at (17) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1274.patch https://github.com/rpm-software-management/rpm/pull/1274.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1274 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1271#pullrequestreview-432885992___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Add ability to run lua scripts directly (#1273)
@hroncok has made interesting progress in #1215, you might want to check that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1273#issuecomment-645719776___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add database change notification API (#1124)
@cgwalters Okay, and how do non-Linux systems do this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1124#issuecomment-645719125___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix data race in packageBinaries() function (#1264)
@pmatilai Do you want me to re-submit this pull request with your suggested fix? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1264#issuecomment-645700387___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: Add ability to run lua scripts directly (#1273)
It would be great if we could pass a lua script directly to rpm. The primary motivation for this is so that rpm-ostree can make use of this when running scriptlets. But I suspect it would also be useful for packagers to test their lua scripts more easily without having to rebuild an RPM each time. For more background on this, see also: https://github.com/coreos/rpm-ostree/issues/749 http://lists.rpm.org/pipermail/rpm-ecosystem/2016-August/000391.html -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1273___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM fsverity support (#1203)
> > RPM doesn't actually need the fsverity utility to be present, but it does > > need libfsverity > > Yup, the library is what I meant by my comment, not the utility. Thanks for > adding the check. > > I'll need to take closer look at the updated version but overall I think its > in fair shape for this point, and the added tags totally reasonable. So I'm > considering the tags reserved, and there are no competing tag additions at > the moment, but if it makes you sleep better we can certainly merge the tag > addition right away to cement the reservation. Sounds good, thanks for looking at it! I think we can wait for the library to land. I pushed it into Fedora 32 for testing yesterday, so hopefully it will get out shortly: https://bodhi.fedoraproject.org/updates/FEDORA-2020-2f41b015c0 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1203#issuecomment-645552077___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)
Downstream discovery in https://src.fedoraproject.org/rpms/python-rpm-generators/pull-request/20 I wonder, what changed in RPM? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-645402304___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)
The %__python_magic filter suddenly got suppressed by the magic filter. Hence, the generator started to pick files like: /opt/usr/lib/python3.X/... Required python(abi). We don't need to filter the files by file magic, so we drop it. Previously, it seems that the behavior was flaky. The path filter was more important than the magic one somehow. Now we can choose if the filters are applied as OR or AND. However, we don't want either. We actually want to mach any files in Python directories. We *could* filter by file type (and executable bit) for provides, but that would require us to split the attr files into two. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1272 -- Commit Summary -- * Fix python(abi) requires generator, it picked files from almost good directories -- File Changes -- M fileattrs/python.attr (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1272.patch https://github.com/rpm-software-management/rpm/pull/1272.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add database change notification API (#1124)
Just to echo https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-645103007 here - inotify is used today for e.g. `/usr/share/applications` - when you e.g. `zypper/apt/yum/whatever install firefox` that's how the desktops pick up the change. As far as portability, there are already a *lot* of cross platform wrappers for inotify. For example, GLib has one. So I think the simple solution is: - Add an API to librpm to get a directory file descriptor (or path) to the rpmdb directory - Change the code to whever something is written call `touch()` on that directory - Suggest that higher level libraries use inotify (not rpm itself) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1124#issuecomment-645350098___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)
:tada: Would be nice to get that into 4.16. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1271#issuecomment-645323467___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)
Previously only the legacy external dependency generator listened to exit codes from the generator, and even that only for provides. Anybody building packages will want to know if generators barf up for one reason or another. Let them. Always call rpmfcExec() with failnonzero set, pass errors around, add tests. Fixes: #1183 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1271 -- Commit Summary -- * Always fail build on dependency generator failures (#1183) -- File Changes -- M build/rpmfc.c (32) M tests/rpmbuild.at (36) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1271.patch https://github.com/rpm-software-management/rpm/pull/1271.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1271 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)
(Colin, see issue #1124 for a solution using a named pipe) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-645250342___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint