[Rpm-maint] [rpm-software-management/rpm] librpm and its python bindings should give enough messages in order to debug problems in a black box fashion (#1307)

2020-07-09 Thread KOLANICH
librpm has very bad error messages implementation. It is really hard to determine what is going wrong. It should have more debug messags calls in strategical points - at least before every branch leading to returning failure. error reporting in python bindings should be fixed too -- You are re

[Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-07-09 Thread KOLANICH
Damn. I have wasted a lot of time today because of librpm almost silently jas refused to import a key. Reproducer: 1. use #1305 to get the more detailed error message than just -1 on later stage (when the key is added) 2. ```python import requests import rpm suseKeyResp = requests.get("https:

[Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)

2020-07-09 Thread KOLANICH
I was really hard to get that that I cannot import a key is just a bug in librpm and its python bindings. This PR makes it a bit more clear. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1305 -- Commit Summary -- * Improv

Re: [Rpm-maint] [rpm-software-management/rpm] zstd compression: port to the new API. (#1303)

2020-07-09 Thread marxin
> I haven't checked the zstd implementation, I admit, I just know that this was > the problem with parallel bzip2/xz compression. I've made some experiments for a 100MB big file and the compressed output is still the same. For being sure, I asked the question in https://github.com/facebook/zstd

Re: [Rpm-maint] [rpm-software-management/rpm] zstd compression: port to the new API. (#1303)

2020-07-09 Thread Michael Schroeder
You need to recreate the same bytewise identical compression when applying the deltarpm. The parallel compression implementations tend to partition the data and compress the chunks individually, leading to a different result. I haven't checked the zstd implementation, I admit, I just know that t