[Rpm-maint] [rpm-software-management/rpm] Is "not create a %_sourcedir / %_specdir" really necessary? (#1408)

[falu0]

Refers to :
https://github.com/rpm-software-management/rpm/commit/a55cb376fa9d9f785081fa13802edc3743a879ca
 , 
https://github.com/rpm-software-management/rpm/commit/ca26c221e5d92b4908c5a07d2bba36f80379b43b
 (the latter not really, but they come together)

This triggers a change of behavior in rpmbuild which will break many 
long-existing workflow as soon as rpmbuild v4.16.0-release is adopted. Such 
change is already out in the fedora-33 rpm provided package (from which we have 
been bitten).

I understand the ratio behind it, but, if not reverted, I'd advise to 
communicate it better to the users, both in 
the changelog https://rpm.org/wiki/Releases/4.16.0 and/or through some 
significant error message.

Currently (in both 4.16.0-release and master branch), if no `%_sourcedir` path 
is pre-existing, you only see a `__CURL` error which doesn't really add any 
information from the rpm(build) POV. 

```
# rpmbuild -v -ba --undefine=_disable_source_fetch my.spec
warning: Downloading  to {%_topdir}/SOURCES/
curl: (23) Failure writing output to destination
error: Couldn't download 
```

Reverting 
https://github.com/rpm-software-management/rpm/commit/a55cb376fa9d9f785081fa13802edc3743a879ca
 in 4.16.0-release (or the equivalent 
https://github.com/rpm-software-management/rpm/commit/acf5e00281d73a2f8034091241c7b0e2ba00e383
 in master), looks to be sufficient (I just recompiled-installed-run the above 
command tho), but you may want to consider a better solution.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1408___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Implement a real stack for parametric macro locals (#1409)

[Panu Matilainen]

FWIW, the macro argument argv needs similar treatment but I'm out of steam for 
the day...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1409#issuecomment-714448481___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Implement a real stack for parametric macro locals (#1409)

[Panu Matilainen]

Mixing up local stack and global data never was such a hot idea, as locals 
could get trapped between globals and not freed at appropriate times etc.

This clears the semantics wrt that, fixing a long-standing expected failure in 
the test-suite. Another semantics change is that you can no longer undefine a 
locally defined macro, which eliminates the ambiguity of what should happen 
on %undefine if both global and local macros exist. As such, theres of 
course some potential for breakage too.

Besides clear semantics, this should speed up parametric macro execution as we 
no longer need to huff and puff the global table up and down on entry and exit. 
Furthermore, this paves way to using a hash for the macro table.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1409

-- Commit Summary --

  * Separate macro table from the context
  * Implement a real stack for parametric macro locals

-- File Changes --

M build/rpmfc.c (2)
M rpmio/macro.c (180)
M rpmio/rpmmacro.h (1)
M tests/rpmmacro.at (3)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1409.patch
https://github.com/rpm-software-management/rpm/pull/1409.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1409
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add preliminary support for dynamic built-in macro registration (#1406)

[Panu Matilainen]

Pushed a bit more elaborate/sophisticated version...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1406#issuecomment-714317770___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint