Re: [Rpm-maint] [rpm-software-management/rpm] Add new rpmExpandThisMacro() public method (#1414)

2020-10-26 Thread ニール・ゴンパ
@pmatilai `spectool` was rewritten to use RPM Python bindings, so I imagine at least it would matter for that tool. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add new rpmExpandThisMacro() public method (#1414)

2020-10-26 Thread Panu Matilainen
Oh and BTW, there's actually an existing use-case for this in the code-base: this is exactly what runCall() in build/rpmfc.c wants. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add new rpmExpandThisMacro() public method (#1414)

2020-10-26 Thread Panu Matilainen
...except that's exactly where it starts getting trickier: from Lua the argv is differently allocated and shouldn't be freed in freeArgs() and at least in my version there was "fun" with me->opts processing retriggering the option processing when it shouldn't have, etc. But many details are

Re: [Rpm-maint] [rpm-software-management/rpm] Add new rpmExpandThisMacro() public method (#1414)

2020-10-26 Thread Panu Matilainen
I can pick up the Lua side once this is merged, no need to redo all that. As for Python, the bindings wrt macros are really primitive as it is and nobody is complaining so I dunno if anybody cares. At any rate, I don't consider that a requirement for merging. -- You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add new rpmExpandThisMacro() public method (#1414)

2020-10-26 Thread Michael Schroeder
This needs to be connected to python/lua as well. How should the interface look like? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add new rpmExpandThisMacro() public method (#1414)

2020-10-26 Thread Panu Matilainen
Ah, making a copy of the argv so the allocation business is different from what I had. https://github.com/pmatilai/rpm/tree/luamt-2 is a quick "port" on top of this and the basic testcases pass as-is, but only very briefly tested. -- You are receiving this because you are subscribed to this

[Rpm-maint] [rpm-software-management/rpm] Add new rpmExpandThisMacro() public method (#1414)

2020-10-26 Thread Michael Schroeder
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1414 -- Commit Summary -- * Make comments reflect new macro parsing reality * Move setupArgs() function so that it is next to freeArgs() * Split doExpandThisMacro() from

Re: [Rpm-maint] [rpm-software-management/rpm] lib/rpmrc.c: include fcntl.h for O_* (#1413)

2020-10-26 Thread Panu Matilainen
Merged #1413 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1413#event-3920037615___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] lib/rpmrc.c: include fcntl.h for O_* (#1413)

2020-10-26 Thread Panu Matilainen
@pmatilai approved this pull request. Was about to say "didn't we just fix this already" but seems that was some other place (9395bdc6445935763842e7a28304b4d76301) for the very same reason... Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Rpm-maint] [rpm-software-management/rpm] Refactor handling of parameterized macro args (#1412)

2020-10-26 Thread Panu Matilainen
@pmatilai approved this pull request. Not entirely unlike what I in my own version :smile: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Refactor handling of parameterized macro args (#1412)

2020-10-26 Thread Panu Matilainen
Merged #1412 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1412#event-3918960394___ Rpm-maint mailing list