Re: [Rpm-maint] [rpm-software-management/rpm] Fix a minor memory leak on failed sqlite database open (RhBug:1896301) (#1430)

[Daniel Mach]

The memory leak in libdnf unit tests is gone after applying the patch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1430#issuecomment-724864404___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Translations update from Weblate (#1432)

[Weblate (bot)]

Translations update from 
[Weblate](https://translate.fedoraproject.org/projects/rpm/master/) for 
rpm/master.



Current translation status:

![Weblate translation 
status](https://translate.fedoraproject.org/widgets/rpm/-/master/horizontal-auto.svg)

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1432

-- Commit Summary --

  * Added translation using Weblate (Hebrew)

-- File Changes --

M po/LINGUAS (2)
A po/he.po (4058)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1432.patch
https://github.com/rpm-software-management/rpm/pull/1432.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1432
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] build/pack.c: build failure due to pragma omp task untied on codesourcery-mips toolchain (#1420)

[Fabrice Fontaine]

Thanks for your answer, unfortunately, commit 
6a780f10c2b600cfc38f8b8f20cb7e40b979f541 raises a build failure when 
cross-compiling because it uses `AC_RUN_IFELSE`. I sent #1431 to fix this 
issue. Moreover, I would advise to replace AC_MSG_ERROR([OpenMP too old]) by a 
simple warning that disable openmp. Would it be acceptable?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1420#issuecomment-724852922___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] configure.c: fix cross-compilation (#1431)

[Fabrice Fontaine]

Use AC_COMPILE_IFELSE as AC_RUN_IFELSE raises a build failure when
cross-compiling

Signed-off-by: Fabrice Fontaine 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1431

-- Commit Summary --

  * configure.c: fix cross-compilation

-- File Changes --

M configure.ac (4)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1431.patch
https://github.com/rpm-software-management/rpm/pull/1431.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1431
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

[torsava]

> Oh, I've been alerted by @torsava that my suggestions have been addressed. 
> Nice, thanks! The code looks good to me. If the external tests still pass, 
> let's ship it?
> 
> We can probably test this in Fedora before merging if we want more testing 
> (but this is not necessary).
> 
> Thank you @s-t-e-v-e-n-k!

I'd prefer to merge it here, we've delayed the PR long enough :) We'll test it 
in Fedora in any case, and we can address possible issues later.

Thank you @s-t-e-v-e-n-k for having patience with us :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#issuecomment-724772529___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Is "not create a %_sourcedir / %_specdir" really necessary? (#1408)

[David Nichols]

> A temporary file name ending up in the package is of course not intentional.

Should I open a new issue then for the rpmbuild breakage, or is this one OK to 
repurpose for that?  The source fetch issue brought me here only because it was 
caused by the same commit - it doesn't affect me personally, but the rpmbuild 
breakage could theoretically affect a lot of users I believe.

Thanks for your attention to this issue!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1408#issuecomment-724693300___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Is "not create a %_sourcedir / %_specdir" really necessary? (#1408)

[Panu Matilainen]

A temporary file name ending up in the package is of course not intentional.

There was a reason for the change and that hasn't gone anywhere. Source fetch 
is not a supported feature, really. It should've been removed long ago as it's 
totally insecure in the general case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1408#issuecomment-724690905___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Is "not create a %_sourcedir / %_specdir" really necessary? (#1408)

[David Nichols]

commit a55cb376fa9d9f785081fa13802edc3743a879ca also breaks `rpmbuild -ts` for 
me - it creates a source RPM with an invalid spec file name:
```
dnichols@manatee:~/src/qore/git/qore$ rpm -ql 
~/rpmbuild/SRPMS/qore-0.9.6-1.fc33.src.rpm 
qore-0.9.6.tar.bz2
rpm-tmp.xAdiY8
```

as the code to rename the temporary file `rpm-tmp.zAdiY8` in the output above) 
was removed in that commit - this of course breaks the SRPMS.

This is how the source RPM looked in f32:
```
dnichols@manatee:~/src/qore/git/qore$ rpm -ql 
~/rpmbuild/SRPMS/qore-0.9.6-1.fc32.src.rpm 
qore-0.9.6.tar.bz2
qore.spec
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1408#issuecomment-724681673___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

[Miro Hrončok]

Oh, I've been alerted by @torsava that my suggestions have been addressed. 
Nice, thanks! The code looks good to me. If the external tests still pass, 
let's ship it?

We can probably test this in Fedora before merging if we want more testing (but 
this is not necessary).

Thank you @s-t-e-v-e-n-k!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#issuecomment-724646250___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild logging tweaks (#1429)

[Michal Domonkos]

@dmnks pushed 1 commit.

5f79f49e1b331bef57c46303f7648280b36ee9e7  Add section for warnings to rpmbuild 
output


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1429/files/5f1f9520154fc8db66cf7de18d2d781055174968..5f79f49e1b331bef57c46303f7648280b36ee9e7
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Fix a minor memory leak on failed sqlite database open (RhBug:1896301) (#1430)

[Panu Matilainen]

Curiously, sqlite allocates resources that need freeing even in case
of failure to open. Quoting from https://www.sqlite.org/c3ref/open.html:

> Whether or not an error occurs when it is opened, resources associated
> with the database connection handle should be released by passing it to
> sqlite3_close() when it is no longer required.

I disagree, but as it's documented behavior there's no point filing a
bug. So lets close the non-open connection and chug on.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1430

-- Commit Summary --

  * Fix a minor memory leak on failed sqlite database open (RhBug:1896301)

-- File Changes --

M lib/backend/sqlite.c (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1430.patch
https://github.com/rpm-software-management/rpm/pull/1430.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1430
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] build/pack.c: build failure due to pragma omp task untied on codesourcery-mips toolchain (#1420)

[Michal Domonkos]

Correct, this is caused by the compiler not supporting some of the OpenMP 
features (it's actually the `priority` clause). We've added a check into the 
`configure` script recently to "fix" this: #1325

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1420#issuecomment-724555218___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint