Re: [Rpm-maint] [rpm-software-management/rpm] Unify builtin and user-defined parametric macro calling syntax (#1434)
The handling of "parse" type builtins is kind of weird. I would prefer to have the parsing outside of doExpandThisMacro() so that I can set args to [ "foo", "bar" ] and expand the %define macro to do a `%define foo bar` We only have 5 builtin macros that are "parse" type: define, global, undefine, dnl, dump So this doesn't matter much and splitting the parsing from the processing is probably not worth the hassle. (Btw, the parsing of the undefine and dump macros is quite weird.) With other words: Ok from my side. Feel free to ignore my ramblings ;-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1434#issuecomment-733977053___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Unify builtin and user-defined parametric macro calling syntax (#1434)
Updated for some subtle fixes and more testcases to showcase what's possible. If there are no further comments/objections I'll hit merge tomorrowish. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1434#issuecomment-733685936___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)
I did some testing in dnfdaemon and the patch is working for us. Just (as Panu mentioned) for consistency I'd like to change CompleteTransaction signal name to EndTransaction - the signal is emitted regardless the transaction was successful and "Complete" in the name suggests the success. I was also thinking whether the result of the transaction should be part of the signal but having rpmdb cookie is perfectly fine with us to decide whether there actually was any change. I suppose the plugin will be released as a separate sub-package so that the dnfdaemon could depend on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-733608943___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
