Re: [Rpm-maint] [rpm-software-management/rpm] Document thread-safety of librpm (#1483)

2021-01-28 Thread Demi Marie Obenour
> > Is it safe to fork() and then perform an RPM transaction in the child 
> > process, even if the parent was multithreaded?
> 
> It depends on so many factors I can't possibly answer such a question.

Does librpm use `pthread_atfork` to protect its locks, and do the libraries 
librpm depends on do so?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1483#issuecomment-769262942___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added fapolicyd plugin (#1475)

2021-01-28 Thread Radovan Sroka
> Excellent, thanks.
> 
> It's annoying how the GitHub interface tends to hide the commit message, 
> which is often just about as important as the code...

Totally agree...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1475#issuecomment-769140962___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added fapolicyd plugin (#1475)

2021-01-28 Thread Panu Matilainen
@pmatilai approved this pull request.

Excellent, thanks. 

It's annoying how the GitHub interface tends to hide the commit message, which 
is often just about as important as the code...



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1475#pullrequestreview-578394350___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added fapolicyd plugin (#1475)

2021-01-28 Thread Panu Matilainen
And thanks for the patch!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1475#issuecomment-769107872___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added fapolicyd plugin (#1475)

2021-01-28 Thread Panu Matilainen
Merged #1475 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1475#event-4261412716___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added fapolicyd plugin (#1475)

2021-01-28 Thread Radovan Sroka
> Okay, very nearly good to go, I was just about to hit merge before realizing 
> that the commit message is not at all the same as the PR description. Please 
> explain the use-case in the commit message: basically the PR description plus 
> a brief explanation of the issues involved and why this plugin is needed. The 
> history of that needs to be recorded in the commit message, not bugzilla/GH 
> discussions.

I added better commit message, I hope it is OK.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1475#issuecomment-769099890___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] zstd: use thread pool (#1466)

2021-01-28 Thread marxin
> Sorry but I can't see us accepting this. It's a layering violation, the build 
> code cannot have any special knowledge of what goes on inside librpmio and 
> vice versa.

Hm, that's a pity.

> 
> Rpm really needs a resource manager (see #804) ... which hopefully can 
> somehow integrate with these library-specific things as well.

Are you planning to work on the feature in near future?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1466#issuecomment-769075139___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] [WIP] Added fapolicyd plugin (#1475)

2021-01-28 Thread Panu Matilainen
Okay, very nearly good to go, I was just about to hit merge before realizing 
that the commit message is not at all the same as the PR description. Please 
explain the use-case in the commit message: basically the PR description plus a 
brief explanation of the issues involved and why this plugin is needed. The 
history of that needs to be recorded in the commit message, not bugzilla/GH 
discussions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1475#issuecomment-769058115___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] zstd: use thread pool (#1466)

2021-01-28 Thread Panu Matilainen
Closed #1466.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1466#event-4261098579___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] zstd: use thread pool (#1466)

2021-01-28 Thread Panu Matilainen
Sorry but I can't see us accepting this. It's a layering violation, the build 
code cannot have any special knowledge of what goes on inside librpmio and vice 
versa.

Rpm really needs a resource manager (see #804)  ... which hopefully can somehow 
integrate with these library-specific things as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1466#issuecomment-769054309___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] [WIP] Added fapolicyd plugin (#1475)

2021-01-28 Thread Radovan Sroka
@radosroka pushed 1 commit.

e34dbab3dcff2035ca8c0ba7a80e3454b1d429dc  Added fapolicyd plugin


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1475/files/9b36cd27e0442c3e8dd2eb391bed7aab237b7e90..e34dbab3dcff2035ca8c0ba7a80e3454b1d429dc
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] RFE: switch to override %config file behavior (#1522)

2021-01-28 Thread Panu Matilainen
For all the disabler switches in rpm, there's no way to disable %config file 
special handling. Various use-cases include, but probably not limited to:
- reinstall package to clean state
- when uninstalling something, you often want the configs gone too

Originally came up at https://bugzilla.redhat.com/show_bug.cgi?id=1921620

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1522___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document thread-safety of librpm (#1483)

2021-01-28 Thread Panu Matilainen
> Is it safe to fork() and then perform an RPM transaction in the child 
> process, even if the parent was multithreaded?

It depends on so many factors I can't possibly answer such a question.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1483#issuecomment-768862180___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document thread-safety of librpm (#1483)

2021-01-28 Thread Demi Marie Obenour
@cgwalters Nice!  I’m working on Rust bindings to a small part of the RPM API.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1483#issuecomment-768792220___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint