Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)
@pmatilai Personally, I'd also like a solution to an annoying case that I have on macOS where I have binaries with multiple architectures in them. What you're saying here could probably be expanded to handle that too, I suppose, since it essentially turns architectures into qualifiers for files/dependencies, and we support having multiple qualifiers per dependency already. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-828831503___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Introduce --add-arch (#1660)
Yep, I worked on #1038 to solve this and several other problems I was having in OpenMandriva. Alas, it's stuck for now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1660#issuecomment-828830358___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)
@yecril71pl pushed 1 commit. 160eff4a51aee381fb90ea9105064e6647cc706a EXTRA_DIST = README.md -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1662/files/b8020a01c8564def22139a09aa6f101cdf5e3760..160eff4a51aee381fb90ea9105064e6647cc706a ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)
Oh, and thanks for the patch! Your attention to details like this is appreciated! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1662#issuecomment-828468299___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)
Looks like the new file does not get automatically picked up by automake and needs to be added to `EXTRA_DIST` in `tests/Makefile.am`. Generally changes to the content (even if just rewording) and changing the format as a whole should be done in separate patches but it's not a big deal here. Feel free to keep as is. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1662#issuecomment-828467331___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Load plugin library symbols first (#1664)
@ffesti, i see what you mean, i will change it, thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1664#issuecomment-828442036___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Introduce --add-arch (#1660)
Wow, looks really similar indeed. It was a result of a specific local project and I didn't know about #1038, so let that be an indication that something like this would be _really_ welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1660#issuecomment-828411529___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Load plugin library symbols first (#1664)
I understand the issue of symbols of the plugin vs system symbols as both may be linked to different versions of a library or symbols may collide otherwise. I am just not quite sure how or if at all this relates to RTLD_LAZY vs RTLD_NOW. So while the change may be OK I wonder if the commit message is capturing the right reasons. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1664#issuecomment-828367725___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Load plugin library symbols first (#1664)
dlopen load plugins LIBRARY with RTLD_LAZY flag it means the symbols are loaded when references are executed so it causes issue when some references are the same than in system append RTLD_BINDDEEP allows to first load symbols from the plugin library You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1664 -- Commit Summary -- * Load plugin library symbols first -- File Changes -- M lib/rpmplugins.c (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1664.patch https://github.com/rpm-software-management/rpm/pull/1664.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1664 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Plugin library symbols are not loaded at first (#1663)
dlopen load plugins LIBRARY with RTLD_LAZY flag it means the symbols are loaded when references are executed so it causes issue when some references are the same than in system append RTLD_BINDDEEP allows to first load symbols from the plugin library -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1663___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Cross build macro confusion (#1650)
Oh and see also #103 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1650#issuecomment-828286671___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Macro file comment loading "regression" (#1659)
@mlschroe , I went ahead and created a PR from this with a testcase, hope you don't mind. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1659#issuecomment-828219498___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Ignore comment line contents in macro files (#1659) (#1661)
Previously %{ and similar in macro file comment line would cause the
line continuation logic to trigger and silently eat macro definitions
up to the next empty line. Since 75275a87cff04da65d3557f2c40ea2b526528c4c
we permit empty lines inside macro definitions, which would cause the
whole remaining file to be silently skipped (RhBug:1953910)
Only ever parse macro file lines starting with %, and add a test for
the case.
Actual patch by Michael Schroeder, testcase by undersigned.
Fixes: #1659
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1661
-- Commit Summary --
* Ignore comment line contents in macro files (#1659)
-- File Changes --
M rpmio/macro.c (8)
M tests/data/macros.testfile (7)
M tests/rpmmacro.at (17)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/1661.patch
https://github.com/rpm-software-management/rpm/pull/1661.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1661
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Macro file comment loading "regression" (#1659)
> No you wouldn't. Nobody expects contents of a #-commented line to affect > anything coming after it, it's just absurd. It's absurd in specs too as > indicated by the endless bugs and tickets filed on the behavior over the > years, but at least there we have an excuse or two, and other options (%dnl). Silently discarding everything after the comment is certainly wrong, but I agree that comment lines should not be parsed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1659#issuecomment-828200569___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Introduce --add-arch (#1660)
Just noting that there's significant overlap with #1038 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1660#issuecomment-828197620___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Macro file comment loading "regression" (#1659)
No you wouldn't. Nobody expects contents of a #-commented line to affect anything coming after it, it's just absurd. It's absurd in specs too as indicated by the endless bugs and tickets filed on the behavior over the years, but at least there we have an excuse or two, and other options (%dnl). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1659#issuecomment-828166642___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
