Re: [Rpm-maint] [rpm-software-management/rpm] Set git commit dates based on $SOURCE_DATE_EPOCH (PR #2930)

2024-03-14 Thread Clemens Lang
> > Theoretically you could just ensure that the RPM signature uses the same > > `SOURCE_DATE_EPOCH` timestamp rather than the current time > > I generally assume that the private key used for signing is not available to > the rebuilder. If it _is_ available, the whole signature isn't worth

Re: [Rpm-maint] [rpm-software-management/rpm] Deprecate Lua posix.fork() and posix.exec() (Issue #2420)

2024-03-14 Thread Florian Festi
Closed #2420 as completed via #2948. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2420#event-12119110443 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Document fork, exec, wait and redirect2null Lua functions as deprecated (PR #2948)

2024-03-14 Thread Florian Festi
Merged #2948 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2948#event-12119110094 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Document fork, exec, wait and redirect2null Lua functions as deprecated (PR #2948)

2024-03-14 Thread Panu Matilainen
Added note about the removal schedule, and noisy deprecation warnings on every use to go. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2948#issuecomment-1997552547 You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] Indentation support for tags (Issue #2927)

2024-03-14 Thread Florian Festi
Added some docs so you can find out things like that. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2927#issuecomment-1997521895 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Indentation support for tags (Issue #2927)

2024-03-14 Thread Panu Matilainen
Closed #2927 as completed via #2957. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2927#event-12118649260 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Allow whitespace before directives in the Preamble (PR #2957)

2024-03-14 Thread Panu Matilainen
Merged #2957 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2957#event-12118648892 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Allow whitespace before directives in the Preamble (PR #2957)

2024-03-14 Thread Panu Matilainen
Works for me... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2957#issuecomment-1997491688 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] Allow whitespace before directives in the Preamble (PR #2957)

2024-03-14 Thread Florian Festi
Added a sentence about the white space and a paragraph about Spec sections in general -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2957#issuecomment-1997469329 You are receiving this because you are subscribed to this thread. Message

[Rpm-maint] [rpm-software-management/rpm] rpm2cpio writes non-compliant cpio archives (Issue #2974)

2024-03-14 Thread Michael Schroeder
With the newc format, the content of hardlinked files is supposted to be stored with the last hardlink. This is different from tar, where the content is stored with the first entry. rpm2archive always stores the content with the first hardlink. This does not seem to matter in practice, as both

Re: [Rpm-maint] [rpm-software-management/rpm] RPM v6 package generation rough-cut (PR #2920)

2024-03-14 Thread Panu Matilainen
I suppose this preview has served its purpose, I'll rebase + reopen once 4.20 has been branched. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2920#issuecomment-1997419535 You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] RPM v6 package generation rough-cut (PR #2920)

2024-03-14 Thread Panu Matilainen
Closed #2920. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2920#event-12118034163 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Introduce an rpm-controlled per-build directory (PR #2885)

2024-03-14 Thread Panu Matilainen
@pmatilai commented on this pull request. > - goto exit; - } - if (rstreq(buildRoot, "/")) { - rpmlog(RPMLOG_ERR, _("%%{buildroot} can not be \"/\"\n")); - goto exit; + if (!spec->buildDir) { + /* Grab top builddir on first entry as we'll

Re: [Rpm-maint] [rpm-software-management/rpm] Allow whitespace before directives in the Preamble (PR #2957)

2024-03-14 Thread Panu Matilainen
The patch itself looks nice and simple enough. So, assuming we're going to do this, the docs could use an update. Although I'm not sure the old behavior is documented anywhere, but it'd be good to state the behavior explicitly. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Introduce an rpm-controlled per-build directory (PR #2885)

2024-03-14 Thread ニール・ゴンパ
@Conan-Kudo commented on this pull request. > - goto exit; - } - if (rstreq(buildRoot, "/")) { - rpmlog(RPMLOG_ERR, _("%%{buildroot} can not be \"/\"\n")); - goto exit; + if (!spec->buildDir) { + /* Grab top builddir on first entry as

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Florian Festi
Merged #2956 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956#event-12117552701 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Panu Matilainen
Rebased to get the ASLR workaround. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956#issuecomment-1997344064 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
Closed #2971. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971#event-12117453447 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Work around ASAN incompatibility with GH runner image >= 20240310.1.0 (PR #2973)

2024-03-14 Thread Florian Festi
Merged #2973 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2973#event-12117439747 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: introduce an rpm-controlled per-build directory to builds (Issue #2078)

2024-03-14 Thread Florian Festi
Closed #2078 as completed via #2885. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2078#event-12117426864 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Introduce an rpm-controlled per-build directory (PR #2885)

2024-03-14 Thread Florian Festi
Merged #2885 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2885#event-12117426581 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Work around ASAN incompatibility with GH runner image >= 20240310.1.0 (PR #2973)

2024-03-14 Thread Panu Matilainen
Some of our Python tests started suddenly failing semi-consistently, this turned out to be an issue in the most recent GH runner image kernel where ADSL runs with more entropy than before, and this clashes with ASAN. Revert the runner VM to the former values to fix for now. Oh and dont think I

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 1 commit. 8249dcd8c0b3b2e223c977f4aad3649458f1f29d Magic voodoo -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971/files/3ae6194dc379fd767efb7da84e65d954e12f3cd6..8249dcd8c0b3b2e223c977f4aad3649458f1f29d You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 1 commit. 3ae6194dc379fd767efb7da84e65d954e12f3cd6 Magic voodoo -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971/files/e58280e2415d25ee043231986b5c195c46ebb115..3ae6194dc379fd767efb7da84e65d954e12f3cd6 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-14 Thread Michael Schroeder
In this case archive_write_header() returns ARCHIVE_WARN, which is treated as error in rpm2archive. OTOH I don't think libarchive should mess with the file names, maybe it makes sense to set the hdrcharset to `BINARY` for pax. But that adds a "hdrcharset=BINARY" attribute that GNU tar complains

[Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-14 Thread Michael Schroeder
It fails because it want to convert the filenames to utf8: $ echo $LC_CTYPE de_DE@euro $ rpm2archive /usr/src/packages/RPMS/x86_64/empty-3.0.0-1.x86_64.rpm > /dev/null Error writing archive: Can't translate pathname './fooöo' to UTF-8 (84) -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 1 commit. 31011ed54344dfa393681587fe5e26a3fc2d8cab Disable ubsan -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971/files/2ffd6a23c8d3ea771eaecb2f398348affd5970d3..31011ed54344dfa393681587fe5e26a3fc2d8cab You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 1 commit. 2ffd6a23c8d3ea771eaecb2f398348affd5970d3 Disable Fedora updates repos on CI to chase mystery failures... -- View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
Reopened #2971. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971#event-12116135713 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
Closed #2971. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971#event-12116096275 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 0 commits. -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971/files/49cc97fad832dd033351da9282fe3460ba13cb1a..1c8443a2a828e959dc66749a6053204950d9c106 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 1 commit. f391218cef07a79f32c623babd0f362a85da8590 Updates needed for rpm-sequoia on Fedora 38 -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971/files/5f75109408a76ec2aba8790f22c8cb9556c7870b..f391218cef07a79f32c623babd0f362a85da8590 You are

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 1 commit. 5f75109408a76ec2aba8790f22c8cb9556c7870b Try with an older fedora.. -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2971/files/f57abad95f78e48d8f8cc5b99a7787c6650a4eab..5f75109408a76ec2aba8790f22c8cb9556c7870b You are receiving this because

[Rpm-maint] [rpm-software-management/rpm] Disable Fedora updates repos on CI to chase mystery failures... (PR #2971)

2024-03-14 Thread Panu Matilainen
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2971 -- Commit Summary -- * Disable Fedora updates repos on CI to chase mystery failures... -- File Changes -- M tests/Dockerfile.fedora (1) -- Patch Links --

Re: [Rpm-maint] [rpm-software-management/rpm] Only copy git tracked files into test image on `make ci` (Issue #2970)

2024-03-14 Thread Michal Domonkos
The `ADD` command can copy archives (and unpacks them also) so we might as well just do a `git archive` beforehand and copy that. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2970#issuecomment-1997061467 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Panu Matilainen
Okay, it now emits a debug message such as > D: required parametric macro %buildsystem_fubar_conf not defined buildsystem > fubar -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956#issuecomment-1997044375 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 3 commits. 729a5f1cf52c5129771ab1f1164c9926174ca0bb Validate Buildsystem definitions, error out on unknown 1854bdee7e14d7c4058780fdad16449326af553f Fix more Buildsystem related leaks, sigh ac76406a39a6dabd09d071eecb4c8ddcc92a550c Drop manual macro invocation from the

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Panu Matilainen
Yup, it's something I considered. I can certainly add some debug-level message to help, well, debug when writing these things. I just want the user oriented message to be clear and straight to the point, mumbling about missing sections in that message easily leads you to think this was a user

[Rpm-maint] [rpm-software-management/rpm] Only copy git tracked files into test image (Issue #2970)

2024-03-14 Thread Michal Domonkos
While the "canonical" `_build` subdirectory in the source tree is [ignored](https://github.com/rpm-software-management/rpm/blob/master/.dockerignore) when copying the sources into the OCI image, there may be other directories and/or files and some of them may cause issues when copying them

Re: [Rpm-maint] [rpm-software-management/rpm] Issue a warning when passing arguments to non-parametric macros (PR #2940)

2024-03-14 Thread Florian Festi
Merged #2940 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2940#event-12115204610 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Build fails silently when gawk is missing (Issue #2926)

2024-03-14 Thread Florian Festi
Closed #2926 as completed via 78fd1fc05f50dec9c5f2b8618591568bc910. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2926#event-12114810356 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Awk detection fixes, volume II (PR #2966)

2024-03-14 Thread Florian Festi
Merged #2966 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2966#event-12114809657 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Florian Festi
I wonder if the error message should mention the missing section. The error message is fine for packagers if the build systems are all there already but it is not that helpful if one tries to write one. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for Toolbox integration to mktree.oci (PR #2830)

2024-03-14 Thread Michal Domonkos
Closing for now, I'll open an actual PR when ready. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2830#issuecomment-1996896069 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for Toolbox integration to mktree.oci (PR #2830)

2024-03-14 Thread Michal Domonkos
Closed #2830. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2830#event-12114599493 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild sometimes is killed by SIGPIPE with bad dependency generator sciptlets (Issue #2949)

2024-03-14 Thread Florian Festi
Closed #2949 as completed via #2958. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2949#event-12114555311 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Fix dependency generators sometimes dying with SIGPIPE (PR #2958)

2024-03-14 Thread Florian Festi
Merged #2958 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2958#event-12114555004 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint