Re: [Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2021-01-06 Thread KOLANICH
1. Lua is a terrible choice of a programming language IMHO (at least dealing 
with encodings in it used to be nightmare, though IDK how is it now). Some 
embedded JS engine may be better.
2. If to implement something in lua, one can ask why not to implement 
everything in lua? Replacing a C++ parser with Lua one opens a can of worms in 
the sense of thinking about which can and which cannot.
3. Kaitai Struct may be helpful if you wanna write a parser in lua (or in C++, 
JS, or Rust). Disclaimer: I'm involved into this project. Parsers generated by 
it are considered to be memory safe (in the sense they are gejerated 
au6omatically, not handcodedby humans, but I am not very sure in it since I 
don't remember any audit, I feel like integer overflows can be the main source 
of memory unsafety).


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1306#issuecomment-755709738___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-12-26 Thread KOLANICH
@DemiMari, is there any reason to use your lib instead of sequoia?

>We can always detect at compile-time if the Rust library is available, and 
>fall back to the built-in parser if it is not.

In runtime. By creating an abstraction layer, detecting the available libs and 
then prioritizing more secure OpenPGP impls over less secure. I have something 
like that for python (but curently it doesn't prioritize).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1306#issuecomment-751317806___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-12-23 Thread KOLANICH
@KOLANICH pushed 1 commit.

2174e5386a289355201aa60c43d767d1e244a3ab  Added a high-level wrapper.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311/files/4b26cf1bbfc9fbcdea7c6e4ac7d6b06c9b496d48..2174e5386a289355201aa60c43d767d1e244a3ab
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-12-23 Thread KOLANICH
@KOLANICH pushed 1 commit.

4abe3c7796da4c96ccb24d3c31f849cfa86e4e79  Improved python support: enums are 
now enums with all additional goodies. Can usually be available using 
CamelCased prefix, class members have the prefix stripped.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309/files/c63584817f594e40e02bb31452906ab676456a36..4abe3c7796da4c96ccb24d3c31f849cfa86e4e79
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-12-11 Thread KOLANICH
@KOLANICH pushed 1 commit.

4b26cf1bbfc9fbcdea7c6e4ac7d6b06c9b496d48  Added a high-level wrapper.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311/files/278fec730baf775462391e74f71057c8eb8128ec..4b26cf1bbfc9fbcdea7c6e4ac7d6b06c9b496d48
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-12-11 Thread KOLANICH
@KOLANICH pushed 1 commit.

c63584817f594e40e02bb31452906ab676456a36  Improved python support: enums are 
now enums with all additional goodies. Can usually be available using 
CamelCased prefix, class members have the prefix stripped.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309/files/75f8d5dbeef1f95e9a069092945fbc4c6fc01a0f..c63584817f594e40e02bb31452906ab676456a36
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-11-23 Thread KOLANICH
@KOLANICH pushed 1 commit.

278fec730baf775462391e74f71057c8eb8128ec  Added a high-level wrapper.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311/files/4aaacf8e0c7831d5f91054554c87c4473431afa0..278fec730baf775462391e74f71057c8eb8128ec
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-11-23 Thread KOLANICH
@KOLANICH pushed 1 commit.

75f8d5dbeef1f95e9a069092945fbc4c6fc01a0f  Improved python support: enums are 
now enums with all additional goodies. Can usually be available using 
CamelCased prefix, class members have the prefix stripped.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309/files/b6d604758b295ef8cb6b8c18c44f1d4bd7be1654..75f8d5dbeef1f95e9a069092945fbc4c6fc01a0f
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-10-21 Thread KOLANICH
@KOLANICH pushed 1 commit.

702e756046855d51541c0cf59541cd0a02120e3e  Improved python support: enums are 
now enums with all additional goodies. Can usually be available using 
CamelCased prefix, class members have the prefix stripped.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309/files/ab8a88455919c191ab85bf5a4a3ab8261679185b..702e756046855d51541c0cf59541cd0a02120e3e
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-10-21 Thread KOLANICH
@KOLANICH pushed 1 commit.

f7fd783f8146f1e151296ba3659355dcb9943bcb  Added a high-level wrapper.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311/files/090ad798d700b4f166f19ec55e8120e0716e606d..f7fd783f8146f1e151296ba3659355dcb9943bcb
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-08-05 Thread KOLANICH
So we can't declutter and eliminate the duplication.

IMHO it makes no sense to make the cluttered enums into python enums because 
they are a bit faster, so the dev can decide what he needs more, convenience to 
debug or performance and can switch between them by using the appropriate ctors 
if needed. That's why I haven't converted the APIs implemented in python and 
returning the ints belonging to the enums.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309#issuecomment-669029978___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-08-05 Thread KOLANICH
1 Is there any reason to define the enums in C code instead of Python?
2 Should I move them into a python file and replace by pythonic enums then, 
breaking the compatibility in order to declutter the namespace?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309#issuecomment-669007632___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-08-04 Thread KOLANICH
1. What clutters the namespace is the enums values generated by swig, because 
they are not really python enums and they are not namespaced. IDK if we can 
just break compatibility and get rid of them. The proposed solution is to setup 
swig to place them into a separate module (is it possible?), and then import 
that module and convert it, and not explicitly expose it.

2. in some places, where we don't directly interface the cext, we can, by just 
wrapping the returned values into the enum ctor

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309#issuecomment-668671569___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)

2020-07-21 Thread KOLANICH
@KOLANICH pushed 1 commit.

17019255f7460814ab5b0a410eb4409c3e43459f  Improved errors handling.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1305/files/cca2767a41acb918828504ad03c5bdbbe64f639a..17019255f7460814ab5b0a410eb4409c3e43459f
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-21 Thread KOLANICH
@KOLANICH pushed 1 commit.

ab8a88455919c191ab85bf5a4a3ab8261679185b  Improved python support: enums are 
now enums with all additional goodies. Can usually be available using 
CamelCased prefix, class members have the prefix stripped.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309/files/ce5514692e86b1f556e96494882189405f8a5581..ab8a88455919c191ab85bf5a4a3ab8261679185b
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-21 Thread KOLANICH
@KOLANICH pushed 1 commit.

090ad798d700b4f166f19ec55e8120e0716e606d  Added a high-level wrapper.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311/files/b8ccc7cbbfce9c0005b8039aee4a7ec7c4d44cc8..090ad798d700b4f166f19ec55e8120e0716e606d
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-15 Thread KOLANICH
@KOLANICH pushed 1 commit.

b8ccc7cbbfce9c0005b8039aee4a7ec7c4d44cc8  Added a high-level wrapper.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311/files/8082ede9cc7222686f8466440b0d4c3df62fb45c..b8ccc7cbbfce9c0005b8039aee4a7ec7c4d44cc8
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-13 Thread KOLANICH
@pmatilai @Conan-Kudo  @ignatenkobrain 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-657635032___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-10 Thread KOLANICH
@KOLANICH pushed 1 commit.

ce5514692e86b1f556e96494882189405f8a5581  Improved python support: enums are 
now enums with all additional goodies. Can usually be available using 
CamelCased prefix, class members have the prefix stripped.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309/files/41310c6ffda99386b1e7f8354ebb542ffc310317..ce5514692e86b1f556e96494882189405f8a5581
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-10 Thread KOLANICH

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1311

-- Commit Summary --

  * Added a high-level wrapper.

-- File Changes --

A python/rpm/highLevel.py (38)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1311.patch
https://github.com/rpm-software-management/rpm/pull/1311.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread KOLANICH
Thank you.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1310#issuecomment-656726988___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-07-10 Thread KOLANICH
Supporting signatures (being able to read and process them) and non breaking in 
their presence, by just ignoring them, are very different things.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1306#issuecomment-656706547___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread KOLANICH


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1310___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-10 Thread KOLANICH
Can usually be available using CamelCased prefix, class members have the prefix 
stripped.

```python
import rpm
print(rpm.RPMBuild.CHECK | rpm.RPMBuild.CLEAN) # RPMBuild.CLEAN|CHECK: 
24
print(rpm.RPMBuild(24)) # RPMBuild.CLEAN|CHECK: 24
```
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1309

-- Commit Summary --

  * Improved python support: enums are now enums with all additional goodies. 
Can usually be available using CamelCased prefix, class members have the prefix 
stripped.

-- File Changes --

M python/rpm/__init__.py (2)
A python/rpm/rpmEnum.py (77)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1309.patch
https://github.com/rpm-software-management/rpm/pull/1309.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] librpm and its python bindings should give enough messages in order to debug problems in a black box fashion (#1307)

2020-07-09 Thread KOLANICH
librpm has very bad error messages implementation. It is really hard to 
determine what is going wrong. It should have more debug messags calls in 
strategical points - at least before every branch leading to returning failure.

error reporting in python bindings should be fixed too

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1307___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-07-09 Thread KOLANICH
Damn. I have wasted a lot of time today because of librpm almost silently jas 
refused to import a key.

Reproducer:

1. use #1305 to get the more detailed error message than just -1 on later stage 
(when the key is added)
2. 
```python
import requests
import rpm
suseKeyResp = 
requests.get("https://keyserver.ubuntu.com/pks/lookup?op=get=0x22C07BA534178CD02EFE22AAB88B2FD43DBDC284;)
suseKey = suseKeyResp.content
rpmKey = rpm.pubkey(suseKey)  # The parsing has not consumed the whole stream: 
pos = 7372, remaining = 5248
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1306___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)

2020-07-09 Thread KOLANICH
I was really hard to get that that I cannot import a key is just a bug in 
librpm and its python bindings. This PR makes it a bit more clear.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1305

-- Commit Summary --

  * Improved errors handling.

-- File Changes --

M python/rpmkeyring-py.c (2)
M rpmio/rpmpgp.c (11)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1305.patch
https://github.com/rpm-software-management/rpm/pull/1305.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1305
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Fix compilation on platforms without MAP_POPULATE (#985)

2020-01-14 Thread KOLANICH
Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/985#issuecomment-574158812___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2020-01-14 Thread KOLANICH
Thanks for merging it :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984#issuecomment-574159110___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2020-01-13 Thread KOLANICH
@KOLANICH pushed 1 commit.

9987dd701e3351e7e6304f7753fb6d6f0a7484e9  /scripts/check-rpaths: Do not use 
bashism. (DebBug:772404)


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984/files/6be64508deb6f79f9daa82f316e2fd13fac725f1..9987dd701e3351e7e6304f7753fb6d6f0a7484e9
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2020-01-10 Thread KOLANICH
@KOLANICH pushed 1 commit.

6be64508deb6f79f9daa82f316e2fd13fac725f1  /scripts/check-rpaths: Do not use 
bashism.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984/files/17645a87842f6f478d01bebf1c0c1e827e8db4c6..6be64508deb6f79f9daa82f316e2fd13fac725f1
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream Debian patches: Use the Debian standard (and safe) mechanism of generating temporary files. (#987)

2020-01-02 Thread KOLANICH
>Also it'd be good to have the original author mentioned - surely Debian has 
>package change history available somewhere?

It is stored in [the form of the 
patch](https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/tempfile.patch)
 in which it is written

>Description: Use the Debian standard (and safe) mechanism of generating 
>temporary files
>Author: Unknown

This metadata tags were added in 
https://salsa.debian.org/pkg-rpm-team/rpm/commit/9bc82bea6dc2af7f07c7dd5044d8cbe0c4ab4a2e#591d515b5331531e8f14b02280b3cb48e2bb72d2
 by @nijel.

That file was introduced in 
https://salsa.debian.org/pkg-rpm-team/rpm/commit/bb4e4de86405c3d1fb77c53a71c4fc84f6f83d48#7925069534c3fb9b5bf5c78b20291c070694a2da
 by @lool

then the description was added in 
https://salsa.debian.org/pkg-rpm-team/rpm/commit/5c1b5e3a67e2170c9e0898a16ccf57a4f4f9bac8#4c9800bfef626d61e9bd3915cec97b4e42ad0224
 by `Anand Kumria` (`wildf...@progsoc.org`, `wildf...@progsoc.uts.edu.au`, I 
haven't found any recent activity on GH by him, there are plenty of Anands 
Kumria on GitHub). Should we attribute the patch to him?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/987#issuecomment-570182748___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Fix compilation on platforms without MAP_POPULATE (#985)

2019-12-26 Thread KOLANICH
>I think this desserves some better commit message 

I have just preserved the message present in the patch. BTW, it LGTM. How do 
you propose to change it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/985#issuecomment-569055577___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2019-12-26 Thread KOLANICH
>it'll be a dead link if this is merged.

There is a backup on WebArchive now. We all know that if we see a dead link we 
should check WebArchive for it :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984#issuecomment-569055065___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Fix compilation on platforms without MAP_POPULATE (#985)

2019-12-26 Thread KOLANICH
@KOLANICH pushed 1 commit.

9ca1ac7b62bede14906359e3cd07a8d9069df29f  Fix compilation on platforms without 
MAP_POPULATE


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/985/files/152f3326ba895264da10e0904eaa529e59be77eb..9ca1ac7b62bede14906359e3cd07a8d9069df29f
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2019-12-26 Thread KOLANICH
@KOLANICH pushed 3 commits.

4c7323f69b4fddf928245e9db2d1c9ca9b277ef2  Fix building with no BerkeleyDB 
support
166c6c5a1e066bd485f3be98feb5935b1b050f3a  Move db_descr assignment from rpmdb 
to dbi
17645a87842f6f478d01bebf1c0c1e827e8db4c6  Do not use bashism for gettext


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984/files/3c297794a53a5a4a3cc13b183ad0323b830c7df9..17645a87842f6f478d01bebf1c0c1e827e8db4c6
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream Debian patches: Use the Debian standard (and safe) mechanism of generating temporary files. (#987)

2019-12-24 Thread KOLANICH
I am not the original author of the patch (and also in the patch metadata it is 
written that the author is unknown, but the maintainer says he doesn't remember 
any contributions whose author is unknown, the most likely the patch should be 
also attributed to him) but I guess that `tempfile` deals with the case when 
the file already exists. IDK though if `tempfile` is available in fedora.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/987#issuecomment-568808057___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Delete some crap after running autogen. (#986)

2019-12-24 Thread KOLANICH
Closed #986.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/986#event-2907357914___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream Debian patches: warning about non-native package manager (#989)

2019-12-24 Thread KOLANICH
Closed #989.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/989#event-2907356880___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2019-12-24 Thread KOLANICH
Even though the commit message looks like this (it have been inherited from the 
patch file) I don't see this patch removing any calls. I can guess that the 
most of the patch got missing (already merged?) but the text haven't been 
changed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984#issuecomment-568807431___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Verbose installplatform Just make installplatform to ease debugging problems with creatin platform files. (#988)

2019-12-24 Thread KOLANICH
Closed #988.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/988#event-2907351343___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Trying to upstream Debian patches: (#989)

2019-12-24 Thread KOLANICH
In Debian, rpm should be used to install packages, but rather as a tool to 
work with rpm packages or as a helper in alien. Because of this we protect 
complain, when user tries to install a package. This warning can be hidden by 
--force-debian.
Forwarded: http://rpm.org/ticket/79

https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/debian-disable-rpm.patch

Should I change the text to be suitable to other distros or you dont need 
the patches having nothing to do with fedora at all?
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/989

-- Commit Summary --

  * RPM is not default package manager on Debian

-- File Changes --

M configure.ac (2)
M lib/poptI.c (5)
M lib/rpmprob.h (1)
M rpm.c (8)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/989.patch
https://github.com/rpm-software-management/rpm/pull/989.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/989
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Verbose installplatform Just make installplatform to ease debugging problems with creatin platform files. (#988)

2019-12-24 Thread KOLANICH
…

https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/installplatform-verbose.patch
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/988

-- Commit Summary --

  * Verbose installplatform Just make installplatform to ease debugging 
problems with creatin platform files.

-- File Changes --

M installplatform (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/988.patch
https://github.com/rpm-software-management/rpm/pull/988.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/988
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Trying to upstream Debian patches: Use the Debian standard (and safe) mechanism of generating temporary files. (#987)

2019-12-24 Thread KOLANICH

From: 
https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/tempfile.patch
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/987

-- Commit Summary --

  * Use the Debian standard (and safe) mechanism of generating temporary files.

-- File Changes --

M scripts/vpkg-provides.sh (24)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/987.patch
https://github.com/rpm-software-management/rpm/pull/987.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/987
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Delete some crap after running autogen. (#986)

2019-12-24 Thread KOLANICH
https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/autogen-cleanup.patch
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/986

-- Commit Summary --

  * Delete some crap after running autogen.

-- File Changes --

M autogen.sh (24)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/986.patch
https://github.com/rpm-software-management/rpm/pull/986.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/986
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Fix compilation on platforms without MAP_POPULATE (#985)

2019-12-24 Thread KOLANICH
https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/map-populate.patch
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/985

-- Commit Summary --

  * Fix compilation on platforms without MAP_POPULATE

-- File Changes --

M tools/sepdebugcrcfix.c (6)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/985.patch
https://github.com/rpm-software-management/rpm/pull/985.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/985
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)

2019-12-24 Thread KOLANICH
There are no translations anyway...

https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/bashism.patch
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/984

-- Commit Summary --

  * Do not use bashism for gettext

-- File Changes --

M scripts/check-rpaths (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/984.patch
https://github.com/rpm-software-management/rpm/pull/984.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] ../rpmio/rpmlua.h:5:10: fatal error: lauxlib.h: No such file or directory (#888)

2019-10-10 Thread KOLANICH
Closed #888.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/888#event-2702699440___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] ../rpmio/rpmlua.h:5:10: fatal error: lauxlib.h: No such file or directory (#888)

2019-10-10 Thread KOLANICH
Thanks, it really fixes this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/888#issuecomment-540578117___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] ../rpmio/rpmlua.h:5:10: fatal error: lauxlib.h: No such file or directory (#888)

2019-10-08 Thread KOLANICH
@mlschroe, thanks. But the fix doesn't work. I don't mean that the patch cannot 
be applied, I have applied it manually. I mean I still get the same error.
1. if the conditional is present, `-I/usr/include/lua5.3`  is not added into 
the makefile
2. I have removed the conditional. Even though the makefile contains 
`-I/usr/include/lua5.3` I still get the error.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/888#issuecomment-539470535___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] ../rpmio/rpmlua.h:5:10: fatal error: lauxlib.h: No such file or directory (#888)

2019-10-08 Thread KOLANICH
>Where's lauxlib.h on the system? My crystal ball seems broken today.

```bash
pkg-config --cflags-only-I lua5.3
-I/usr/include/lua5.3
ls -l /usr/include/lua5.3
total 60
-rw-r--r-- 1 root root  8432 Nov 23  2015 lauxlib.h
-rw-r--r-- 1 root root 14833 May 30  2016 lua.h
-rw-r--r-- 1 root root   191 Dec 23  2004 lua.hpp
-rw-r--r-- 1 root root 21503 Apr  8  2019 luaconf.h
-rw-r--r-- 1 root root  1173 Feb  6  2014 lualib.h
```

As I have said, I have replaced `lua` with `lua5.3` in 
https://github.com/rpm-software-management/rpm/blob/master/configure.ac#L968 .



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/888#issuecomment-539428399___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Get rid of automake in favour of CMake or meson (#887)

2019-10-07 Thread KOLANICH
Because noone likes autotools.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/887#issuecomment-539030483___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] ../rpmio/rpmlua.h:5:10: fatal error: lauxlib.h: No such file or directory (#888)

2019-10-07 Thread KOLANICH
```
depbase=`echo parsePreamble.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H   -I.. -I.. 
-I../include/ -I../misc  -D_REENTRANT -Wall -Wpointer-arith 
-Wmissing-prototypes -Wstrict-prototypes  -fno-strict-aliasing 
-fstack-protector -Wempty-body -fopenmp -g -O2 -MT parsePreamble.lo -MD -MP -MF 
$depbase.Tpo -c -o parsePreamble.lo parsePreamble.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -DHAVE_CONFIG_H -I.. -I.. -I../include/ -I../misc 
-D_REENTRANT -Wall -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes 
-fno-strict-aliasing -fstack-protector -Wempty-body -fopenmp -g -O2 -MT 
parsePreamble.lo -MD -MP -MF .deps/parsePreamble.Tpo -c parsePreamble.c  -fPIC 
-DPIC -o .libs/parsePreamble.o
In file included from parsePreamble.c:15:
../rpmio/rpmlua.h:5:10: fatal error: lauxlib.h: No such file or directory
`

The distro is Ubuntu eoan, liblua5.3-dev is installed, `configure.ac` was 
modified to find it using pkg-config. The configure flags are: "--with-lua".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/888___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Get rid of automake in favour of CMake or meson (#887)

2019-10-07 Thread KOLANICH


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/887___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint