Merged #2561 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2561#event-9729519541
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
We're going to do some stuff before and after these macros in the next
commits/PRs so better do this beforehand.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2562
-- Commit Summary --
* Replace AT_CHECK and AT_CLEANUP wi
@dmnks pushed 47 commits.
996e0f679f2501d6251acee59bb6978177c5eafc Don't init plugins in Python tests
fa17a5c010e50af02b9cb8a92ab8a59342722055 Remove TOPDIR use from tests
4dd47a8083aa4d0ab713262ffa6dd974105e3b6f Ensure no rpmdb in no-db test
bd6ec28f5d0de868fea769b2120a827ab26c244b Remove red
@dmnks pushed 7 commits.
60008212558ff183a71dcd2b167329a56e7884fe Temporary fix for F37's
systemd-sysusers
fe76403cfe02059543755d53cf51a4c72317cdbf Contanerize python
db46fbe86ec4388756f05d64e623250e341887e7 Containerize run()
9f695d9353d4c94cb95275a3f432f594b86a8e3f Add --read-only
3b2287d42
Rebased onto the latest fixups.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1621561991
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm
We're touching this stuff in #2559 so make it nicer to work with :smile:
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2564
-- Commit Summary --
* Add vim modeline to atlocal.in
* Remove redundant runroot_other
* Capi
@dmnks commented on this pull request.
> @@ -1,3 +1,5 @@
+# vim:filetype=sh
OK, I'm actually thinking that maybe, just maybe, we could just add a proper
shebang here instead...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2564#pull
@dmnks pushed 5 commits.
7584b58253ee76ee583437b7be3d42f779869130 Add /bin/sh shebang to atlocal.in
e64902d59ad53356da5c27fd5af4733e4108555b Remove redundant runroot_other
cb080faf618ecccfec4af7b6d25c54899f9a1585 Capitalize our cmake vars in tests/
9e4d9ac91acfbab76c802c8fc39dc3227186c7d4 Clus
@dmnks commented on this pull request.
> @@ -1,3 +1,5 @@
+# vim:filetype=sh
Truly. Let's leave it out, there are ways to configure VIM to e.g. show
`atlocal` files as scripts, no big deal :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-managemen
@dmnks pushed 4 commits.
6cc91dbcc2f171ef598697330b6af76d363c1e7c Remove redundant runroot_other
3b386be3e0271f3a8c5160bcce3adec44d7d4e44 Capitalize our cmake vars in tests/
96abf87d6ab8082fbc2c38846c016451ba216367 Cluster add_custom_*() calls together
34a9122b2517a17962e7f5ebffd04c45bfa6587c
Merged #2564 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2564#event-9732034714
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Various minor fixes and enhancements, primarily driven by the preparation work
for #2559.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2565
-- Commit Summary --
* Fix WITH_CAP check in tests
* Don't depend on %__cc fro
@dmnks pushed 3 commits.
5461e3fef69820b6604677c2c80da15d782bb6aa De-duplicate the long command in
rundebug()
778b2df2a00c0d83c61711c1cd8201e467340194 Wrap fakechroot in new sandbox
function
b7187f4f704d239cde012071ba6c85812473e616 Break the long run() commands into
lines
--
View it on Git
@dmnks pushed 7 commits.
313595a22a7fffe4fefaaf3eeda97a83f5db22f1 Find required test programs in tests/
cmake file
4bf569ac5ddce642159e0b2cc08b4776d6cc3b30 Drop test-related *dir vars from cmake
29879070470b018f70d9b1d8748678f7710db194 Drop redundant atconfig
58c6b3b0c1973e65635992bc56c57cecec
Fair point, I'll move that stuff out.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1623144334
You are receiving this because you are subscribed to this thread.
Message ID: _
OK, I'll try it out later and if it helps, we can revert it I guess.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1623348746
You are receiving this because you are subscribed to this thread.
Message ID: __
Just FTR, I have a
[simplified](https://github.com/dmnks/rpm/tree/iss1580-wip-simpler) version of
this branch prepared and now
[rebasing](https://github.com/dmnks/rpm/tree/iss1580-wip-v2) it. I'll push it
here when it's ready.
--
Reply to this email directly or view it on GitHub:
https://gith
This is the final batch before #2559.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2568
-- Commit Summary --
* Add sandbox exec command
* Remove needless HOME override in tests
* Add RPMTREE variable to tests
* Rena
@dmnks commented on this pull request.
> @@ -27,7 +29,7 @@ else
exit
fi
-RPMTEST="@CMAKE_CURRENT_BINARY_DIR@/testing"
+RPMTEST=$RPMTREE
Ugh, you're right. Not that I wasn't aware, but I'm kinda sloppy when it comes
to quoting in my own changes. I just consider quotes too noisy to bothe
@dmnks commented on this pull request.
> RPM_CONFIGDIR=${RPMTEST}/@RPM_CONFIGDIR@
-export RPMTEST HOME RPM_CONFIGDIR
+export RPMTEST RPM_CONFIGDIR
Oh-oh, again, you're right. On one hand, we do override a bunch of paths like
`_topdir` in `run()` but you can never be su
@dmnks commented on this pull request.
> fi
}
function sandbox()
{
-(unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-)
+local cmd=$1
+shift
+case $cmd in
+exec)
+(unset RPM_CONFIG
@dmnks pushed 5 commits.
4413f80ea0afe002db3a01e4845d909ba2822c58 Add RPMTREE variable to tests
f31b62e83ac0179d2cf05df369ebf44dbc9b88c5 Rename testing/ to tree/ in tests
b5d2af4d740a35edf9fb09d0aa0f6d9c10cfbc3a Turn populate into mktree
ea3981134bf71b84040c7acc6beb4866a483ffdd Create the SOUR
Fixed up. Other quote inconsistencies are left for later :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2568#issuecomment-1624915013
You are receiving this because you are subscribed to this thread.
Message ID: _
@dmnks commented on this pull request.
> fi
}
function sandbox()
{
-(unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-)
+local cmd=$1
+shift
+case $cmd in
+exec)
+(unset RPM_CONFIG
@dmnks commented on this pull request.
> fi
}
function sandbox()
{
-(unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-)
+local cmd=$1
+shift
+case $cmd in
+exec)
+(unset RPM_CONFIG
Despite the original claim of volume III being the last one, here's one
another :smile: Just to keep things flowing.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2570
-- Commit Summary --
* Add sandbox mount command
*
@dmnks pushed 3 commits.
ebbda3d41dfa876bb60e1ea82efbe33b837d52fb Actually ensure no rpmdb in "no
rpmdb" test
47acf07be8309f7492d79daf1afc7cdf01464202 Silence awk if no RPM_CONFIGDIR in
atlocal
ba798a1146aabd6103558195f6071c626ed3f86a Replace fakechroot with bwrap
--
View it on GitHub:
http
OK, pushed a semi-final version of this branch. Please note the CI will now
fail since there's no podman/docker backend yet. That's in progress now :grin:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1625318978
You a
> That final "Replace fakechroot with bwrap" commit could use a little more
> elaborate commit message though. Like a brief description of the setup this
> creates smile
Yup, on the todo list above :laughing:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-softwar
@dmnks pushed 6 commits.
27331917eb4366a10869427f811bc605752c7e88 Actually ensure no rpmdb in "no
rpmdb" test
dbbc4e9811f7ce7a846b76ad9fb8c16ffbe0d82b Silence awk if no RPM_CONFIGDIR in
atlocal
994d1b0abe19ea14407b5848b7125ba463fa1692 Replace fakechroot with bwrap
643431462fc6588f8c834679604c
@dmnks pushed 4 commits.
222538da27e5edc686b7a06e97c3290fb0581eb9 Replace fakechroot with bwrap
e0f5f8fca9e7d765728f9c739a534c63e6cf70d7 Drop ci/ directory, move Dockerfile
to tests/
c9308144d95136fb67ebbb3c1989fd0589a1d971 Turn Dockerfile into a standalone RPM
image
bf813ab28be029683ac35c6de
@dmnks pushed 4 commits.
f9b9e0e116ad1d13b65b4064f7382a3b132a791e Replace fakechroot with bwrap
a02c68989f0d1741772fab9730fced67ae4dc89a Drop ci/ directory, move Dockerfile
to tests/
bf0e8bfb5710330d2b22b3033cbfa88a3f5dea52 Turn Dockerfile into a standalone RPM
image
58a1e437fc1a3447b4ac976f4
@dmnks pushed 1 commit.
2ded022a696838f7b6c1ce7fe7174d22777e8a75 Add podman backend
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559/files/58a1e437fc1a3447b4ac976f43a10adc39c069b1..2ded022a696838f7b6c1ce7fe7174d22777e8a75
You are receiving this because you are subs
@dmnks pushed 14 commits.
264e3fd338153d623d9f56d1659f7132585ffd37 Rename .output -> .check
51b9ceec3d764e395a96dec1b2b7109546785dbf MVP mktree
e87ecf85e3566a060ad5be08a7dd84ee134eb799 Add env cmd
40056bb43b4348c187f74463a68f3f8262b7ca40 Add RPM_CONFIGDIR_PATH
afbc727365b5604886111d4c0e3dea4bf
@dmnks pushed 13 commits.
f514cba0080a9f3cd5054102cdfddfa7107c5b28 MVP mktree
a9b2206697f572d861ac91b115f92ef5231b484f Add env cmd
18a10e7d347c5da6dcc88b90ce6fb84ee611174d Add RPM_CONFIGDIR_PATH
1c593ba4fdb0f109a54a1d200d0d348f4427f7d5 MVP bwrap
f9332e449eb93faba06ca5fe33c4e431107b63aa Cleare
@dmnks pushed 14 commits.
4a5d0014c0c3a7e62eeed33347a7bd0098dc3b74 MVP mktree
aee1113fe3dac38832e83c0d4258d1ee71883f25 Add env cmd
ce9e62fb4fa50f8887e8bba561a188781eb30c60 Add .mktree.env
db9edac6547fc63a2267e5e65b5b89b633d575b3 Add RPM_CONFIGDIR_PATH
e1a9fbd440fbd835ae6ca1f9c70e582145a74d23
@dmnks pushed 1 commit.
a411270af569c8aacd6fdc8bb74c452351472b10 Add podman backend
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559/files/69d58a69a24e5fc62a6ddb3ff6012ceb598c34ad..a411270af569c8aacd6fdc8bb74c452351472b10
You are receiving this because you are subs
Bubblewrap (bwrap) is used here to create fast, ephemeral per-test containers
(*snapshots*) of the root filesystem. This replaces the former use of
fakechroot. The whole test suite (the `rpmtests` script) assumes that the RPM
build to be tested is installed into the root filesystem.
That means,
Since I already started describing the new architecture, here's a perhaps
simpler outline of how it works now (`mktree` is wired into the `make`):
1) `mktree build`
* builds a base OS tree
* builds RPM natively and make installs it into the base OS tree
2) `mktree check`
* runs `rpmtests` i
> Darwin has `chroot()` like all POSIX systems. I'm not sure if `fakechroot`
> works on Darwin, but [`fakeroot`](https://salsa.debian.org/clint/fakeroot) is
> supposed to work on macOS and is [available via
> homebrew](https://formulae.brew.sh/formula/fakeroot).
>
> Darwin also has the sandbox
Oh, so you do have a fakechroot build (in that VM) that works fine with the
test suite, correct?
I mean, it's not a huge program with a lot of dependencies anyway (and
`chroot()`, which AFAIK is used underneath, is a POSIX function, as you said),
so it's probably easier to port than a full cont
> Oh, so you do have a fakechroot build (in that VM) that works fine with the
> test suite, correct?
Nah, disregard that, you just confirmed that in your reply:
> but [fakeroot](https://salsa.debian.org/clint/fakeroot) is supposed to work
> on macOS and is [available via
> homebrew](https://fo
Anyway, the timing of your question was just right as I had been contemplating
just about the same thing, i.e. whether to decouple the test suite *completely*
from the sandboxing method used or make bwrap hardwired. (It's also one of the
reasons this PR is *still* not merged, sigh.)
This is a u
> At that point, adding a legacy backend using fakechroot (or just chroot
> perhaps) would be a possibility and while I won't make any promises, I
> _might_ look at that later.
Hmm, I totally forgot that `chroot` alone wouldn't suffice, the system would
also need to have something like overlayf
LGTM, feel free to merge if you're done.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2575#issuecomment-1638124163
You are receiving this because you are subscribed to this thread.
Message ID: __
Merged #2575 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2575#event-9838074822
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
@dmnks pushed 24 commits.
de6156ae7d12ecea1feff9eaaed60e5b36f92d70 Silence awk if no RPM_CONFIGDIR in
atlocal
344a908aea39ff70043f4c25fee8aac6969e0e02 Refactor mktree
9a14319af22073a8673d4e758b4e085c3c3ac077 Rename sandbox() to snapshot()
8db3e440dbe87655262c8df3d26c5edf67de86bb Use $RPMTEST
@dmnks pushed 1 commit.
6d1f811969303a894d9f57a0777a9813409adb23 Add mktree.podman backend
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559/files/4f4d4e93dcd77d466ab395463a340897c7aca1d1..6d1f811969303a894d9f57a0777a9813409adb23
You are receiving this because you a
@dmnks pushed 1 commit.
1c23ff53cd33d04703e636e8058f4d14eee2d03c Add mktree.podman backend
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559/files/ab81ed980c2ef353f0ea1a1da71754e4d3963fc2..1c23ff53cd33d04703e636e8058f4d14eee2d03c
You are receiving this because you a
Alright, let's get this done now.
The commits should now be fairly self-contained and I also removed some bits in
the final version of this PR that were just premature generalization on my part
(e.g. [this
comment](https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1633719443
Merged #2559 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#event-9914809711
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Closed #1580 as completed via 03126a17b403d4b92996a6ce001ab34f85b75979.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1580#event-9914810080
You are receiving this because you are subscribed to this thread.
Message ID:
___
FYI, the test-suite PR #2559 has been merged so you can rebase now.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573#issuecomment-1650300905
You are receiving this because you are subscribed to this thread.
Message ID: ___
This ensures no single test can (accidentally or intentionally) alter the
shared tree and influence the subsequent tests.
This also makes us comply with the following OverlayFS requirement which could
otherwise be violated when running parallel tests:
Changes to the underlying filesystems w
Merged #2583 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2583#event-9915782137
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Now that the script has the `bash` shebang, shouldn't we make use of `local`
and declare the function-local variables as such? Currently, they are all
redefined on entry and not used outside of the functions, but if we change
something in the script in the future and forget about it...
--
Repl
Other than the above, the PR looks sane, nice work!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573#issuecomment-1651444355
You are receiving this because you are subscribed to this thread.
Message ID: ___
@dmnks approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2573#pullrequestreview-1547356492
You are receiving this because you are subscribed to this thread.
Message ID: ___
@dmnks commented on this pull request.
> @@ -470,11 +470,13 @@ static rpmdbMatchIterator initQueryIterator(QVA_t qva,
> rpmts ts, const char * ar
if (mi == NULL) {
struct stat sb;
- if (lstat(fn, &sb) != 0)
+ char * full_fn = rpmGenPath(rpmtsRootDir(ts)
Don't make any assumptions about how other Linux distros would need to
implement the mktree interface. We simply don't know how much logic could
be shared between such native backends before some are actually written.
Right now, we only have one such backend, for Fedora, that's a sample size
t
Merged #2589 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2589#event-9949198936
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2591
-- Commit Summary --
* Disable systemd-inhibit in mktree.fedora
* Minimize the package set in mktree.fedora
-- File Changes --
M tests/mktree.fedora (14)
-- Patc
Since commit 2bdd7d7cbd77b13abf512bb919abe7f0537a2c45, we no longer test the
`systemd-sysusers(8)` implementation shipped by systemd. This also minimizes
the test tree quite a bit since we no longer have to pull in the whole of
systemd.
However, in the CI, we might, just to have that use case c
Merged #2591 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2591#event-9963362591
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2593
-- Commit Summary --
* Add back Docker support to CMake
* Remove forgotten ENABLE_CI cmake option
-- File Changes --
M CMakeLists.txt (4)
M INSTALL (2)
M
Merged #2593 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2593#event-9974244039
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
We actually do need this library in the test tree, in case the build is
configured with -DWITH_IMAEVM=ON which links librpmsign to it, it's not a
plugin. We already include libfsverity for the same reason.
This is a fixup for commit 4c41faf7a592a5bb484cf7d645cc247d850d776a.
You can view, commen
Merged #2594 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2594#event-9974801884
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2595
-- Commit Summary --
* Add pgpVerifySignature2() and pgpPrtParams2()
* Remove second share/ dir from infodir and mandir
* Fix bzip2 detection
* Test for the variabl
Oops, wrong target branch.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2595#issuecomment-1660319730
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-main
Closed #2595.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2595#event-9976634559
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
Rpm-
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2596
-- Commit Summary --
* Bump CI to Fedora 38
* Use CMake Lua module
* Fix leftover "lua.h" import from days long gone
* Make the higher level file info selection fla
Merged #2596 into rpm-4.19.x.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2596#event-9976732942
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint m
/4.19.0
--
Michal Domonkos / RPM dev team / Red Hat, Inc.
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
This is a feature-complete pre-release with a number of bug fixes since ALPHA2.
Highlights include:
* New `sysusers.sh` script as a drop-in replacement for `systemd-sysusers(8)`
* New `%{specpartsdir}` macro for configuring the spec snippet location
* New `%{rpmversion}` macro for obtaining the r
Tweaked version of #2588 by @Conan-Kudo.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2598
-- Commit Summary --
* Add support for --interactive in mktree.podman
* CI: Add initial GitHub Actions configuration
-- File Ch
Closed #2588.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2588#event-592824
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
Rpm-
Thanks! Turns out to be easier than I thought :smile:
As for the `-i` mode, we still want that, ideally as the default, since the
script has to also work when run interactively on the developer's workstation,
either through `make check` when there's no "native" backend available
(currently any
Merged #2598 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2598#event-618588
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint maili
Closed #2569 as completed via d4cad0f26aec183e9eb4f42533b91b30c0c04e80.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2569#event-619292
You are receiving this because you are subscribed to this thread.
Message ID:
___
Thanks everyone for the input! We went with GH Actions in the end (#2598).
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2569#issuecomment-1664091203
You are receiving this because you are subscribed to this thread.
Message ID: __
Indeed, I did notice this myself too but didn't follow up on it before merging.
No reason for v2 as far as I'm aware. I'll bump this to v3, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/commit/d4cad0f26aec183e9eb4f42533b91b30c0c04e80
This should've been part of the previous commit, just got forgotten.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2599
-- Commit Summary --
* Bump actions/checkout from v2 to latest (v3)
-- File Changes --
M .github
Merged #2599 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2599#event-1214635
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
I've also changed the *required* check to be the newly added GH workflow
instead of SemaphoreCI.
This has resulted in all the open PRs to be stuck on "Waiting for status to be
reported", due to those branches not being rebased on top of master and thus
missing a workflow file. That means the re
One more note: I'll keep the SemaphoreCI check in place for a little while,
just to have something to compare to in case of any unexpected failures in the
new GH workflow.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2569#issuecomme
What's common between the previous SemaphoreCI setup and the current GH Actions
one is that we 1) run in an Ubuntu VM (18.04 -> 22.04) and 2) we run in a
Docker container. My guess would be the latter (Docker) causing this but we yet
have to figure it out :smile:
--
Reply to this email direct
Then there's the intermittent failure with bwrap's mounting table parsing that
we discussed in the chat. I'm thinking we should have a Known issues sections
somewhere (in the tests/README perhaps) listing these. I'll probably add that
later.
--
Reply to this email directly or view it on GitHub
Please see the commit messages for details.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2610
-- Commit Summary --
* Support common mktree.fedora image in build dirs
* Simplify BYPRODUCTS in "make tree"
* Clean up dnf
Add a bit more text to `tests/README.md` about the new test-suite layout from
#2559 and while at it, write a short howto on test writing, too. A file
describing the mktree interface (`mktree.README`) may also be helpful.
--
Reply to this email directly or view it on GitHub:
https://github.com/r
@dmnks pushed 3 commits.
1c94ddb065e2e9625e0d8ab0f1efde6a4042459c Support common mktree.fedora image in
build dirs
5c5b6e44cbf48f9cbe21ee6c0b630ecad11cb014 Simplify BYPRODUCTS in "make tree"
0ea0c0fa09573152ea389735e18b96f822dd69a5 Clean up dnf() function in "make env"
--
View it on GitHub:
Hmm, maybe just storing the image in `~/.local/share/...` would make things
simpler than traversing git worktrees. We only need one per system, after all.
Also, we might as well just use the user-specific DNF cachedir in
`/var/tmp/dnf*`.
I'll fix this. Converting to draft in the meantime.
--
... except that would leave all kinds of data around the filesystem, which is
not nice. We want to keep all test-related data contained within the RPM
checkout if possible. Also, we'd have to come up with some kind directory name
to put under `~/.local/share/` (`containers` is already taken by p
OK, slept on it, let's go with the original approach, i.e. commit
1c94ddb065e2e9625e0d8ab0f1efde6a4042459c. It's better to just keep things tidy.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2610#issuecomment-1674380853
You are receivi
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2618
-- Commit Summary --
* Set standard, consistent HOME path in tests
* Point RPM to correct database in Dockerfile
* Terminate stray bwrap processes on test failures
@dmnks pushed 2 commits.
0355b0626c0109aea6080059e249715757ffd814 Export the same DNF command-line in
"make env"
f387fe501382cceb0d1110574f37c1b33154c2e7 Enable DNS resolution in "make shell"
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2618/files/9d565570e06fa5b0
@dmnks pushed 4 commits.
edb63c4f9efa69a653722f8e25648db2dff77024 Extend the MOTD in "make env" with a
bit more info
e23300a8c2c7e481761a3b75ea5e7f0fd9a8adab Export the same DNF command-line in
"make env"
40ffe79b0e1fd51a2d4a8de98b50f267c5633f55 Enable DNS resolution in "make shell"
c4917c1af
@dmnks pushed 3 commits.
dc80aabc166b6a43a0f2fa5053c23ce8c19d01be Move exit trap to a function in
mktree.fedora
852c7c2ec9632321e62c99dbb1cfe9e8feb6b990 Prevent build dir from becoming
annoyingly sticky
89399a75968e5d611ac9311612812d2dbaedf731 Avoid warning about double --chdir in
"make chec
Merged #2618 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2618#event-10121373976
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
There's a good movie with a similar motive:
https://www.imdb.com/title/tt1375666/
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2638#issuecomment-1700875853
You are receiving this because you are subscribed to this thread.
Message ID:
801 - 900 of 1192 matches
Mail list logo
