Saur2000 requested changes on this pull request.
I cannot find a way to leave review comments for the commit messages using
GitHub, but you should change "say rpm or dnf" to "rpm or dnf" (or "e.g.
rpm or dnf") in the "Optimize rpmSetCloseOnExec" commit. You should also change
"when running
Saur2000 approved this pull request.
Looks good to me. Thanks for the work.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Saur2000 requested changes on this pull request.
> + struct dirent *entry;
+ while ((entry = readdir(dir)) != NULL) {
+ fd = atoi(entry->d_name);
+ if (fd >= min_fd)
+ set_cloexec(fd);
+ }
+ closedir(dir);
+
+ return;
I have updated the change now to hopefully be more in line with what you had in
mind.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
\*ping*
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/220#issuecomment-303698411___
Rpm-maint mailing list
Yes, there is code in OE-core that needs to run `rpmdeps` directly. What it
needs is a way to get the dependencies per input file. I.e., when it runs a
command such as `rpmdeps --all-per-file lib/libuuid.so.1.3.0 usr/bin/uuidgen`,
it needs the filename, the dependency types and the names of the
This is an alternative solution to the part in
https://github.com/rpm-software-management/rpm/pull/216 that was rejected.
Rather than changing the behavior of the existing `--rpmfcdebug` option, this
adds a new option `--all-per-file`, which outputs the same information as
`--rpmfcdebug` does,
Would it be an alternative to add a new option to `rpmdeps` that outputs the
result from `rpmfcPrint()` to stdout? Since in my case, that output is all that
I need. I am working on fixing a regression in OpenEmbedded that was introduced
with the switch to dnf and rpm4 in the latest release
The first commit fixes the use of an uninitialized buffer in rpmdeps and should
be trivial to merge.
The second commit changes `rpmdeps --rpmfcdebug` to output to stdout. This
makes more sense when using it as the sole output from rpmdeps, as the output
will no longer mix with any warnings
