[Rpm-maint] [rpm-software-management/rpm] Add -f to %_default_patch_flags (#1513)

2021-01-22 Thread Florian Festi
This prevents the patch utility to ask questions during builds. See man patch for details Resolves: #978 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1513 -- Commit Summary -- * Add -f to %_default_patch_flags -- File

Re: [Rpm-maint] [rpm-software-management/rpm] Rename %apply_patch to make it clearer it's an internal thing (#1357) (#1512)

2021-01-22 Thread Florian Festi
Merged #1512 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1512#event-4238663562___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Make use of %apply_patch easier (#1357)

2021-01-22 Thread Florian Festi
Closed #1357. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1357#event-4238625057___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Make use of %apply_patch easier (#1357)

2021-01-22 Thread Florian Festi
Not sure if it really worth changing anything here. Adding underscores won't really improve much. As this hasn't happened yet I'll just close this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: issue with debug info stipping procedure (#1362)

2021-01-22 Thread Florian Festi
OK, this is an packaging issue then. Closing here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] 4.15.1: issue with debug info stipping procedure (#1362)

2021-01-22 Thread Florian Festi
Closed #1362. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1362#event-4238564060___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Support failing build on duplicate files (#1158) (#1506)

2021-01-22 Thread Florian Festi
Merged #1506 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1506#event-4238440179___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %_duplicate_files_terminate_build (#1158)

2021-01-22 Thread Florian Festi
Closed #1158 via #1506. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1158#event-4238440185___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add deltarpm support (#433)

2021-01-22 Thread Florian Festi
Doesn't look like this is happing any time soon. Closing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add deltarpm support (#433)

2021-01-22 Thread Florian Festi
Closed #433. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/433#event-4238262506___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: ensure all %(...) system-wide macros don't pollute stderr (#424)

2021-01-22 Thread Florian Festi
Closed #424. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/424#event-4238257257___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: ensure all %(...) system-wide macros don't pollute stderr (#424)

2021-01-22 Thread Florian Festi
The proper solutions is to have these kind of macros split out into separate packages that have dependencies on the tools they are using/probing. This has already be done for Python and a few others. Closing this ticket. Please open new ones for cases that still need work. -- You are

Re: [Rpm-maint] [rpm-software-management/rpm] --keep-cr for %_scm_apply_git_am() (#102)

2021-01-22 Thread Florian Festi
Closed #102. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/102#event-4238194345___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] --keep-cr for %_scm_apply_git_am() (#102)

2021-01-22 Thread Florian Festi
Not really sure if changing the behaviour and possible fall out is worth the added convenience. As this topic hasn't come up since may be there are not enough use cases to justify this. Closing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [Rpm-maint] [rpm-software-management/rpm] Translations update from Weblate (#1432)

2021-01-19 Thread Florian Festi
Merged #1432 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1432#event-4222151859___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Document dependency qualifiers (#1089)

2021-01-19 Thread Florian Festi
Closed #1089 via #1508. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1089#event-4221981517___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Document dependency qualifiers (#1089) (#1508)

2021-01-19 Thread Florian Festi
Merged #1508 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1508#event-4221981506___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Document dependency qualifiers (#1089) (#1508)

2021-01-19 Thread Florian Festi
Looks good over all. May be there should be a more explicit emphasis that no qualifier (other than `meta`) is the "strongest" dependency as it does not allow the package to be removed. The only way to combine this with other qualifiers is to have two separate dependency statements. -- You are

Re: [Rpm-maint] [rpm-software-management/rpm] Fix out of bounds read when parsing the xz thread number (#1509)

2021-01-19 Thread Florian Festi
Nice catch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1509#issuecomment-762702723___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix out of bounds read when parsing the xz thread number (#1509)

2021-01-19 Thread Florian Festi
Merged #1509 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1509#event-4221436905___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2021-01-19 Thread Florian Festi
@ffesti pushed 3 commits. b7b472b3e4ff284e260a581749c6fb30f24f38cc Parse spec snippets before running %check 3e4d486e415f603b2403eae7faa8a5325eedf39e Use __rpmbuild_*.specpart in BUILDDIR instead of __rpm sub dir ce3c6e97be69c6febcd3fd2f6424099eb8e7bdd2 Add support for

[Rpm-maint] [rpm-software-management/rpm] rpm2archive: Better error handling and better handling for URLs (#1510)

2021-01-18 Thread Florian Festi
Resolves #1091 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1510 -- Commit Summary -- * rpm2archive: Remove unneccesarity parameter * rpm2archive: Add more error handling * rpm2archive: Use last part of URL as file

Re: [Rpm-maint] [rpm-software-management/rpm] rpm --rebuilddb outputs error on NFS (#796)

2021-01-15 Thread Florian Festi
Closed #796. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/796#event-4211366063___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] rpm --rebuilddb outputs error on NFS (#796)

2021-01-15 Thread Florian Festi
Fix by 38c03ddb18e86c84d89af695f72442d8365eb64e -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/796#issuecomment-760968106___

Re: [Rpm-maint] [rpm-software-management/rpm] Size check is too strict (#1232)

2021-01-15 Thread Florian Festi
We are not looking deeper into this. Closing as I don't really see anything wrong with rpm's behaviour. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Size check is too strict (#1232)

2021-01-15 Thread Florian Festi
Closed #1232. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1232#event-4211188833___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] option to disable fsync (#1401)

2021-01-15 Thread Florian Festi
Closed #1401. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1401#event-4210989545___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] option to disable fsync (#1401)

2021-01-15 Thread Florian Festi
Yes, we are really not that keen on (re-) adding nofsync support. There is some optimization in there for new installations which are run with only one SQLite transaction for the whole thing but that's as far as we really want to go with that. -- You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Remove RedHat from HOWTO (#1474)

2021-01-15 Thread Florian Festi
Closed #1474. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1474#event-4210888578___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Remove RedHat from HOWTO (#1474)

2021-01-15 Thread Florian Festi
This talks about users interacting with the rpm cli and advices them to use dnf as the higher level tool. This has nothing to do with the distribution still being based on rpm or not. Closing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2021-01-15 Thread Florian Festi
> Is there a reason we can't just push it back into `rpmbuild` itself directly? > Like perhaps by exposing something via Lua that lets you programmatically > define binary packages? Yes, we could. I have thinking about this quite a lot. But this is much more complicated and harder to use.

Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2021-01-14 Thread Florian Festi
> Do I understand it correctly that you'd essentially do a `my_spec_generator > > %_builddir/__rpm/subpac.spec` which would e.g. contain a new subpackage > definition? Basically yes. As this is run in the %build or %install section you would need to modify your spec generator to not output

Re: [Rpm-maint] [rpm-software-management/rpm] RPMv6 proposal: Detached signatures (#1482)

2021-01-14 Thread Florian Festi
There is a middle way how to deal with signatures: Append at the end of the package. RPM should probably dictate a way how they should be separated. Then one could just read the last few kB of the package and check for signatures there without understanding the rpm format at all. You could also

Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2021-01-12 Thread Florian Festi
@ffesti pushed 1 commit. 89402a09e08d19c93cbd800e7ba53814f0c90aac Remove stupid warning -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2021-01-12 Thread Florian Festi
This is an alternative to #1239 Instead of extending the spec syntax with dynamic elements allow the build process to generate their own spec file snippets that get read in after executing `%build` (technically after `%check`) from `$BUILDDIR/__rpm/*.spec`. This allows tricks like generating

Re: [Rpm-maint] [rpm-software-management/rpm] Translations update from Weblate (#1356)

2020-10-13 Thread Florian Festi
Merged #1356 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1356#event-3871084254___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Tag documentation updates (#1387)

2020-10-13 Thread Florian Festi
Merged #1387 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1387#event-3871056091___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Unexpected behavior when using -q --queryformat in %pre scriplet (#1331)

2020-08-13 Thread Florian Festi
Closed #1331. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1331#event-3652419234___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Unexpected behavior when using -q --queryformat in %pre scriplet (#1331)

2020-08-13 Thread Florian Festi
`%{VERSION}` is replaced within the spec file itself. You need to use `%%{VERSION}` to avoid expanding the macro right away. As you already said this is probably a really bad idea anyway. RPM actually does backup modified config files on it's own if they are tagged as config files in the

Re: [Rpm-maint] [rpm-software-management/rpm] Work around buggy signature region preventing resigning (RhBug:1851508) (#1330)

2020-08-13 Thread Florian Festi
Merged #1330 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1330#event-3652177653___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-08-11 Thread Florian Festi
Closed #1301 via #1328. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1301#event-3641565661___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix changelog trimming to work relative to newest existing entry (#1301) (#1328)

2020-08-11 Thread Florian Festi
Merged #1328 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1328#event-3641565651___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] how to cross compile fedora source rpm for RISC-V architecture (#1327)

2020-08-07 Thread Florian Festi
Closed #1327. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1327#event-3633734263___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] how to cross compile fedora source rpm for RISC-V architecture (#1327)

2020-08-07 Thread Florian Festi
This is the ticket system for rpm development and not a support forum. General question on using rpm can go on the rpm mailing list or the #rpm.org IRC channel. See http://rpm.org/community.html for details. About your question: Bootstrapping a distribution like Fedora is a non trivial task

Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-08-07 Thread Florian Festi
Well, there's not really a way to fix the behaviour of _changelog_trimtime. We could amend it to keep a minimum number of entries even if they are older. If we want to keep entries based on a time frame we basically need a new macro. This of course raises the question of how these features

Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-08-04 Thread Florian Festi
Guess _changelog_trimtime should be counted from the newest entry to prevent the changelog depending on the build time. This still limits the changelog to the same length when building a new release but is stable over time and rebuilds. -- You are receiving this because you are subscribed to

Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Fix missing relocation of .debug_types section. (#1323)

2020-07-31 Thread Florian Festi
Mark can you have a look at this, please? Thanks! Florian On 7/29/20 11:32 PM, Jan Kratochvil wrote: > There is a new testcase: |debugedit .debug_types exe| > > > > > You can view, comment on, or merge

Re: [Rpm-maint] [rpm-software-management/rpm] Enable thread autodetection for a parallel compression. (#1324)

2020-07-31 Thread Florian Festi
Thanks for the patch. Unfortunately auto-detecting the number of threads is a more complicated topic and any solution for zstd needs to have a look at the larger picture. We added support for building multiple package in parallel, so the threads need to be split between those concurrent runs.

Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
Merged #1318 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#event-3603597053___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-30 Thread Florian Festi
Closed #963 via 28b3704034a9c772959485a130b918f414da9796. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
Thanks for all the work and polishing! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#issuecomment-666335786___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Please that `rpmbuild -ba` includes `-br + -bb`, not `-bs + -bb` (#1304)

2020-07-30 Thread Florian Festi
Closed #1304 via aa5bcb0a4e05667d8298cc008f6d9ee876681dde. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
@ffesti approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1318#pullrequestreview-458353180___

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1320#issuecomment-666329463___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
Merged #1320 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1320#event-3603542624___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
In general I am not a fan of hiding issues this way and would prefer such issues would be found and fixed. Otoh we are so far away from Python upstream that this may just be the pragmatic thing to do. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-30 Thread Florian Festi
Sorry, this took a bit longer than it should have, Thanks for your work and patience! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-30 Thread Florian Festi
Merged #1303 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1303#event-3603495856___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-29 Thread Florian Festi
Looks like it fails to detect the right commit to checkout and build. Can you force push a new version, please, to test if that get's it unstuck? Just do some white space changes to the commit message. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-27 Thread Florian Festi
Looks like there's a hick-up in the CI. Re-running the semaphore tests. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] packageBinaries compile error when building rpm-4.16.0-beta3 from source (#1315)

2020-07-22 Thread Florian Festi
This might be an issue with the omp support in the version of gcc. We might need to add checks for the omp version supported or at least document the version we require in the INSTALL file. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-21 Thread Florian Festi
OK, but there is an argument to be made that this should also work for just opening an rpm package without looking at the payload and instead just accessing the header. Which makes me wonder if we really need this to be context manager. -- You are receiving this because you are subscribed to

Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-21 Thread Florian Festi
> We should also consider _what_ the high level interface should offer. Well, that's not what this PR is about. This "only" is about making it easier to open an rpm package from disk and reading the payload. We don't really plan to offer a new API for all other functionality. -- You are

Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-21 Thread Florian Festi
I really like the idea of offering some easier to use API and using an context manager for that. But there are several aspects of this implementation that don't quite feel right to me. At first I wonder if we can find a better name for the class. This actually wraps (binary) packages. Not sure

Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-21 Thread Florian Festi
Looks like the new Python file was not added to `EXTRA_DIST = rpm/__init__.py rpm/transaction.py` in `python/Makefile.am` and though failing the CI. The "Modification of dictionary returned by locals()" warning can be avoided by just using globals() which always returns the module name space.

Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)

2020-07-21 Thread Florian Festi
I am not 100% sure if the new warnings are really better than the previous situation. There are pretty clear error messages for both cases. The added warnings only create confusion and have details that won't help most users. For the second test case it even obscures the actual error message.

Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)

2020-07-21 Thread Florian Festi
This change "breaks" two test cases which may need adjusting. ``` 239: rpmkeys -Kv 1FAILED (rpmsigdig.at:310) +++ /srv/rpm/rpm-4.16.90/_build/sub/tests/rpmtests.dir/at-groups/239/stderr 2020-07-21 07:50:18.680411000 + @@ -0,0 +1 @@ +warning: pgpPrtParams: The parsing

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-21 Thread Florian Festi
We need to make sure that the result with the current settings (non threaded compression) remains unchanged to not break deltarpm that way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Remove compare of global array tagsByName to NULL (#1312)

2020-07-21 Thread Florian Festi
Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1312#issuecomment-661684957___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Remove compare of global array tagsByName to NULL (#1312)

2020-07-21 Thread Florian Festi
Merged #1312 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1312#event-3569656455___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] Always close libelf handle (#1313)

2020-07-20 Thread Florian Festi
Otherwise executables that are not proper elf files are leaking libelf handles. This results in file being left open (mmaped) and fails the build on NFS as those files cant be deleted properly there. Resolves: rhbz#1840728 See also: https://bugzilla.redhat.com/show_bug.cgi?id=1840728 You can

Re: [Rpm-maint] [rpm-software-management/rpm] Size check is too strict (#1232)

2020-07-10 Thread Florian Festi
Double checking the code the unchanged files should not be counted when `%_minimize_writes` is enabled. So it obviously isn't in this test case. The question here is why the installation with `--ignoresize` passes without an error. I wonder if there is some trickery going on on the FS level to

Re: [Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread Florian Festi
The ticket system is not a help forum. Please ask questions like this on #rpm.org @freenode or on the mailing lists. See http://rpm.org/community.html for details. To the question at hand: There is an rpm.archive class. An instances can be obtained from an rpm.files object with the .archive()

Re: [Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread Florian Festi
Closed #1310. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1310#event-3534208073___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Question: multi-threaded zstd compression (#1300)

2020-07-10 Thread Florian Festi
As there now is a pull request (#1303) I am closing this ticket here. No need to distribute the discussion to multiple places. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Question: multi-threaded zstd compression (#1300)

2020-07-10 Thread Florian Festi
Closed #1300. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1300#event-3534156801___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Please that `rpmbuild -ba` includes `-br + -bb`, not `-bs + -bb` (#1304)

2020-07-10 Thread Florian Festi
Sorry, I am not quite understanding what you are suggesting here. My guess is you want that rpmbuild man page is more clear? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-07-10 Thread Florian Festi
Looking at the code I understand why this may go wrong but I have not yet found why it worked before and what changed. `rpm --specfile` is translated to `rpmspec -q`with popt aliases. By default rpmspec queries all generated sub packages. So I am kinda confused by you only get one line. Can

Re: [Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-07-10 Thread Florian Festi
Yes, this is a known - or not so well known - limitation. As the signature check is basically done by hand it lack a lot of feature one would expect of GPG proper. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Treat /usr/share/gnome/help as docs (#1295)

2020-07-10 Thread Florian Festi
Merged #1295 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1295#event-3534052702___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Treat /usr/share/gnome/help as docs (#1295)

2020-07-10 Thread Florian Festi
Let's hope that rpmlint is right... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1295#issuecomment-656695500___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-07-10 Thread Florian Festi
I don't see any need for further discussion here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-656689650___

Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-07-10 Thread Florian Festi
Merged #1272 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#event-3534004891___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix Doxygen comments (#1302)

2020-07-10 Thread Florian Festi
Thanks for the fix! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1302#issuecomment-656686843___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix Doxygen comments (#1302)

2020-07-10 Thread Florian Festi
Merged #1302 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1302#event-3533981732___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Adapt Python version marker workaround for setuptools 42+ (#1308)

2020-07-10 Thread Florian Festi
Looks straight forward to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1308#issuecomment-656685900___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Adapt Python version marker workaround for setuptools 42+ (#1308)

2020-07-10 Thread Florian Festi
Merged #1308 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1308#event-3533973211___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-10 Thread Florian Festi
This change looks good and straight forward. I am missing some information on what version of zstd supports the new API - and if necessary a check in configure.ac. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add RPMTRANS_FLAG_NOARTIFACTS symbol to Python bindings (#1293)

2020-06-26 Thread Florian Festi
Merged #1293 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1293#event-3486446227___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] RPM Translation subpackage(s) (#1276)

2020-06-22 Thread Florian Festi
> FWIW in openSUSE many packages have a "-lang" subpackage to contain all > translations. Those packages in turn have automated provides that translate > into a locale namespace for libsolv, eg. `rpm -q --provides bash-lang`: > > ``` > locale(bash:es) > ``` The (compared the to locale name

Re: [Rpm-maint] [rpm-software-management/rpm] RPM Translation subpackage(s) (#1276)

2020-06-22 Thread Florian Festi
> What are the main benefits over `%lang(zh)` besides making the downloaded > binary RPM smaller? Is the increase in rpm-md repo metadata size worth it? Well, there is a trade off depending on the situation. But the more different languages are supported and the bigger the number of translated

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup gpg-agent handling in test-suite (#1270)

2020-06-15 Thread Florian Festi
Merged #1270 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1270#event-3445622887___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)

2020-06-15 Thread Florian Festi
Wow! You now basically halved the time of the test suite takes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)

2020-06-15 Thread Florian Festi
Merged #1269 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1269#event-3443606399___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] %transfiletriggerin does not work on Fedora 33 (#1260)

2020-06-10 Thread Florian Festi
Closed #1260 via #1265. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1260#event-3428649168___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix completely broken prefix search on sqlite backend (#1265)

2020-06-10 Thread Florian Festi
Merged #1265 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1265#event-3428649150___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Fix completely broken prefix search on sqlite backend (#1265)

2020-06-10 Thread Florian Festi
Looks good. In my mind the prefix search is also bound to the index iteration. Probably because this is how it was introduced on bdb. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (32e2bc5)

2020-06-09 Thread Florian Festi
Yes, sure. This is a dependency as all the others and does support the same features. The only difference is that OrderWithRequires is ignored during the dependency check and only used for ordering. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (32e2bc5)

2020-06-09 Thread Florian Festi
*sigh* Fixed in #1263 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Fix tag mixup in 32e2bc50cff9db05729349ff6645a0251d5719fb (#1263)

2020-06-09 Thread Florian Festi
Hit merge just a little bit too quickly on this one... You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1263 -- Commit Summary -- * Fix tag mixup in 32e2bc50cff9db05729349ff6645a0251d5719fb -- File Changes -- M

  1   2   3   4   5   6   7   8   9   >