Re: [Rpm-maint] [rpm-software-management/rpm] Translations update from Weblate (#1356)

2020-10-13 Thread Florian Festi
Merged #1356 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1356#event-3871084254___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Tag documentation updates (#1387)

2020-10-13 Thread Florian Festi
Merged #1387 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1387#event-3871056091___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Unexpected behavior when using -q --queryformat in %pre scriplet (#1331)

2020-08-13 Thread Florian Festi
Closed #1331.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1331#event-3652419234___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Unexpected behavior when using -q --queryformat in %pre scriplet (#1331)

2020-08-13 Thread Florian Festi
`%{VERSION}` is replaced within the spec file itself. You need to use 
`%%{VERSION}` to avoid expanding the macro right away.
As you already said this is probably a really bad idea anyway. RPM actually 
does backup modified config files on it's own if they are tagged as config 
files in the package. Do things like this in a %pre script should not be 
necessary for all but very exotic cases.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1331#issuecomment-673521234___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Work around buggy signature region preventing resigning (RhBug:1851508) (#1330)

2020-08-13 Thread Florian Festi
Merged #1330 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1330#event-3652177653___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-08-11 Thread Florian Festi
Closed #1301 via #1328.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1301#event-3641565661___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix changelog trimming to work relative to newest existing entry (#1301) (#1328)

2020-08-11 Thread Florian Festi
Merged #1328 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1328#event-3641565651___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] how to cross compile fedora source rpm for RISC-V architecture (#1327)

2020-08-07 Thread Florian Festi
Closed #1327.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1327#event-3633734263___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] how to cross compile fedora source rpm for RISC-V architecture (#1327)

2020-08-07 Thread Florian Festi
This is the ticket system for rpm development and not a support forum. General 
question on using rpm can go on the rpm mailing list or the #rpm.org IRC 
channel. See  http://rpm.org/community.html for details.

About your question: Bootstrapping a distribution like Fedora is a non trivial 
task that involved lots of Fedora specific things. Some packages need to be 
build by hand with a crosscompiler or on another operating system. Some 
packages may require multiple rebuilds with different dependencies available. 
You are therefore probabably better of asking this question on the fedora-devel 
list. AKFAIK there is no longer a secondary arch group in Fedora still there 
should be a lot of people with actual experience from bootstrapping other 
architectures.

As we are concerned with developing rpm itself we here have very limited 
knowledge about the details of such process.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1327#issuecomment-670577005___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-08-07 Thread Florian Festi
Well, there's not really a way to fix the behaviour of _changelog_trimtime. We 
could amend it to keep a minimum number of entries even if they are older.
If we want to keep entries based on a time frame we basically need a new macro. 
This of course raises the question of how these features should interact. 
Probably keeping any entries that would be added by either of the macros...?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1301#issuecomment-670572581___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-08-04 Thread Florian Festi
Guess _changelog_trimtime should be counted from the newest entry to prevent 
the changelog depending on the build time. This still limits the changelog to 
the same length when building a new release but is stable over time and 
rebuilds.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1301#issuecomment-668448982___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: Fix missing relocation of .debug_types section. (#1323)

2020-07-31 Thread Florian Festi
Mark can you have a look at this, please?

Thanks!

Florian

On 7/29/20 11:32 PM, Jan Kratochvil wrote:
> There is a new testcase: |debugedit .debug_types exe|
> 
> 
> 
> 
> You can view, comment on, or merge this pull request online at:
> 
>   https://github.com/rpm-software-management/rpm/pull/1323
> 
> 
> Commit Summary
> 
>   * [NFC] debugedit: Reindent edit_dwarf2().
>   * debugedit: Fix missing relocation of .debug_types section.
> 
> 
> File Changes
> 
>   * *M* tests/data/SOURCES/foo.c
> 
> 
> (5)
>   * *M* tests/debugedit.at
> 
> 
> (26)
>   * *M* tools/debugedit.c
> 
> 
> (699)
> 
> 
> Patch Links:
> 
>   * https://github.com/rpm-software-management/rpm/pull/1323.patch
>   * https://github.com/rpm-software-management/rpm/pull/1323.diff
> 
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> , or
> unsubscribe
> .
> 
> 
> ___
> Rpm-maint mailing list
> Rpm-maint@lists.rpm.org
> http://lists.rpm.org/mailman/listinfo/rpm-maint
> 


-- 
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Laurie Krebs, Michael O'Neill,
Thomas Savage

___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Enable thread autodetection for a parallel compression. (#1324)

2020-07-31 Thread Florian Festi
Thanks for the patch. Unfortunately auto-detecting the number of threads is a 
more complicated topic and any solution for zstd needs to have a look at the 
larger picture. We added support for building multiple package in parallel, so 
the threads need to be split between those concurrent runs. While relying on 
`%{getncpus}` is probably the right thing to do, it does not yet contain a 
reliable enough value. There are some freaky architectures and machines out 
there that need better policies than just counting CPUs. Especially large 32 
bit machines (arm, z-series) that have a lot of CPUs can run out of address 
space pretty quickly.

I still think this patch is a good starting point but expect it to not go in 
until those other issues are ironed out.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1324#issuecomment-667092610___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
Merged #1318 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1318#event-3603597053___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-30 Thread Florian Festi
Closed #963 via 28b3704034a9c772959485a130b918f414da9796.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#event-3603597156___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
Thanks for all the work and polishing!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1318#issuecomment-666335786___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Please that `rpmbuild -ba` includes `-br + -bb`, not `-bs + -bb` (#1304)

2020-07-30 Thread Florian Festi
Closed #1304 via aa5bcb0a4e05667d8298cc008f6d9ee876681dde.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1304#event-3603597138___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
@ffesti approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1318#pullrequestreview-458353180___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
Thanks for the patch!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1320#issuecomment-666329463___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
Merged #1320 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1320#event-3603542624___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
In general I am not a fan of hiding issues this way and would prefer such 
issues would be found and fixed. Otoh we are so far away from Python upstream 
that this may just be the pragmatic thing to do.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1320#issuecomment-666329348___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-30 Thread Florian Festi
Sorry, this took a bit longer than it should have, Thanks for your work and 
patience!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#issuecomment-666324374___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-30 Thread Florian Festi
Merged #1303 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#event-3603495856___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-29 Thread Florian Festi
Looks like it fails to detect the right commit to checkout and build. Can you 
force push a new version, please, to test if that get's it unstuck? Just do 
some white space changes to the commit message.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#issuecomment-665638944___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-27 Thread Florian Festi
Looks like there's a hick-up in the CI. Re-running the semaphore tests.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#issuecomment-664171773___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] packageBinaries compile error when building rpm-4.16.0-beta3 from source (#1315)

2020-07-22 Thread Florian Festi
This might be an issue with the omp support in the version of gcc. We might 
need to add checks for the omp version supported or at least document the 
version we require in the INSTALL file.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1315#issuecomment-662493851___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-21 Thread Florian Festi
OK, but there is an argument to be made that this should also work for just 
opening an rpm package without looking at the payload and instead just 
accessing the header. Which makes me wonder if we really need this to be 
context manager.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661799300___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-21 Thread Florian Festi
> We should also consider _what_ the high level interface should offer.

Well, that's not what this PR is about. This "only" is about making it easier 
to open an rpm package from disk and reading the payload. We don't really plan 
to offer a new API for all other functionality.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661795382___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)

2020-07-21 Thread Florian Festi
I really like the idea of offering some easier to use API and using an context 
manager for that. But there are several aspects of this implementation that 
don't quite feel right to me.

At first I wonder if we can find a better name for the class. This actually 
wraps (binary) packages. Not sure if `Package` is too generic but it is much 
closer to the truth.

Abbreviating `archive` with `arch` is super confusing as `arch` is used 
everywhere else as synonym of `architecture`.

The fd used should really be stay hidden inside the class. Using it else where 
will only lead to tears and broken bones.

Not sure if `iterFiles` is really needed or if it is better to point to 
directly using the .archive attribute in the doc string. Or may be I am missing 
something here.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661792867___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)

2020-07-21 Thread Florian Festi
Looks like the new Python file was not added to `EXTRA_DIST = rpm/__init__.py 
rpm/transaction.py` in `python/Makefile.am` and though failing the CI.

The  "Modification of dictionary returned by locals()" warning can be avoided 
by just using globals() which always returns the module name space.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1309#issuecomment-661750550___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)

2020-07-21 Thread Florian Festi
I am not 100% sure if the new warnings are really better than the previous 
situation. There are pretty clear error messages for both cases. The added 
warnings only create confusion and have details that won't help most users. For 
the second test case it even obscures the actual error message.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1305#issuecomment-661743893___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)

2020-07-21 Thread Florian Festi
This change "breaks" two test cases which may need adjusting.
```
239: rpmkeys -Kv  1FAILED (rpmsigdig.at:310)
+++ /srv/rpm/rpm-4.16.90/_build/sub/tests/rpmtests.dir/at-groups/239/stderr 
2020-07-21 07:50:18.680411000 +

@@ -0,0 +1 @@

+warning: pgpPrtParams: The parsing has not consumed the whole stream: pos = 0, 
remaining = 287warning: pgpPrtParams: The parsing has not consumed the whole 
stream: pos = 0, remaining = 287

\ No newline at end of file
293: rpm -U  FAILED (rpmi.at:257)

+++ /srv/rpm/rpm-4.16.90/_build/sub/tests/rpmtests.dir/at-groups/293/stderr 
2020-07-21 07:50:24.356411000 +

@@ -1,3 +1,3 @@

-error: /tmp/hello-2.0-1.x86_64-signed.rpm: Header RSA signature: BAD (package 
tag 268: invalid OpenPGP signature)

+warning: pgpPrtParams: The parsing has not consumed the whole stream: pos = 0, 
remaining = 287error: /tmp/hello-2.0-1.x86_64-signed.rpm: Header RSA signature: 
BAD (package tag 268: invalid OpenPGP signature)

 error: /tmp/hello-2.0-1.x86_64-signed.rpm cannot be installed

293: rpm -U  FAILED (rpmi.at:257)


```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1305#issuecomment-661737794___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-21 Thread Florian Festi
We need to make sure that the result with the current settings (non threaded 
compression) remains unchanged to not break deltarpm that way.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#issuecomment-661689585___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Remove compare of global array tagsByName to NULL (#1312)

2020-07-21 Thread Florian Festi
Thanks for the patch!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1312#issuecomment-661684957___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Remove compare of global array tagsByName to NULL (#1312)

2020-07-21 Thread Florian Festi
Merged #1312 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1312#event-3569656455___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Always close libelf handle (#1313)

2020-07-20 Thread Florian Festi
Otherwise executables that are not proper elf files are leaking libelf
handles. This results in file being left open (mmaped) and fails the
build on NFS as those files cant be deleted properly there.

Resolves: rhbz#1840728
See also: https://bugzilla.redhat.com/show_bug.cgi?id=1840728
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1313

-- Commit Summary --

  * Always close libelf handle

-- File Changes --

M build/files.c (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1313.patch
https://github.com/rpm-software-management/rpm/pull/1313.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1313
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Size check is too strict (#1232)

2020-07-10 Thread Florian Festi
Double checking the code the unchanged files should not be counted when 
`%_minimize_writes` is enabled. So it obviously isn't in this test case.

The question here is why the installation with `--ignoresize` passes without an 
error. I wonder if there is some trickery going on on the FS level to not 
actually using all those blocks filled with zeros. From an rpm POV this should 
not work and rpm is expected to actually use twice as much space unless 
`%_minimize_writes` is enabled.

Not sure if this is really worth further exploring...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1232#issuecomment-656739157___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread Florian Festi
The ticket system is not a help forum. Please ask questions like this on 
#rpm.org @freenode or on the mailing lists. See http://rpm.org/community.html 
for details.
To the question at hand: There is an rpm.archive class. An instances can be 
obtained from an rpm.files object with the .archive() method. Some 
documentation on these classes can be found with `pydoc rpm`.
But to my knowledge this code has rarely been used - if ever. So there may be 
dragons... (like hard links - or worse)

Unless you have good reason consider using rpm2archive or rpm2cpio.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1310#issuecomment-656714319___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] How to unpack an rpm file into a dir using librpm python bindings? (#1310)

2020-07-10 Thread Florian Festi
Closed #1310.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1310#event-3534208073___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Question: multi-threaded zstd compression (#1300)

2020-07-10 Thread Florian Festi
As there now is a pull request (#1303) I am closing this ticket here. No need 
to distribute the discussion to multiple places.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1300#issuecomment-656708268___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Question: multi-threaded zstd compression (#1300)

2020-07-10 Thread Florian Festi
Closed #1300.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1300#event-3534156801___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Please that `rpmbuild -ba` includes `-br + -bb`, not `-bs + -bb` (#1304)

2020-07-10 Thread Florian Festi
Sorry, I am not quite understanding what you are suggesting here. My guess is 
you want that rpmbuild man page is more clear?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1304#issuecomment-656706082___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Can not parse CHANGELOGTEXT from the specfile (#1301)

2020-07-10 Thread Florian Festi
Looking at the code I understand why this may go wrong but I have not yet found 
why it worked before and what changed.

 `rpm --specfile` is translated to `rpmspec -q`with popt aliases. By default 
rpmspec queries all generated sub packages. So I am kinda confused by you only 
get one line. Can you try `rpm -q --qf "%{NAME} %{CHANGELOGTEXT}\n" --specfile 
"docpkg.spec"
`, please?

Also as CHANGELOGTEXT is an string array the correct usage would be 

`rpm -q --qf "[%{CHANGELOGTEXT}\n]" --specfile "docpkg.spec"`

but that still doesn't explain why this worked before.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1301#issuecomment-656703883___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cannot import a GPG key with signatures (#1306)

2020-07-10 Thread Florian Festi
Yes, this is a known - or not so well known - limitation. As the signature 
check is basically done by hand it lack a lot of feature one would expect of 
GPG proper.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1306#issuecomment-656698903___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Treat /usr/share/gnome/help as docs (#1295)

2020-07-10 Thread Florian Festi
Merged #1295 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1295#event-3534052702___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Treat /usr/share/gnome/help as docs (#1295)

2020-07-10 Thread Florian Festi
Let's hope that rpmlint is right...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1295#issuecomment-656695500___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-07-10 Thread Florian Festi
I don't see any need for further discussion here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-656689650___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)

2020-07-10 Thread Florian Festi
Merged #1272 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#event-3534004891___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix Doxygen comments (#1302)

2020-07-10 Thread Florian Festi
Thanks for the fix!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1302#issuecomment-656686843___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix Doxygen comments (#1302)

2020-07-10 Thread Florian Festi
Merged #1302 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1302#event-3533981732___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Adapt Python version marker workaround for setuptools 42+ (#1308)

2020-07-10 Thread Florian Festi
Looks straight forward to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1308#issuecomment-656685900___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Adapt Python version marker workaround for setuptools 42+ (#1308)

2020-07-10 Thread Florian Festi
Merged #1308 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1308#event-3533973211___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-10 Thread Florian Festi
This change looks good and straight forward.

I am missing some information on what version of zstd supports the new API - 
and if necessary a check in configure.ac.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#issuecomment-656683723___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add RPMTRANS_FLAG_NOARTIFACTS symbol to Python bindings (#1293)

2020-06-26 Thread Florian Festi
Merged #1293 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1293#event-3486446227___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RPM Translation subpackage(s) (#1276)

2020-06-22 Thread Florian Festi
> FWIW in openSUSE many packages have a "-lang" subpackage to contain all 
> translations. Those packages in turn have automated provides that translate 
> into a locale namespace for libsolv, eg. `rpm -q --provides bash-lang`:
> 
> ```
> locale(bash:es)
> ```
The (compared the to locale name space) new boolean dependencies were designed 
to be able to also cover this use case. They are not quite as sleek but a more 
general solution. So yes, we are kinda copying the SuSE solution here.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1276#issuecomment-647546081___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RPM Translation subpackage(s) (#1276)

2020-06-22 Thread Florian Festi
> What are the main benefits over `%lang(zh)` besides making the downloaded 
> binary RPM smaller? Is the increase in rpm-md repo metadata size worth it?

Well, there is a trade off depending on the situation. But the more different 
languages are supported and the bigger the number of translated strings is the 
more it is worth packaging translation separately.

Having this process automated we could even pick the right style of packaging 
depending on translation sizes. Or different distributions could choose their 
own policy.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1276#issuecomment-647543340___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Cleanup gpg-agent handling in test-suite (#1270)

2020-06-15 Thread Florian Festi
Merged #1270 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1270#event-3445622887___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)

2020-06-15 Thread Florian Festi
Wow! You now basically halved the time of the test suite takes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1269#issuecomment-644031870___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Testsuite cleanup (#1269)

2020-06-15 Thread Florian Festi
Merged #1269 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1269#event-3443606399___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] %transfiletriggerin does not work on Fedora 33 (#1260)

2020-06-10 Thread Florian Festi
Closed #1260 via #1265.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1260#event-3428649168___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix completely broken prefix search on sqlite backend (#1265)

2020-06-10 Thread Florian Festi
Merged #1265 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1265#event-3428649150___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix completely broken prefix search on sqlite backend (#1265)

2020-06-10 Thread Florian Festi
Looks good. In my mind the prefix search is also bound to the index iteration. 
Probably because this is how it was introduced on bdb.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1265#issuecomment-641862934___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (32e2bc5)

2020-06-09 Thread Florian Festi
Yes, sure. This is a dependency as all the others and does support the same 
features. The only difference is that OrderWithRequires is ignored during the 
dependency check and only used for ordering.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/commit/32e2bc50cff9db05729349ff6645a0251d5719fb#commitcomment-39776284___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (32e2bc5)

2020-06-09 Thread Florian Festi
*sigh* Fixed in #1263


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/commit/32e2bc50cff9db05729349ff6645a0251d5719fb#commitcomment-39775202___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Fix tag mixup in 32e2bc50cff9db05729349ff6645a0251d5719fb (#1263)

2020-06-09 Thread Florian Festi
Hit merge just a little bit too quickly on this one...
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1263

-- Commit Summary --

  * Fix tag mixup in 32e2bc50cff9db05729349ff6645a0251d5719fb

-- File Changes --

M build/rpmfc.c (4)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1263.patch
https://github.com/rpm-software-management/rpm/pull/1263.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1263
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-09 Thread Florian Festi
This is indeed not possible. The argument here is (except that it is simply not 
implemented) that those dependencies are generated from files in the package 
and not the scriptlets. So qualifiers should not be needed. But I am pretty 
sure people could come up with some valid use cases.

There is https://github.com/rpm-software-management/rpm/projects/11 There are 
quite a few things that I would like to see improved with dependency generators 
in the 4.17, 4.18 time frame.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1257#issuecomment-641227025___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-09 Thread Florian Festi
Yes, not having a dependency generator for OrderWithRequires is clearly an 
oversight. Details on what generators are a valid use case are not relevant 
here.

Thanks for the patch!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1257#issuecomment-641202025___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add OrderWithRequires dependency generation (#1257)

2020-06-09 Thread Florian Festi
Merged #1257 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1257#event-3424224260___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for dependency generators for RPMTAG_ORDERNAME (#1262)

2020-06-09 Thread Florian Festi
Closed #1262.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1262#event-3424205732___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for dependency generators for RPMTAG_ORDERNAME (#1262)

2020-06-09 Thread Florian Festi
*arg* I didn't even realize #1257 is a PR with a patch attached already. Please 
disregard.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1262#issuecomment-641199701___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fail the build if %_build_pkgcheck_set failed (#1258)

2020-06-09 Thread Florian Festi
Looks good to me. Should probably also go into 4.16.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1258#issuecomment-641198193___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-09 Thread Florian Festi
> Is there any coordination between this and the work to add dbus to libdnf in 
> [rpm-software-management/libdnf#941](https://github.com/rpm-software-management/libdnf/pull/941)
>  for example?

Well, we add this on request of the DNF team that need to be notified if 
something else (rpm cli) changes the rpmdb underneath their daemon. Note that 
this is very different from the lib dnf thing even if it also uses DBus. RPM 
will not offer a DBUS interface that can be queried or send commands to. All 
this does is sending out signals that notify who ever is interested that the 
rpmdb is changing.
I will probably even drop the second patch providing more detailed information 
until there are real use cases. So all this is going to do is sending out a 
ping at the start and the end of every transaction.

> For rpm-ostree we are already a DBus daemon, and having multiple other 
> libraries in the stack also going out and talking to DBus is going to be a 
> bit problematic.
> Binding this to the systemd-inhibit plugin makes sense because we already 
> turn that off for rpm-ostree (because it's transactional, there's no reason 
> to inhibit).

So this is going to be a plugin that can be disabled or just plainly not be 
installed in the first place. We will probably not integrate this into the 
systemd-inhibit plugin but have it as a separate plugin that is very similar 
and comes in it's own sub package.

Can you please elaborate on why sending some DBus signals should be problematic?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-641112150___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add support for dependency generators for RPMTAG_ORDERNAME (#1262)

2020-06-08 Thread Florian Festi
aka OrderWithRequires. Use __find_order in the attribute files

Resolves: #1257

Please test!
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1262

-- Commit Summary --

  * Add support for dependency generators for RPMTAG_ORDERNAME

-- File Changes --

M build/rpmfc.c (9)
M build/rpmfc.h (7)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1262.patch
https://github.com/rpm-software-management/rpm/pull/1262.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1262
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add way to set macro for --nocheck in rpmbuild (#316)

2020-06-08 Thread Florian Festi
Did a PR for this on Friday. Comments on #1256 are welcome.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/316#issuecomment-640425280___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-08 Thread Florian Festi
May be the macro should be renamed to not collide with the with/without 
mechanism. The bcond mechnism assumes that the actual value is not set as a 
macro but only on the command line and is basically read only within the spec. 
If you set the macro itself having two of them can lead to the awkward 
situation where but are set to one or both are set to zero. So I would prefere 
to only have one macro.
May be _nocheck is a better name and closer resembling the cli param. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256#issuecomment-640421215___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add _without_check macro (#1256)

2020-06-05 Thread Florian Festi
signaling and controling whether %check is executed during build.
The macro can be set globally or in the spec file. The --nocheck
parameter of rpmbuild takes precedence, though. If --nocheck is
passed to rpmbuild the macro set accordingly. Otherwise it is set
to 0 if not defined previously.

Resolves: #316
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1256

-- Commit Summary --

  * Add _without_check macro

-- File Changes --

M build/build.c (1)
M rpmbuild.c (6)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1256.patch
https://github.com/rpm-software-management/rpm/pull/1256.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1256
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-05 Thread Florian Festi
Split the package signals into a separate patch as they need some deeper 
discussion on how the plugin hooks should actually work and what new we need to 
add (see #1254).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-639431665___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Notify other programs when the rpmdb is changed via DBus (#1249)

2020-06-04 Thread Florian Festi
Well, DBus is not the same as DBus. There are two things you can do there:
This thing here is just sending signals. They go to the bus and are then 
relayed to everyone subscribing to them. I don't know that much about DBus but 
I would hope sending a few thousands signals shouldn't hurt anyone. By design 
there is no way for 3rd party processes to talk back to rpm. They either listen 
or they don't. This also means we need to send everything we think anyone might 
need.
Offering an RPM interface on DBus is a very different thing. This either needs 
some daemon or some bus-activated service - which is basically also a daemon. 
This allows users to basically do remote procedure calls to this daemon and get 
data back as a result. The DBus actually supports a tree like structure for 
making objects available and has some build in introspection interface. If we 
really want to add something like this we should probably talk to the DNF folks 
who are working on a daemon on their own.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1249#issuecomment-638800378___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix python ts.addErase() not raising exception on not-found packages (#1251)

2020-06-04 Thread Florian Festi
Merged #1251 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1251#event-3406472496___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-04 Thread Florian Festi
Yeah, I had the package info as a separate patch, but I figured it'd be easier 
to just delete the functions than splitting all the changes and fixes.
Otoh I could imaging some GUI tool to not blocking it's UI completely on an 
running transaction but instead just changing package by package.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-638790678___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2020-06-04 Thread Florian Festi
The plugin announces start and completion of transactions and
the installation and erasure of packages.

The patch still needs some polishing:

* Names of the DBus enities may need a second thought
* Man page is still missing a description of the dbus signal sent
* DBus config is not properly integrated into Makefile

Resolves: #1249 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1255

-- Commit Summary --

  * Add dbus-announce plugin

-- File Changes --

M doc/Makefile.am (5)
A doc/rpm-plugin-dbus-announce.8 (25)
M macros.in (1)
M plugins/Makefile.am (5)
A plugins/dbus_announce.c (198)
A plugins/org.rpm.conf (10)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1255.patch
https://github.com/rpm-software-management/rpm/pull/1255.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Psmpre and psmpost plugin callbacks executed multiple times per package (#1254)

2020-06-03 Thread Florian Festi
As psmpre and psmpost callbacks are basically used to report on the 
installed/removed packages one would think each of them is called exactly once 
per package. Unfortunately rpmpsmRun - which triggers them - is also called for 
other occasions like executing %posttrans and %verify scriptlets and checking 
the transaction. This is made worse by the callbacks neither providing the goal 
passed to rpmpsmRun nor an rpmts instance.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1254___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Notify other programs when the rpmdb is changed via DBus (#1249)

2020-06-03 Thread Florian Festi
Question here is what to actually send over the bus. For the initial use case 
just announcing the end of a transaction is enough. This allows long running 
processes to clue in on other tools changing the rpmdb. But there is obviously 
more that could be done: Announcing the start of a transaction may be used to 
signal in the UI that the rpmdb is currently blocked and the user has to wait 
before doing any transactions themselves.
We could also send over the content of the transaction (may be as operation, 
NEVRA, hash, id tuples) or send each package that just finished. Otoh this may 
be seen as an invitation to do something like triggers outside of rpm.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1249#issuecomment-638158114___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Fix python ts.addErase() not raising exception on not-found packages (#1251)

2020-06-03 Thread Florian Festi
Still not quite sure what the right behaviour is here. Raising the exception 
when passing in an non existing header number is all fine. It may also be fine 
for a name/label that is not found in the rpmdb. Where things get murky is when 
passing in an empty match iterator. I could imagine some code may rely on this 
just working and doing nothing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1251#issuecomment-638149568___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Don't auto-enable IO flushing on non-rotational disks (#1253)

2020-06-03 Thread Florian Festi
Merged #1253 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1253#event-3401230871___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Don't auto-enable IO flushing on non-rotational disks (#1253)

2020-06-03 Thread Florian Festi
This patch should also change the comment in macros.in as -1 no longer means 
auto detection. Otherwise this is obviously fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1253#issuecomment-638046886___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add pre-flight check for erased packages too (#1250)

2020-06-02 Thread Florian Festi
Merged #1250 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1250#event-3397654265___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Notify other programs when the rpmdb is changed via DBus (#1249)

2020-06-02 Thread Florian Festi
See https://bugzilla.redhat.com/show_bug.cgi?id=1816123 for initial request. 
Using DBus would allow pushing even more information like what packages got 
installed/removed etc.

This will be based on DBus signals as we (obviously) won't turn RPM into a 
daemon. During the transaction signals are going out onto the system bus but 
there will be no way to call into the RPM process or to query the rpmdb via 
DBus.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1249___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] ts.addErase(tsi.pkg.idx) skips already erased items (#1214)

2020-06-02 Thread Florian Festi
As the change here is between the libsolv transaction and the creation of the 
rpm transaction checking for changes in the database can't really solve the 
problems if done within rpm only. DNF could check the database after obtaining 
the ts lock, but that's something we allow already - it's just not done.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1214#issuecomment-637416621___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] ts.addErase(tsi.pkg.idx) skips already erased items (#1214)

2020-06-02 Thread Florian Festi
Yes, there may be more holes. But here all these additional checks won't catch 
anything unless DNF checks the return value of addErase. As RPM just doesn't 
add the transaction element at all there is nothing to check later. One could 
argue that rpm should just destroy the transaction but I'd argue an API use may 
actually want to ignore the error message and be content with the package no 
longer being there.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1214#issuecomment-637415093___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] ts.addErase(tsi.pkg.idx) skips already erased items (#1214)

2020-06-02 Thread Florian Festi
Closed #1214.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1214#event-3396480725___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] ts.addErase(tsi.pkg.idx) skips already erased items (#1214)

2020-06-02 Thread Florian Festi
Just to add this here, too: ts.addErase returns an error code. False aka 0 is 
the erase element could be added and True aka 1 of it can't. DNF is ignoring 
this. So the transaction element is not disappearing - it is not created in the 
first place. I can't really see where RPM is at fault here. Closing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1214#issuecomment-637379312___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Preparing for rpm 4.16.0-beta1 (#1244)

2020-05-28 Thread Florian Festi
Merged #1244 into rpm-4.16.x.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1244#event-3382355093___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Bump CI Fedora version from 31 to 32 aka latest stable (#1243)

2020-05-28 Thread Florian Festi
Merged #1243 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1243#event-3381787330___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add %postbuild section / Allow dynamic sub packages (#1239)

2020-05-28 Thread Florian Festi
@ffesti pushed 1 commit.

9b1a24a921f281747eb475276a3693471ee2b0b1  Add suppport for %postbuild spec 
section


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1239/files/23077b960b01e952ea6acc6596ad4b66bfbe534a..9b1a24a921f281747eb475276a3693471ee2b0b1
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Convenient version comparison macro (#1217)

2020-05-27 Thread Florian Festi
Closed #1217 via #1233.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1217#event-3377935109___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Support rpm version comparison in expressions (#1233)

2020-05-27 Thread Florian Festi
Merged #1233 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1233#event-3377935097___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Add an labelCompare() equivalent to Lua interface (#897)

2020-05-27 Thread Florian Festi
Closed #897 via a1d2722c4a88a49008daa58653c9c5ebf9344d63.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/897#event-3377826327___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add an API + bindings for parsing EVR (#561)

2020-05-27 Thread Florian Festi
Closed #561 via #1221.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/561#event-3377826209___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add a version parsing and comparison API to librpmio (#1221)

2020-05-27 Thread Florian Festi
Merged #1221 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1221#event-3377826189___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


  1   2   3   4   5   6   7   8   9   >