I don't see any need for further discussion here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-656689650___
Merged #1272 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#event-3534004891___
Rpm-maint mailing list
Rpm-mai
I guess given that the magic stuff hasn't worked in forever, it's fine to just
drop it and not worry about it flaking in the future.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/
> To be clear, `%__foo_path` and `%__foo_magic` filters are a union, not an
> intersection? That's actually somewhat surprising behavior...
Union by default but can be switched with `magic_and_path` flag in
`%__foo_flags` to intersection.
--
You are receiving this because you are subscribed to
@pmatilai To be clear, `%__foo_path` and `%__foo_magic` filters are a union,
not an intersection? That's actually somewhat surprising behavior...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-softwar
@Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#pullrequestreview-437395755___
R
The change looks good to me. And we've been using this in RHEL for a while with
good results.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649454084___
Ack. I'll ping people.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649284471___
Rpm-maint mailing list
Rpm
I was kinda expecting others from the Python camp to evaluate, I'm out of loop
with what's going on in this land these days.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull
Is this good to be merged?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649113390___
Rpm-maint mailing list
Commit message amended.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-645958035___
Rpm-maint mailing list
Rpm
Indeed! This makes much more sense now, thanks. I'll amend the commit message.
Before (file-5.38-6.fc33):
```
sh-5.0# file -z -e tokens
/opt/usr/lib/python3.8/site-packages/{__pycache__/,}file*
/opt/usr/lib/python3.8/site-packages/__pycache__/file.cpython-38.opt-1.pyc: data
/opt/usr/lib/python3
> sounds more like a libmagic change than rpm one.
Let me test that actually.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-645949664___
I'm having some trouble parsing the description of what happened. But if files
suddenly getting classified as python based on magic where they were not before
sounds more like a libmagic change than rpm one.
--
You are receiving this because you are subscribed to this thread.
Reply to this ema
Downstream discovery in
https://src.fedoraproject.org/rpms/python-rpm-generators/pull-request/20
I wonder, what changed in RPM?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/
The %__python_magic filter suddenly got suppressed by the magic filter.
Hence, the generator started to pick files like:
/opt/usr/lib/python3.X/...
Required python(abi). We don't need to filter the files by file magic, so
we drop it.
Previously, it seems that the behavior was flaky.
The pat
16 matches
Mail list logo
