@pmatilai commented on this pull request.
> @@ -15,6 +15,7 @@
#include
#include
+#include
Yup, preinstall.am sometimes needs a little kick (aka rm -f) when public
headers change.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
@jessorensen commented on this pull request.
> @@ -15,6 +15,7 @@
#include
#include
+#include
Nevermind, doing a git reset --hard, cleared some local changes to
preinstall.am, which fixed it. Sorry for the noise.
--
You are receiving this because you are subscribed to this thread.
@jessorensen commented on this pull request.
> @@ -15,6 +15,7 @@
#include
#include
+#include
This change breaks the build for me here:
```
libtool: compile: gcc -DHAVE_CONFIG_H -I.. -I.. -I../include/ -I../misc
-DRPMCONFIGDIR=\"/usr/lib/rpm\" -DLOCALSTATEDIR=\"/var\" -I../luaext/
:fireworks:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1233#issuecomment-634635458___
Rpm-maint mailing list
Merged #1233 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1233#event-3377935097___
Rpm-maint mailing list
Rebased.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1233#issuecomment-634630500___
Rpm-maint mailing list
This looks good (only looking at the last three - parser related - patches).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai commented on this pull request.
>
You can use the standard operators to combine terms: logical
operators &&, ||, !, relational operators !=, ==, <, > , <=, >=,
arithmetic operators +, -, /, *, the ternary operator ? :, and
parentheses. For example, "%[ 3 + 4 * (1 + %two) ]"
@pmatilai commented on this pull request.
> @@ -241,15 +241,17 @@ newline is deleted). Note the 2nd % needed to escape
> the arguments to
Expression expansion can be performed using "%[expression]". An
expression consists of terms that can be combined using
-operators. Rpm supports two
@pmatilai pushed 1 commit.
27d30c2a7566becc31d9048781f9f56115a424dd Support rpm version comparison in
expressions
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
> So, this basically compares evrs, correct?
Yes.
It also has provisions for validating EVR strings, but the only validation
currently done is that an EVR string cannot be empty.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@hroncok commented on this pull request.
> @@ -241,15 +241,17 @@ newline is deleted). Note the 2nd % needed to escape
> the arguments to
Expression expansion can be performed using "%[expression]". An
expression consists of terms that can be combined using
-operators. Rpm supports two
So, this basically compares evrs, correct?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1233#issuecomment-630815654___
This is on top of #1221 as that is required for this to work, but in a separate
PR to hopefully keep it more reviewable.
We might want to add s"" as an alias to regular "" just for symmetry if/when
this goes in, but leaving that out for now as it doesn't add anything new.
--
You are receiving
Adds rpm version as a new expression value type, denoted by v
(similar to Python u, b etc), which are compared using
rpm version comparison algorithm rather than regular string comparison.
For example in specs:
```
%if v%{python_version} v3.9
...
%endif
```
...but also command lines,
15 matches
Mail list logo
