Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
Besides stopping the build, it should emit the exact command that was executing when it failed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-1831777535 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
I'm working on updating the generators for Rust crates, and I came across the same problem. Sometimes the package spec is out of date with the upstream project's metadata, which triggers errors during generation of Provides and Requires and results in packages with broken metadata. I now pushed the same workaround as the Python macros (i.e. output a string that's not a valid RPM identifier), but that's not really ideal. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-1427027120 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
Yup, and there's more: every caller of rpmfcExec() does so with slightly different expectations of what will happen in what situations, and rpmfcHelper() was doing +1 on errors whereas the lower layers were returning -1 and ... whatnot. It needs a *careful* review on reapproach. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-648716354___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
For references, here's the fallout: https://github.com/rpm-software-management/rpm/issues/1285 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-648710531___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
Reopening as the fix was reverted (it was just too broken to live) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-648660465___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
Reopened #1183. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#event-3476265711___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
Closed #1183 via #1271. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#event-3472161387___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
> There are 3 things I'd like to see fixed: > > * the traceback should say: `Cannot process Python package version: 0+unknown` > * the build should abort on errors > * the version is [actually > valid](https://www.python.org/dev/peps/pep-0440/#local-version-identifiers) First and last issue have been fixed in https://github.com/rpm-software-management/rpm/pull/1242. What remains is that the build should abort on errors. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-637692530___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
> @torsava OK, let's wait for the next unexpected error. But wrapping > everything in try-except and failing with useful error message is not a bad > idea. Ok, I'll add it to my PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-616518564___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
@torsava OK, let's wait for the next unexpected error. But wrapping everything in try-except and failing with useful error message is not a bad idea. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-616514455___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
The almost-backwards-compatible way would be to have a specific exit code that should abort the build. E.g. "exit with 66 to abort the build". Technically, I think it is possible to abort the build by generating an invalid dependency, but that is hardly an API. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-616513539___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
Yup, the generator failure handling is a funny mess: - in legacy generators (the "external generator") only provide generation can cause build-failure - in current generators, all script error codes are ignored - ...except for buildrequires generator where script errors cause build failure Of course the only sane thing is to always fail on non-zero return, with maybe a macro override to allow temporarily working around bugs etc. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-616512291___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RPM generators errors are ignored (#1183)
> the exception when the conversion fails is not telling anything useful As this was an unexpected error, we don't know at what point in the code the next unexpected error would strike. So the way I see it we would have to wrap the whole machinery in `try..except` which isn't great, or do you propose a different solution, @hroncok ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1183#issuecomment-616507483___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
