Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
Merging as is for now, thanks for the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#issuecomment-648045721___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
Merged #1246 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#event-3472197426___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
Most tools rpm interacts with don't *have* their own configuration, that's mostly limited to SCMs. It might well be sufficient set HOME to some temporary build directory during build scriptlets, or something like that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#issuecomment-640433767___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
> I think the more feasible approach is to have rpm use it's own fresh > configuration for git. I agree that, but then we should have fresh configurations for every tools we used in ``rpmbuild``, which is a user-space command. That's too much work, seems we have to build another mock environment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#issuecomment-639890567___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
We can't possibly anticipate and work around every setting a user might have. I think the more feasible approach is to have rpm use it's own fresh configuration for git. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#issuecomment-639306588___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
@ignatenkobrain approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246#pullrequestreview-422424536___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] macros: force add files to git index (#1246)
Its rarely the case that the user may set global ``core.excludesfile``, ``git add .`` may not add all the files as expect. It will fail to build if the excluded files are patch-needed. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1246 -- Commit Summary -- * macros: force add files to git index -- File Changes -- M macros.in (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1246.patch https://github.com/rpm-software-management/rpm/pull/1246.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1246 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
